This patch series enhances scheduler support of xl. Patch 1: xl sched-credit: support long options Patch 2: Support cpupools in xl sched-credit Patch 3: Support of xl sched-credit2 Patch 4: Correct error message in libxl_sched_credit_domain_get() Patch 5: Support of xl sched-sedf 7 files changed, 622 insertions(+), 38 deletions(-) docs/man/xl.pod.1 | 90 ++++++++- tools/libxl/libxl.c | 100 ++++++++++ tools/libxl/libxl.h | 8 tools/libxl/libxl_types.idl | 13 + tools/libxl/xl.h | 2 tools/libxl/xl_cmdimpl.c | 418 +++++++++++++++++++++++++++++++++++++++---- tools/libxl/xl_cmdtable.c | 29 ++ _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Patch subject is complete summary. 2 files changed, 26 insertions(+), 7 deletions(-) docs/man/xl.pod.1 | 15 ++++++++++----- tools/libxl/xl_cmdimpl.c | 18 ++++++++++++++++-- _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Patch subject is complete summary. 5 files changed, 98 insertions(+), 30 deletions(-) docs/man/xl.pod.1 | 4 + tools/libxl/libxl.c | 1 tools/libxl/libxl_types.idl | 1 tools/libxl/xl_cmdimpl.c | 117 ++++++++++++++++++++++++++++++++----------- tools/libxl/xl_cmdtable.c | 5 + _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Patch subject is complete summary. 7 files changed, 213 insertions(+) docs/man/xl.pod.1 | 29 ++++++++++ tools/libxl/libxl.c | 48 +++++++++++++++++ tools/libxl/libxl.h | 4 + tools/libxl/libxl_types.idl | 4 + tools/libxl/xl.h | 1 tools/libxl/xl_cmdimpl.c | 119 +++++++++++++++++++++++++++++++++++++++++++ tools/libxl/xl_cmdtable.c | 8 ++ _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Patch subject is complete summary. 1 file changed, 1 insertion(+), 1 deletion(-) tools/libxl/libxl.c | 2 +- _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Patch subject is complete summary. 7 files changed, 284 insertions(+) docs/man/xl.pod.1 | 42 +++++++++++ tools/libxl/libxl.c | 49 ++++++++++++ tools/libxl/libxl.h | 4 + tools/libxl/libxl_types.idl | 8 ++ tools/libxl/xl.h | 1 tools/libxl/xl_cmdimpl.c | 164 +++++++++++++++++++++++++++++++++++++++++++ tools/libxl/xl_cmdtable.c | 16 ++++ _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Please ignore, hg configuration problems! On 11/17/2011 11:50 AM, Juergen Gross wrote:> This patch series enhances scheduler support of xl. > > Patch 1: xl sched-credit: support long options > Patch 2: Support cpupools in xl sched-credit > Patch 3: Support of xl sched-credit2 > Patch 4: Correct error message in libxl_sched_credit_domain_get() > Patch 5: Support of xl sched-sedf > > 7 files changed, 622 insertions(+), 38 deletions(-) > docs/man/xl.pod.1 | 90 ++++++++- > tools/libxl/libxl.c | 100 ++++++++++ > tools/libxl/libxl.h | 8 > tools/libxl/libxl_types.idl | 13 + > tools/libxl/xl.h | 2 > tools/libxl/xl_cmdimpl.c | 418 +++++++++++++++++++++++++++++++++++++++---- > tools/libxl/xl_cmdtable.c | 29 ++ > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel > >-- Juergen Gross Principal Developer Operating Systems PDG ES&S SWE OS6 Telephone: +49 (0) 89 3222 2967 Fujitsu Technology Solutions e-mail: juergen.gross@ts.fujitsu.com Domagkstr. 28 Internet: ts.fujitsu.com D-80807 Muenchen Company details: ts.fujitsu.com/imprint.html _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Ian Campbell
2011-Nov-17 11:16 UTC
Re: [Xen-devel] [PATCH 1 of 5] [mq]: sched-credit-options
On Thu, 2011-11-17 at 10:50 +0000, Juergen Gross wrote:> Patch subject is complete summary.I think you''ve forgotten to qrefresh to pickup the real summary or something (for all mails). Ian.> > > 2 files changed, 26 insertions(+), 7 deletions(-) > docs/man/xl.pod.1 | 15 ++++++++++----- > tools/libxl/xl_cmdimpl.c | 18 ++++++++++++++++-- > >_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Andrew Cooper
2011-Nov-17 11:22 UTC
Re: [Xen-devel] [PATCH 1 of 5] [mq]: sched-credit-options
On 17/11/11 11:16, Ian Campbell wrote:> On Thu, 2011-11-17 at 10:50 +0000, Juergen Gross wrote: >> Patch subject is complete summary. > I think you''ve forgotten to qrefresh to pickup the real summary or > something (for all mails). > > Ian.Depending on which options you pass to patchbomb, you sometimes have to pop and push all before comments get picked up. ~Andrew (who will make an alteration to the relevant web page to this effect)>> >> 2 files changed, 26 insertions(+), 7 deletions(-) >> docs/man/xl.pod.1 | 15 ++++++++++----- >> tools/libxl/xl_cmdimpl.c | 18 ++++++++++++++++-- >> >> > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel-- Andrew Cooper - Dom0 Kernel Engineer, Citrix XenServer T: +44 (0)1223 225 900, http://www.citrix.com _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
This patch series enhances scheduler support of xl. Patch 1: xl sched-credit: support long options Patch 2: Support cpupools in xl sched-credit Patch 3: Support of xl sched-credit2 Patch 4: Correct error message in libxl_sched_credit_domain_get() Patch 5: Support of xl sched-sedf 7 files changed, 622 insertions(+), 38 deletions(-) docs/man/xl.pod.1 | 90 ++++++++- tools/libxl/libxl.c | 100 ++++++++++ tools/libxl/libxl.h | 8 tools/libxl/libxl_types.idl | 13 + tools/libxl/xl.h | 2 tools/libxl/xl_cmdimpl.c | 418 +++++++++++++++++++++++++++++++++++++++---- tools/libxl/xl_cmdtable.c | 29 ++ _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Juergen Gross
2011-Nov-17 12:00 UTC
[Xen-devel] [PATCH 1 of 5] xl sched-credit: support long options
The help text of xl sched-credit supported long options. Neither the man page nor the implementation did. Signed-off-by: juergen.gross@ts.fujitsu.com 2 files changed, 26 insertions(+), 7 deletions(-) docs/man/xl.pod.1 | 15 ++++++++++----- tools/libxl/xl_cmdimpl.c | 18 ++++++++++++++++-- _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Juergen Gross
2011-Nov-17 12:00 UTC
[Xen-devel] [PATCH 2 of 5] Support cpupools in xl sched-credit
Adds cpupool awareness to output of xl sched-credit. Output can now be restricted to a specific cpupool. The domains are printed for each cpupool seperately. The loop over cpupools and domains is seperated from the main command implementation to be able to support other schedulers as well. Signed-off-by: juergen.gross@ts.fujitsu.com 5 files changed, 98 insertions(+), 30 deletions(-) docs/man/xl.pod.1 | 4 + tools/libxl/libxl.c | 1 tools/libxl/libxl_types.idl | 1 tools/libxl/xl_cmdimpl.c | 117 ++++++++++++++++++++++++++++++++----------- tools/libxl/xl_cmdtable.c | 5 + _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Juergen Gross
2011-Nov-17 12:00 UTC
[Xen-devel] [PATCH 3 of 5] Support of xl sched-credit2
Supports the xl subcommand sched-credit2. Signed-off-by: juergen.gross@ts.fujitsu.com 7 files changed, 213 insertions(+) docs/man/xl.pod.1 | 29 ++++++++++ tools/libxl/libxl.c | 48 +++++++++++++++++ tools/libxl/libxl.h | 4 + tools/libxl/libxl_types.idl | 4 + tools/libxl/xl.h | 1 tools/libxl/xl_cmdimpl.c | 119 +++++++++++++++++++++++++++++++++++++++++++ tools/libxl/xl_cmdtable.c | 8 ++ _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Juergen Gross
2011-Nov-17 12:00 UTC
[Xen-devel] [PATCH 4 of 5] Correct error message in libxl_sched_credit_domain_get()
Just a typo... Signed-off-by: juergen.gross@ts.fujitsu.com 1 file changed, 1 insertion(+), 1 deletion(-) tools/libxl/libxl.c | 2 +- _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Supports the xl subcommand sched-sedf. The man page is only a minimal version (copy from xm man page without examples). BTW: the xm man page seems not to be in sync with xm sched-sedf -h regarding the time units. I used milliseconds in the xl implementation. Only minimal semantical checks of parameters. Signed-off-by: juergen.gross@ts.fujitsu.com 7 files changed, 284 insertions(+) docs/man/xl.pod.1 | 42 +++++++++++ tools/libxl/libxl.c | 49 ++++++++++++ tools/libxl/libxl.h | 4 + tools/libxl/libxl_types.idl | 8 ++ tools/libxl/xl.h | 1 tools/libxl/xl_cmdimpl.c | 164 +++++++++++++++++++++++++++++++++++++++++++ tools/libxl/xl_cmdtable.c | 16 ++++ _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Hi Dario, On 11/23/2011 10:11 AM, Dario Faggioli wrote:> On Thu, 2011-11-17 at 13:00 +0100, Juergen Gross wrote: >> This patch series enhances scheduler support of xl. >> > Hi Juergen, > > I applied your series to test some changes I''m doing in sched_adjust, > but here''s what I''m getting when I boot with sched=credit2. > > # xl sched-credit2 > Cpupool Pool-0: > Name ID Weight > xl: symbol lookup error: xl: undefined symbol: libxl_sched_credit2_domain_get > > `xl sched-credit'' seems to work fine (sedf I can''t test, does not boot > on my box). > > Could that be my fault? Can I do anything else to help you debug/fix > this?Are you sure the patches applied completely? libxl_sched_credit2_domain_get() is added in the third patch to libxl.c, the usage in xl_cmdimpl.c is in the same patch. I tested it on my box and all worked fine. Juergen -- Juergen Gross Principal Developer Operating Systems PDG ES&S SWE OS6 Telephone: +49 (0) 89 3222 2967 Fujitsu Technology Solutions e-mail: juergen.gross@ts.fujitsu.com Domagkstr. 28 Internet: ts.fujitsu.com D-80807 Muenchen Company details: ts.fujitsu.com/imprint.html
On Wed, 2011-11-23 at 09:11 +0000, Dario Faggioli wrote:> On Thu, 2011-11-17 at 13:00 +0100, Juergen Gross wrote: > > This patch series enhances scheduler support of xl. > > > Hi Juergen, > > I applied your series to test some changes I''m doing in sched_adjust, > but here''s what I''m getting when I boot with sched=credit2. > > # xl sched-credit2 > Cpupool Pool-0: > Name ID Weight > xl: symbol lookup error: xl: undefined symbol: libxl_sched_credit2_domain_getIs there a chance you are picking up an older version of libxl from somewhere?> > `xl sched-credit'' seems to work fine (sedf I can''t test, does not boot > on my box). > > Could that be my fault? Can I do anything else to help you debug/fix > this? > > Thanks and Regards, > Dario >
On Wed, 2011-11-23 at 10:55 +0000, Dario Faggioli wrote:> On Wed, 2011-11-23 at 11:24 +0100, Dario Faggioli wrote: > > On Wed, 2011-11-23 at 09:24 +0000, Ian Campbell wrote: > > > > # xl sched-credit2 > > > > Cpupool Pool-0: > > > > Name ID Weight > > > > xl: symbol lookup error: xl: undefined symbol: libxl_sched_credit2_domain_get > > > > > > Is there a chance you are picking up an older version of libxl from > > > somewhere? > > > > > More than once... That should be the culprit for me too, but I''m still > > trying to figure out how... :-) > > > Ok, found! Sorry for having bothered you in the first place. > > The thing is I''m running Debian Sid on the testbox, and there seems to > be no ''/usr/lib64'' there (neither as a real directory nor as a symlink > to ''/usr/lib''), while build system put the libraries in > ''dist/install/usr/lib64''. Installing the xen distribution (which is > basically unpacking an archive here) created ''/ust/lib64'', but it does > not appear to be on the search path for shared libraries on such > distro... Could that be an issue?/usr/lib64 used to be a symlink to /usr/lib on Debian but that has gone away due to the beginnings of multiarch support. It''s not clear to me if this is a bug of sorts in multiarch (or at least in the transition) or if we ought to be doing something to work with such systems. My build/test machines are all Debian Stable so I haven''t had to think about it too hard yet since multiarch-ification is only going on in unstable (perhaps testing too, I don''t know). Short term you can edit config/StdGNU.mk to change LIBLEAFDIR_x86_64. Ian.