Xen devel - Nov 2011 - [PATCH] libxl: allow to enable/disable cpuid bits

Allow to enable/disable SVM specific cpuid bits
in the guest config file via cpuid config option.
Also allow to enable/disable the hypervisor cpuid bit
in the guest config file. We need to disable the
hypervisor cpuid bit to get Hyper-V going.

Signed-off-by: Christoph Egger <Christoph.Egger@amd.com>

-- 
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Einsteinring 24, 85689 Dornach b. Muenchen
Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Christoph Egger writes ("[Xen-devel] [PATCH] libxl: allow to enable/disable
cpuid bits"):
> 
> Allow to enable/disable SVM specific cpuid bits
> in the guest config file via cpuid config option.
> Also allow to enable/disable the hypervisor cpuid bit
> in the guest config file. We need to disable the
> hypervisor cpuid bit to get Hyper-V going.
The change itself looks plausible to me.  However I don''t know much
about cpuid; can you get an ack from a hypervisor maintainer or an
suitable expert ?

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

On 11/01/11 20:07, Ian Jackson wrote:
> Christoph Egger writes ("[Xen-devel] [PATCH] libxl: allow to
enable/disable cpuid bits"):
>>
>> Allow to enable/disable SVM specific cpuid bits
>> in the guest config file via cpuid config option.
>> Also allow to enable/disable the hypervisor cpuid bit
>> in the guest config file. We need to disable the
>> hypervisor cpuid bit to get Hyper-V going.
>
> The change itself looks plausible to me.  However I don''t know
much
> about cpuid; can you get an ack from a hypervisor maintainer or an
> suitable expert ?
Keir? Tim?



Christoph

-- 
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Einsteinring 24, 85689 Dornach b. Muenchen
Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

At 10:23 +0100 on 02 Nov (1320229392), Christoph Egger
wrote:
> On 11/01/11 20:07, Ian Jackson wrote:
> >Christoph Egger writes ("[Xen-devel] [PATCH] libxl: allow to 
> >enable/disable cpuid bits"):
> >>
> >>Allow to enable/disable SVM specific cpuid bits
> >>in the guest config file via cpuid config option.
> >>Also allow to enable/disable the hypervisor cpuid bit
> >>in the guest config file. We need to disable the
> >>hypervisor cpuid bit to get Hyper-V going.
> >
> >The change itself looks plausible to me.  However I don''t know
much
> >about cpuid; can you get an ack from a hypervisor maintainer or an
> >suitable expert ?
> 
> Keir? Tim?
I think the hypervisor bit should be given a better name than
''raz'' --
although it is read-as-zero on real hardware that doesn''t distinguish
it
from other raz bits, or describe what it does. 

''hypervisor'' maybe, to match
''X86_FEATURE_HYPERVISOR'' elsewhere in the
Xen code? 

With that change, Acked-by: Tim Deegan <tim@xen.org>

Cheers,

Tim.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

On 11/02/11 11:20, Tim Deegan wrote:
> At 10:23 +0100 on 02 Nov (1320229392), Christoph Egger wrote:
>> On 11/01/11 20:07, Ian Jackson wrote:
>>> Christoph Egger writes ("[Xen-devel] [PATCH] libxl: allow to
>>> enable/disable cpuid bits"):
>>>>
>>>> Allow to enable/disable SVM specific cpuid bits
>>>> in the guest config file via cpuid config option.
>>>> Also allow to enable/disable the hypervisor cpuid bit
>>>> in the guest config file. We need to disable the
>>>> hypervisor cpuid bit to get Hyper-V going.
>>>
>>> The change itself looks plausible to me.  However I don''t
know much
>>> about cpuid; can you get an ack from a hypervisor maintainer or an
>>> suitable expert ?
>>
>> Keir? Tim?
>
> I think the hypervisor bit should be given a better name than
''raz'' --
> although it is read-as-zero on real hardware that doesn''t
distinguish it
> from other raz bits, or describe what it does.
>
> ''hypervisor'' maybe, to match
''X86_FEATURE_HYPERVISOR'' elsewhere in the
> Xen code?
>
> With that change, Acked-by: Tim Deegan<tim@xen.org>
New version with that change attached.

Signed-off-by: Christoph Egger <Christoph.Egger@amd.com>


-- 
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Einsteinring 24, 85689 Dornach b. Muenchen
Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Christoph Egger writes ("Re: [Xen-devel] [PATCH] libxl: allow to
enable/disable cpuid bits"):
> New version with that change attached.
> 
> Signed-off-by: Christoph Egger <Christoph.Egger@amd.com>
Applied, thanks to both of you.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel