Noted the test phase was restricted in gentoo''s ebuilds. It seems for good reason. The test structure is broken since it''s missing its own files. First ../../tools/libxc/xc_dom.h:17:31: fatal error: xen/libelf/libelf.h: No such file or directory I fixed that, the path is fixed with sed -e ''s:#include <xen/libelf.h>:#include <../../xen/ include/xen/libelf.h>:'' -i ./tools/libxc/xc_dom.h The next I couldn''t fix. The header is simply missing. xen/lowlevel/xl/xl.c:210:25: fatal error: _pyxl_types.h: No such file or directory It''s not there to be found!!! From there ofcourse there''s no way of getting thru. Removing reference to the header ofcourse lead to another mini disaster. -Ixen/lowlevel/xl -I/usr/include/python2.7 -c xen/lowlevel/xl/xl.c -o build/temp.linux-x86_64-2.7/xen/lowlevel/xl/xl.o -fno-strict-aliasing xen/lowlevel/xl/xl.c:210:1: warning: missing terminating " character xen/lowlevel/xl/xl.c:210:1: error: missing terminating " character xen/lowlevel/xl/xl.c: In function ''pyxl_list_domains'': xen/lowlevel/xl/xl.c:394:9: error: ''Py_dominfo'' undeclared (first use in this function) xen/lowlevel/xl/xl.c:394:9: note: each undeclared identifier is reported only once for each function it appears in xen/lowlevel/xl/xl.c:394:21: error: ''di'' undeclared (first use in this function) xen/lowlevel/xl/xl.c: In function ''pyxl_pci_add'': xen/lowlevel/xl/xl.c:497:5: error: ''Py_device_pci'' undeclared (first use in this function) xen/lowlevel/xl/xl.c:497:20: error: ''pci'' undeclared (first use in this function) xen/lowlevel/xl/xl.c:506:27: error: expected expression before '')'' token xen/lowlevel/xl/xl.c: In function ''pyxl_pci_del'': xen/lowlevel/xl/xl.c:517:5: error: ''Py_device_pci'' undeclared (first use in this function) xen/lowlevel/xl/xl.c:517:20: error: ''pci'' undeclared (first use in this function) xen/lowlevel/xl/xl.c:527:27: error: expected expression before '')'' token xen/lowlevel/xl/xl.c: In function ''pyxl_pci_parse'': xen/lowlevel/xl/xl.c:538:5: error: ''Py_device_pci'' undeclared (first use in this function) xen/lowlevel/xl/xl.c:538:20: error: ''pci'' undeclared (first use in this function) xen/lowlevel/xl/xl.c: In function ''pyxl_pci_list_assignable'': xen/lowlevel/xl/xl.c:575:9: error: ''Py_device_pci'' undeclared (first use in this function) xen/lowlevel/xl/xl.c:575:24: error: ''pd'' undeclared (first use in this function) xen/lowlevel/xl/xl.c: In function ''pyxl_pci_list'': xen/lowlevel/xl/xl.c:611:9: error: ''Py_device_pci'' undeclared (first use in this function) xen/lowlevel/xl/xl.c:611:24: error: ''pd'' undeclared (first use in this function) xen/lowlevel/xl/xl.c: At top level: xen/lowlevel/xl/xl.c:706:5: error: ''PKG'' undeclared here (not in a function) xen/lowlevel/xl/xl.c:706:9: error: expected ''}'' before string constant xen/lowlevel/xl/xl.c: In function ''initxl'': xen/lowlevel/xl/xl.c:761:43: error: expected '')'' before string constant xen/lowlevel/xl/xl.c:761:43: error: too few arguments to function ''PyErr_NewException'' /usr/include/python2.7/pyerrors.h:223:24: note: declared here error: command ''x86_64-pc-linux-gnu-gcc'' failed with exit status 1 Build failed 0x100 make[1]: *** [test] Error 1 make[1]: Leaving directory `/var/tmp/portage/portage/app-emulation/xen-4.1.2/work/xen-4.1.2/tools/python'' make: *** [test] Error 2 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On Tue, 2011-10-25 at 21:09 +0100, Windows Live wrote:> Noted the test phase was restricted in gentoo''s ebuilds. It seems for > good > reason. > > The test structure is broken since it''s missing its own files. > First > ../../tools/libxc/xc_dom.h:17:31: fatal error: xen/libelf/libelf.h: No > such > file or directory > I fixed that, the path is fixed with > > sed -e ''s:#include <xen/libelf.h>:#include <../../xen/ > include/xen/libelf.h>:'' -i ./tools/libxc/xc_dom.hThe right solution to this problem would be to add the correct -I<path> to the relevant gcc invocation (perhaps via CFLAGS or similar). Messing with the actual included filename will only end up breaking something else. Unfortunately you don''t describe what version of Xen you are using, what patches you have applied. what commands you are running or what you are actually trying to achieve. Based on the above and below descriptions of the sorts of things you have tried I rather suspect that your attempts to "fix" things have made things worse. Please read http://wiki.xen.org/xenwiki/AskingXenDevelQuestions and http://wiki.xen.org/xenwiki/ReportingBugs , then revert your local changes and report the original error which caused you to go down this path. Ian.> The next I couldn''t fix. The header is simply missing. > > xen/lowlevel/xl/xl.c:210:25: fatal error: _pyxl_types.h: No such file > or > directory > > It''s not there to be found!!! From there ofcourse there''s no way of > getting > thru. Removing reference to the header ofcourse lead to another mini > disaster. > > -Ixen/lowlevel/xl -I/usr/include/python2.7 -c xen/lowlevel/xl/xl.c -o > build/temp.linux-x86_64-2.7/xen/lowlevel/xl/xl.o -fno-strict-aliasing > xen/lowlevel/xl/xl.c:210:1: warning: missing terminating " character > xen/lowlevel/xl/xl.c:210:1: error: missing terminating " character > xen/lowlevel/xl/xl.c: In function ''pyxl_list_domains'': > xen/lowlevel/xl/xl.c:394:9: error: ''Py_dominfo'' undeclared (first use > in this > function) > xen/lowlevel/xl/xl.c:394:9: note: each undeclared identifier is > reported only > once for each function it appears in > xen/lowlevel/xl/xl.c:394:21: error: ''di'' undeclared (first use in this > function) > xen/lowlevel/xl/xl.c: In function ''pyxl_pci_add'': > xen/lowlevel/xl/xl.c:497:5: error: ''Py_device_pci'' undeclared (first > use in > this function) > xen/lowlevel/xl/xl.c:497:20: error: ''pci'' undeclared (first use in > this > function) > xen/lowlevel/xl/xl.c:506:27: error: expected expression before '')'' > token > xen/lowlevel/xl/xl.c: In function ''pyxl_pci_del'': > xen/lowlevel/xl/xl.c:517:5: error: ''Py_device_pci'' undeclared (first > use in > this function) > xen/lowlevel/xl/xl.c:517:20: error: ''pci'' undeclared (first use in > this > function) > xen/lowlevel/xl/xl.c:527:27: error: expected expression before '')'' > token > xen/lowlevel/xl/xl.c: In function ''pyxl_pci_parse'': > xen/lowlevel/xl/xl.c:538:5: error: ''Py_device_pci'' undeclared (first > use in > this function) > xen/lowlevel/xl/xl.c:538:20: error: ''pci'' undeclared (first use in > this > function) > xen/lowlevel/xl/xl.c: In function ''pyxl_pci_list_assignable'': > xen/lowlevel/xl/xl.c:575:9: error: ''Py_device_pci'' undeclared (first > use in > this function) > xen/lowlevel/xl/xl.c:575:24: error: ''pd'' undeclared (first use in this > function) > xen/lowlevel/xl/xl.c: In function ''pyxl_pci_list'': > xen/lowlevel/xl/xl.c:611:9: error: ''Py_device_pci'' undeclared (first > use in > this function) > xen/lowlevel/xl/xl.c:611:24: error: ''pd'' undeclared (first use in this > function) > xen/lowlevel/xl/xl.c: At top level: > xen/lowlevel/xl/xl.c:706:5: error: ''PKG'' undeclared here (not in a > function) > xen/lowlevel/xl/xl.c:706:9: error: expected ''}'' before string constant > xen/lowlevel/xl/xl.c: In function ''initxl'': > xen/lowlevel/xl/xl.c:761:43: error: expected '')'' before string > constant > xen/lowlevel/xl/xl.c:761:43: error: too few arguments to function > ''PyErr_NewException'' > /usr/include/python2.7/pyerrors.h:223:24: note: declared here > error: command ''x86_64-pc-linux-gnu-gcc'' failed with exit status 1 > Build failed 0x100 > make[1]: *** [test] Error 1 > make[1]: Leaving directory > `/var/tmp/portage/portage/app-emulation/xen-4.1.2/work/xen-4.1.2/tools/python'' > make: *** [test] Error 2 >_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
I gather this should go to the devel alias preferably since I can''t undo sending tho the dev From: johneed@hotmail.com To: ian.campbell@citrix.com Subject: RE: [Xen-devel] test structure missing files Date: Wed, 26 Oct 2011 05:58:18 +0800> Subject: Re: [Xen-devel] test structure missing files > From: Ian.Campbell@citrix.com > To: johneed@hotmail.com > CC: xen-devel@lists.xensource.com > Date: Tue, 25 Oct 2011 21:38:06 +0100 > > > The right solution to this problem would be to add the correct -I<path> > to the relevant gcc invocation (perhaps via CFLAGS or similar). Messing > with the actual included filename will only end up breaking something > else. > > Unfortunately you don''t describe what version of Xen you are using, what > patches you have applied. what commands you are running or what you are > actually trying to achieve. Based on the above and below descriptions of > the sorts of things you have tried I rather suspect that your attempts > to "fix" things have made things worse. > > Please read http://wiki.xen.org/xenwiki/AskingXenDevelQuestions and > http://wiki.xen.org/xenwiki/ReportingBugs , then revert your local > changes and report the original error which caused you to go down this > path. > > Ian. > > > The next I couldn''t fix. The header is simply missing. > > > > xen/lowlevel/xl/xl.c:210:25: fatal error: _pyxl_types.h: No such file > > orIan, While I will read through the link content, it is simple enough to provide the required info.However I am no neophyte to submitting bugs.The version is the latest xen-4.1.2 I thought the mention of ebuild would make it clear that this relates to a gentoo ebuild.It seems the test has been left as restricted because the test suite has long been broken.After unpacking the source into the sandbox, the command run was simply make test, since the target indicated in the Makefile is named test. That fix was the only one I attempted,quickly followed by the next which was a stopper. What is being achieved is the making of the version bump of xen, xen-tools and xen-pvgrub, 4.1.2. Having adjusted and repaired a number of bug fixes to xen-4.1.1, I couldn''t help but wonder why the test phase was set restricted. A test phase ,if present, in a package should be incorporated into the ebuild. I have added the ebuild, but I don''t really think it will supply anything useful.To make it simpler, there are NO patches applied. Re-setting the path via -I ofcourse we can do.Frankly I doubt the ''fix'' could have made things worse. On repeating make test, the header was found and it progressed a few dozen lines or so further. The next point is listed above, the header is simply missing, unless the normal means of the use of find within the source has failed to reveal its presence. The original error is clearly enough displayed in the initial description; In file included from xen/lowlevel/xc/xc.c:23:0: ../../tools/libxc/xc_dom.h:17:31: fatal error: xen/libelf/libelf.h: No such file or directory compilation terminated. This output is not influenced by an ebuild, purely from make test in the xen source. Thanks for viewing it thus far. Ian Delaney, proxy maintainer for xen, gentoo _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On Wed, 2011-10-26 at 05:36 +0100, Windows Live wrote:> What is being achieved is the making of the version bump of xen, > xen-tools and xen-pvgrub, 4.1.2. Having adjusted and repaired a number > of bug fixes to xen-4.1.1, I couldn''t help but wonder why the test > phase was set restricted. A test phase ,if present, in a package > should be incorporated into the ebuild.FWIW the "test" target appears to be very limited (it tests the python bindings, not all that thoroughly AFAICT).> I have added the ebuild, but I don''t really think it will supply > anything useful. To make it simpler, there are NO patches applied. > Re-setting the path via -I ofcourse we can do. Frankly I doubt the > ''fix'' could have made things worse. On repeating make test, the > header was found and it progressed a few dozen lines or so further.Once that header was installed it would be useless to anyone trying to compile against it because it now contains paths relative to the xen source tree layout. In fact I suspect your change would also break other parts of the in tree build, by virtue of them being at different depths in the hierarchy.> The original error is clearly enough displayed in the initial > description;> In file included from xen/lowlevel/xc/xc.c:23:0: > ../../tools/libxc/xc_dom.h:17:31: fatal error: xen/libelf/libelf.h: No > such file or directory > compilation terminated.In general the interesting stuff will likely be in the few lines before the actual error, in particular the gcc invocation and sometimes the make output about which directory it is building in etc. Please be wary of trimming too much when posting error messages. I just managed to reproduce the error though, it was non-obvious because I had to run "make clean" in the tools tree first. I think you need to have built the tools tree before running the test target, at least this seems logical and works for me. I suppose we should find a way to show this in the top-level Makefile dependencies. Perhaps this is sufficient: diff -r e6af32ecb448 Makefile --- a/Makefile Tue Oct 18 14:15:09 2011 +0100 +++ b/Makefile Wed Oct 26 07:23:05 2011 +0100 @@ -31,7 +31,7 @@ endif # course, many tests require a machine running Xen itself, and these are # handled elsewhere. .PHONY: test -test: +test: tools $(MAKE) -C tools/python test # build and install everything into local dist directory I get failures now because I didn''t build/test on a Xen host. That might be a show stopper for an ebuild as well? Ian. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
> Subject: Re: FW: [Xen-devel] test structure missing files > From: Ian.Campbell@citrix.com > To: johneed@hotmail.com > CC: xen-devel@lists.xensource.com > Date: Wed, 26 Oct 2011 07:25:49 +0100 >> In general the interesting stuff will likely be in the few lines before > the actual error, in particular the gcc invocation and sometimes the > make output about which directory it is building in etc. Please be wary > of trimming too much when posting error messages. >roger that> I just managed to reproduce the error though, it was non-obvious because > I had to run "make clean" in the tools tree first. I think you need to > have built the tools tree before running the test target, at least this > seems logical and works for me. >roger that. Now you mention it, indeed. I was attempting to cut it down to bare minimum in response to your mentioning things such as patches and commands which might have an impact.Took it too far. Now for a more sensible approach..> I suppose we should find a way to show this in the top-level Makefile > dependencies. Perhaps this is sufficient: > > diff -r e6af32ecb448 Makefile > --- a/Makefile Tue Oct 18 14:15:09 2011 +0100 > +++ b/Makefile Wed Oct 26 07:23:05 2011 +0100 > @@ -31,7 +31,7 @@ endif > # course, many tests require a machine running Xen itself, and these are > # handled elsewhere. > .PHONY: test > -test: > +test: tools > $(MAKE) -C tools/python test > > # build and install everything into local dist directory > > I get failures now because I didn''t build/test on a Xen host. That might > be a show stopper for an ebuild as well? > > Ian. >After kicking my system into a better shape by way of the curl library and rebuilding xen-tools with thegentoo api use flag, I have some sanity now produced from running the make test. Importantly any trace of those initial errors now don''t appear. This means the test suite is now usable and incorporatable into an ebuild. Seems the running of the test suite will be conditional on selection of some gentoo use flags. Still get errors. Ran 9 tests in 0.080s FAILED (failures=1, errors=5) ImportError: cannot import name XendConfig ValueError: Cannot find kernel "/mykernel" ValueError: Cannot find kernel "/boot/vmlinuz-xenU-smp"AssertionError: videoram not in b which makes 4, each of these repeated a couple of times. Some gentoo python devs ought be able totroubleshoot these. If you would like the test build log, just say so. From here it''s purely python. At a glance I suspect the tests that trigger "/mykernel" && "/boot/vmlinuz-xenU-smp" could be commented out or deleted IF they stem from requiring the source to build kernels, which does not occur in a xen-tools package. gentoo makes xen for the hypervisor, xen-tools and of recent xen-pvgrub which is an invocation of make install-stubdom. I shall call upon more python fluentgentoo devs to determine such states. In the unlikely case that the gentoo devs can''t sort these python misfires I shall need return and prompt for further support. Thanks Ian Delaney, gentoo xen _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On Wed, 2011-10-26 at 12:16 +0100, Windows Live wrote:> > ImportError: cannot import name XendConfig > ValueError: Cannot find kernel "/mykernel" > > ValueError: Cannot find kernel "/boot/vmlinuz-xenU-smp" > AssertionError: videoram not in b > > > which makes 4, each of these repeated a couple of times. Some gentoo > python devs ought be able to troubleshoot these. If you would like > the test build log, just say so. From here it''s purely python.It looks to me as if the test system relies on some specific files already existing on your test host (which I suspect must be running Xen).> At a glance I suspect the tests that trigger "/mykernel" && > "/boot/vmlinuz-xenU-smp" could be commented out or deleted IF they > stem from requiring the source to build kernels, which does not occur > in a xen-tools package. gentoo makes xen for the hypervisor, > xen-tools and of recent xen-pvgrub which is an invocation of make > install-stubdom. I shall call upon more python fluent gentoo devs to > determine such states.> In the unlikely case that the gentoo devs can''t sort these python > misfires I shall need return and prompt for further support.It looks like the test suite is mainly testing the python xend toolstack, which is for the most part deprecated. I''m not sure how much effort it is worth spending either fixing up the test suite or the toolstack. I''m afraid you will most likely find very little enthusiasm in general for either activity. I really wouldn''t spend any more time on this if I were you. I''m sorry I didn''t notice earlier that this test suite is pretty much obsolete and worthless. Ian.> > > Thanks > > > Ian Delaney, gentoo xen > >_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel