Writing [PATCH] netback: disable features not supported by netfront ...
ntent-Transfer-Encoding: 7bit
Subject: [PATCH] netback: disable features not supported by netfront
X-Mercurial-Node: eb896361fc70b60b9a257d0c82e19633a11b9d41
Message-Id: <eb896361fc70b60b9a25.1318837062@yakj.usersys.redhat.com>
User-Agent: Mercurial-patchbomb/1.9.1
Date: Mon, 17 Oct 2011 09:37:42 +0200
From: pbonzini@redhat.com
To: pbonzini@redhat.com
# HG changeset patch
# User Paolo Bonzini <pbonzini@redhat.com>
# Date 1318837036 -7200
# Node ID eb896361fc70b60b9a257d0c82e19633a11b9d41
# Parent 3c900d6a5f6a51ff1547f21fef30ab8b92feccc9
netback: disable features not supported by netfront
Netback works by first setting all possible features, and then
resetting some after connection, if the front-end didn''t negotiate
them.
Except that in the old 2.6.18 tree the "resetting" part was missing.
In the pvops tree, this should work correctly through the fix_features
mechanism.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
diff --git a/drivers/xen/netback/interface.c b/drivers/xen/netback/interface.c
--- a/drivers/xen/netback/interface.c
+++ b/drivers/xen/netback/interface.c
@@ -98,8 +98,9 @@ static int netbk_change_mtu(struct net_d
void netif_set_features(netif_t *netif)
{
struct net_device *dev = netif->dev;
- int features = dev->features;
+ int features;
+ features = dev->features & ~(NETIF_F_SG|NETIF_F_TSO|NETIF_F_IP_CSUM);
if (netif->can_sg)
features |= NETIF_F_SG;
if (netif->gso)
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
On Mon, Oct 17, 2011 at 09:40:49AM +0200, Paolo Bonzini wrote: Something went wrong with your patchbomb.. anyhow, lets CC Ian here since he is the maintainer.> > Writing [PATCH] netback: disable features not supported by netfront ... > ntent-Transfer-Encoding: 7bit > Subject: [PATCH] netback: disable features not supported by netfront > X-Mercurial-Node: eb896361fc70b60b9a257d0c82e19633a11b9d41 > Message-Id: <eb896361fc70b60b9a25.1318837062@yakj.usersys.redhat.com> > User-Agent: Mercurial-patchbomb/1.9.1 > Date: Mon, 17 Oct 2011 09:37:42 +0200 > From: pbonzini@redhat.com > To: pbonzini@redhat.com > > # HG changeset patch > # User Paolo Bonzini <pbonzini@redhat.com> > # Date 1318837036 -7200 > # Node ID eb896361fc70b60b9a257d0c82e19633a11b9d41 > # Parent 3c900d6a5f6a51ff1547f21fef30ab8b92feccc9 > netback: disable features not supported by netfront > > Netback works by first setting all possible features, and then > resetting some after connection, if the front-end didn''t negotiate them. > Except that in the old 2.6.18 tree the "resetting" part was missing. > In the pvops tree, this should work correctly through the fix_features > mechanism. > > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> > > diff --git a/drivers/xen/netback/interface.c b/drivers/xen/netback/interface.c > --- a/drivers/xen/netback/interface.c > +++ b/drivers/xen/netback/interface.c > @@ -98,8 +98,9 @@ static int netbk_change_mtu(struct net_d > void netif_set_features(netif_t *netif) > { > struct net_device *dev = netif->dev; > - int features = dev->features; > + int features; > > + features = dev->features & ~(NETIF_F_SG|NETIF_F_TSO|NETIF_F_IP_CSUM); > if (netif->can_sg) > features |= NETIF_F_SG; > if (netif->gso) > > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On Mon, 2011-10-17 at 18:05 +0100, Konrad Rzeszutek Wilk wrote:> On Mon, Oct 17, 2011 at 09:40:49AM +0200, Paolo Bonzini wrote: > > Something went wrong with your patchbomb.. > > anyhow, lets CC Ian here since he is the maintainer.This is a 2.6.18-xen patch. I''m not especially interested in that tree -- Jan looks after it though and picked up this patch from the resend. Ian.> > > > > Writing [PATCH] netback: disable features not supported by netfront ... > > ntent-Transfer-Encoding: 7bit > > Subject: [PATCH] netback: disable features not supported by netfront > > X-Mercurial-Node: eb896361fc70b60b9a257d0c82e19633a11b9d41 > > Message-Id: <eb896361fc70b60b9a25.1318837062@yakj.usersys.redhat.com> > > User-Agent: Mercurial-patchbomb/1.9.1 > > Date: Mon, 17 Oct 2011 09:37:42 +0200 > > From: pbonzini@redhat.com > > To: pbonzini@redhat.com > > > > # HG changeset patch > > # User Paolo Bonzini <pbonzini@redhat.com> > > # Date 1318837036 -7200 > > # Node ID eb896361fc70b60b9a257d0c82e19633a11b9d41 > > # Parent 3c900d6a5f6a51ff1547f21fef30ab8b92feccc9 > > netback: disable features not supported by netfront > > > > Netback works by first setting all possible features, and then > > resetting some after connection, if the front-end didn''t negotiate them. > > Except that in the old 2.6.18 tree the "resetting" part was missing. > > In the pvops tree, this should work correctly through the fix_features > > mechanism. > > > > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> > > > > diff --git a/drivers/xen/netback/interface.c b/drivers/xen/netback/interface.c > > --- a/drivers/xen/netback/interface.c > > +++ b/drivers/xen/netback/interface.c > > @@ -98,8 +98,9 @@ static int netbk_change_mtu(struct net_d > > void netif_set_features(netif_t *netif) > > { > > struct net_device *dev = netif->dev; > > - int features = dev->features; > > + int features; > > > > + features = dev->features & ~(NETIF_F_SG|NETIF_F_TSO|NETIF_F_IP_CSUM); > > if (netif->can_sg) > > features |= NETIF_F_SG; > > if (netif->gso) > > > > > > > > _______________________________________________ > > Xen-devel mailing list > > Xen-devel@lists.xensource.com > > http://lists.xensource.com/xen-devel_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On 10/17/2011 07:05 PM, Konrad Rzeszutek Wilk wrote:> On Mon, Oct 17, 2011 at 09:40:49AM +0200, Paolo Bonzini wrote: > > Something went wrong with your patchbomb.. > > anyhow, lets CC Ian here since he is the maintainer.Already resent, and acked by Jan. :) Paolo _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel