Juergen Gross
2011-Oct-07 04:42 UTC
[Xen-devel] [PATCH] Avoid relative XEN_ROOT specification
XEN_ROOT must be set to an absolute path to avoid out of the tree references Signed-off-by: juergen.gross@ts.fujitsu.com 1 file changed, 1 insertion(+), 1 deletion(-) tools/libfsimage/xfs/Makefile | 2 +- _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Ian Campbell
2011-Oct-07 07:51 UTC
Re: [Xen-devel] [PATCH] Avoid relative XEN_ROOT specification
On Fri, 2011-10-07 at 05:42 +0100, Juergen Gross wrote:> XEN_ROOT must be set to an absolute path to avoid out of the tree referencesHow about: # HG changeset patch # User Ian Campbell <ian.campbell@citrix.com> # Date 1317973741 -3600 # Node ID d0327c39dff8abdc224e3c19f31e11f0fbeb5c16 # Parent f17f0df2a2ede01a8c35dc4768a532a4438b1c02 tools: error out on non-absolute $(XEN_ROOT) Signed-off-by: Ian Campbell <ian.campbell@citrix.com> diff -r f17f0df2a2ed -r d0327c39dff8 tools/Rules.mk --- a/tools/Rules.mk Wed Oct 05 10:43:41 2011 +0100 +++ b/tools/Rules.mk Fri Oct 07 08:49:01 2011 +0100 @@ -3,6 +3,10 @@ # `all'' is the default target all: +ifeq ($(filter /%,$(XEN_ROOT)),) +$(error XEN_ROOT must be absolute) +endif + include $(XEN_ROOT)/Config.mk export _INSTALL := $(INSTALL) _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Juergen Gross
2011-Oct-07 07:55 UTC
Re: [Xen-devel] [PATCH] Avoid relative XEN_ROOT specification
On 10/07/2011 09:51 AM, Ian Campbell wrote:> On Fri, 2011-10-07 at 05:42 +0100, Juergen Gross wrote: >> XEN_ROOT must be set to an absolute path to avoid out of the tree references > How about: > > # HG changeset patch > # User Ian Campbell<ian.campbell@citrix.com> > # Date 1317973741 -3600 > # Node ID d0327c39dff8abdc224e3c19f31e11f0fbeb5c16 > # Parent f17f0df2a2ede01a8c35dc4768a532a4438b1c02 > tools: error out on non-absolute $(XEN_ROOT) > > Signed-off-by: Ian Campbell<ian.campbell@citrix.com>Acked-by: juergen.gross@ts.fujitsu.com> diff -r f17f0df2a2ed -r d0327c39dff8 tools/Rules.mk > --- a/tools/Rules.mk Wed Oct 05 10:43:41 2011 +0100 > +++ b/tools/Rules.mk Fri Oct 07 08:49:01 2011 +0100 > @@ -3,6 +3,10 @@ > # `all'' is the default target > all: > > +ifeq ($(filter /%,$(XEN_ROOT)),) > +$(error XEN_ROOT must be absolute) > +endif > + > include $(XEN_ROOT)/Config.mk > > export _INSTALL := $(INSTALL) > > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel > >-- Juergen Gross Principal Developer Operating Systems PDG ES&S SWE OS6 Telephone: +49 (0) 89 3222 2967 Fujitsu Technology Solutions e-mail: juergen.gross@ts.fujitsu.com Domagkstr. 28 Internet: ts.fujitsu.com D-80807 Muenchen Company details: ts.fujitsu.com/imprint.html _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2011-Oct-07 08:00 UTC
Re: [Xen-devel] [PATCH] Avoid relative XEN_ROOT specification
On 07/10/2011 08:51, "Ian Campbell" <Ian.Campbell@citrix.com> wrote:> On Fri, 2011-10-07 at 05:42 +0100, Juergen Gross wrote: >> XEN_ROOT must be set to an absolute path to avoid out of the tree references > > How about: > > # HG changeset patch > # User Ian Campbell <ian.campbell@citrix.com> > # Date 1317973741 -3600 > # Node ID d0327c39dff8abdc224e3c19f31e11f0fbeb5c16 > # Parent f17f0df2a2ede01a8c35dc4768a532a4438b1c02 > tools: error out on non-absolute $(XEN_ROOT) > > Signed-off-by: Ian Campbell <ian.campbell@citrix.com>Why not put this in root Config.mk? The restriction applies outside tools/ as well. -- Keir> diff -r f17f0df2a2ed -r d0327c39dff8 tools/Rules.mk > --- a/tools/Rules.mk Wed Oct 05 10:43:41 2011 +0100 > +++ b/tools/Rules.mk Fri Oct 07 08:49:01 2011 +0100 > @@ -3,6 +3,10 @@ > # `all'' is the default target > all: > > +ifeq ($(filter /%,$(XEN_ROOT)),) > +$(error XEN_ROOT must be absolute) > +endif > + > include $(XEN_ROOT)/Config.mk > > export _INSTALL := $(INSTALL) > > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Ian Campbell
2011-Oct-07 08:04 UTC
Re: [Xen-devel] [PATCH] Avoid relative XEN_ROOT specification
On Fri, 2011-10-07 at 09:00 +0100, Keir Fraser wrote:> On 07/10/2011 08:51, "Ian Campbell" <Ian.Campbell@citrix.com> wrote: > > > On Fri, 2011-10-07 at 05:42 +0100, Juergen Gross wrote: > >> XEN_ROOT must be set to an absolute path to avoid out of the tree references > > > > How about: > > > > # HG changeset patch > > # User Ian Campbell <ian.campbell@citrix.com> > > # Date 1317973741 -3600 > > # Node ID d0327c39dff8abdc224e3c19f31e11f0fbeb5c16 > > # Parent f17f0df2a2ede01a8c35dc4768a532a4438b1c02 > > tools: error out on non-absolute $(XEN_ROOT) > > > > Signed-off-by: Ian Campbell <ian.campbell@citrix.com> > > Why not put this in root Config.mk?Didn''t think of it...> The restriction applies outside tools/ as well.Seems to work. # HG changeset patch # User Ian Campbell <ian.campbell@citrix.com> # Date 1317974632 -3600 # Node ID 02be23c18197d1bdea51031efb8c69ce32bcd7b3 # Parent f17f0df2a2ede01a8c35dc4768a532a4438b1c02 tools: error out on non-absolute $(XEN_ROOT) Signed-off-by: Ian Campbell <ian.campbell@citrix.com> diff -r f17f0df2a2ed -r 02be23c18197 Config.mk --- a/Config.mk Wed Oct 05 10:43:41 2011 +0100 +++ b/Config.mk Fri Oct 07 09:03:52 2011 +0100 @@ -1,5 +1,9 @@ # -*- mode: Makefile; -*- +ifeq ($(filter /%,$(XEN_ROOT)),) +$(error XEN_ROOT must be absolute) +endif + -include $(XEN_ROOT)/.config _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel