Ian Campbell
2011-Oct-04 13:45 UTC
[Xen-devel] [PATCH] libxl: remove QMP warning when no pty style serial device is configured
# HG changeset patch
# User Ian Campbell <ian.campbell@citrix.com>
# Date 1317735934 -3600
# Node ID a0b8388fc4c82e345377679f4bffe7ab5d9eb55d
# Parent c344d6d30b0f3796ebff069d6ecdde481c9e6a32
libxl: remove QMP warning when no pty style serial device is configured
If the serial device is not "pty" then there is nothing to do but this
is not
an error. Removes a spurious warning if e.g.
serial="file:/tmp/serial.log" is used:
libxl: error: libxl_qmp.c:137:register_serials_chardev_callback: Failed to store
serial port information in xenstore: No such file or directory
Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
diff -r c344d6d30b0f -r a0b8388fc4c8 tools/libxl/libxl_qmp.c
--- a/tools/libxl/libxl_qmp.c Tue Oct 04 14:43:56 2011 +0100
+++ b/tools/libxl/libxl_qmp.c Tue Oct 04 14:45:34 2011 +0100
@@ -87,7 +87,7 @@ static int store_serial_port_info(libxl_
int ret = 0;
if (!(chardev && strncmp("pty:", chardev, 4) == 0)) {
- return -1;
+ return 0;
}
path = libxl__xs_get_dompath(&gc, qmp->domid);
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
Anthony PERARD
2011-Oct-06 11:52 UTC
Re: [Xen-devel] [PATCH] libxl: remove QMP warning when no pty style serial device is configured
On Tue, Oct 4, 2011 at 14:45, Ian Campbell <ian.campbell@citrix.com> wrote:> # HG changeset patch > # User Ian Campbell <ian.campbell@citrix.com> > # Date 1317735934 -3600 > # Node ID a0b8388fc4c82e345377679f4bffe7ab5d9eb55d > # Parent c344d6d30b0f3796ebff069d6ecdde481c9e6a32 > libxl: remove QMP warning when no pty style serial device is configured > > If the serial device is not "pty" then there is nothing to do but this is not > an error. Removes a spurious warning if e.g. serial="file:/tmp/serial.log" is used: > > libxl: error: libxl_qmp.c:137:register_serials_chardev_callback: Failed to store serial port information in xenstore: No such file or directory > > > Signed-off-by: Ian Campbell <ian.campbell@citrix.com> > > diff -r c344d6d30b0f -r a0b8388fc4c8 tools/libxl/libxl_qmp.c > --- a/tools/libxl/libxl_qmp.c Tue Oct 04 14:43:56 2011 +0100 > +++ b/tools/libxl/libxl_qmp.c Tue Oct 04 14:45:34 2011 +0100 > @@ -87,7 +87,7 @@ static int store_serial_port_info(libxl_ > int ret = 0; > > if (!(chardev && strncmp("pty:", chardev, 4) == 0)) { > - return -1; > + return 0; > } > > path = libxl__xs_get_dompath(&gc, qmp->domid);Acked-by: Anthony PERARD <anthony.perard@citrix.com> -- Anthony PERARD _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Ian Campbell
2011-Oct-13 09:47 UTC
[Xen-devel] [PATCH] libxl: remove QMP warning when no pty style serial device is configured
# HG changeset patch
# User Ian Campbell <ian.campbell@citrix.com>
# Date 1318499067 -3600
# Node ID 6ca28d551fd5f3d7d7849b6b95d3beda5b9cd10e
# Parent 82b2eeea91d059dd79cf7621d487a0cf7d29933e
libxl: remove QMP warning when no pty style serial device is configured
If the serial device is not "pty" then there is nothing to do but this
is not
an error. Removes a spurious warning if e.g.
serial="file:/tmp/serial.log" is used:
libxl: error: libxl_qmp.c:137:register_serials_chardev_callback: Failed to store
serial port information in xenstore: No such file or directory
Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
diff -r 82b2eeea91d0 -r 6ca28d551fd5 tools/libxl/libxl_qmp.c
--- a/tools/libxl/libxl_qmp.c Thu Oct 13 10:44:25 2011 +0100
+++ b/tools/libxl/libxl_qmp.c Thu Oct 13 10:44:27 2011 +0100
@@ -87,7 +87,7 @@ static int store_serial_port_info(libxl_
int ret = 0;
if (!(chardev && strncmp("pty:", chardev, 4) == 0)) {
- return -1;
+ return 0;
}
path = libxl__xs_get_dompath(&gc, qmp->domid);
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel