Marek Marczykowski
2011-Sep-04 21:50 UTC
[Xen-devel] [PATCH] libxl: fix double free at get_all_assigned_devices
# HG changeset patch # User Marek Marczykowski <marmarek@mimuw.edu.pl> # Date 1315172996 -7200 # Node ID 4683409fac3d4fef836ce78f01f12b31f5f9e12a # Parent 6239209bb560b4931d4d97456c82c1a5ca4bd10a libxl: fix double free at get_all_assigned_devices Do not free() list manually - it will be freed by libxl__free_all. Signed-off-by: Marek Marczykowski <marmarek@mimuw.edu.pl> diff --git a/tools/libxl/libxl_pci.c b/tools/libxl/libxl_pci.c --- a/tools/libxl/libxl_pci.c +++ b/tools/libxl/libxl_pci.c @@ -469,7 +469,6 @@ static int get_all_assigned_devices(libx } if ( 0 == *num ) { - free(pcidevs); pcidevs = NULL; }else{ *list = pcidevs; _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Marek Marczykowski
2011-Sep-04 22:05 UTC
[Xen-devel] Re: [PATCH] libxl: fix double free at get_all_assigned_devices
On 04.09.2011 23:50, Marek Marczykowski wrote:> # HG changeset patch > # User Marek Marczykowski <marmarek@mimuw.edu.pl> > # Date 1315172996 -7200 > # Node ID 4683409fac3d4fef836ce78f01f12b31f5f9e12a > # Parent 6239209bb560b4931d4d97456c82c1a5ca4bd10a > libxl: fix double free at get_all_assigned_devices > > Do not free() list manually - it will be freed by libxl__free_all. > > Signed-off-by: Marek Marczykowski <marmarek@mimuw.edu.pl>Ah, it is for xen-4.1. In unstable seems to be ok.> diff --git a/tools/libxl/libxl_pci.c b/tools/libxl/libxl_pci.c > --- a/tools/libxl/libxl_pci.c > +++ b/tools/libxl/libxl_pci.c > @@ -469,7 +469,6 @@ static int get_all_assigned_devices(libx > } > > if ( 0 == *num ) { > - free(pcidevs); > pcidevs = NULL; > }else{ > *list = pcidevs; > >-- Pozdrawiam / Best Regards, Marek Marczykowski | RLU #390519 marmarek at mimuw edu pl | xmpp:marmarek at staszic waw pl _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Ian Jackson
2011-Sep-27 16:27 UTC
[Xen-devel] Re: [PATCH] libxl: fix double free at get_all_assigned_devices [and 1 more messages]
Marek Marczykowski writes ("[Xen-devel] Re: [PATCH] libxl: fix double free at get_all_assigned_devices"):> On 04.09.2011 23:50, Marek Marczykowski wrote: > > libxl: fix double free at get_all_assigned_devices > > > > Do not free() list manually - it will be freed by libxl__free_all. > > > > Signed-off-by: Marek Marczykowski <marmarek@mimuw.edu.pl> > > Ah, it is for xen-4.1. In unstable seems to be ok.Acked and applied to 4.1, thanks. Ian. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel