Anthony PERARD
2011-Sep-27 15:02 UTC
[Xen-devel] Try to integrate the Xen PCI Passthrough code into linux: have pci_regs conflict with libpci.
Hi, I''m trying to integrate the Xen PCI Passthrough code into Qemu. But we use libpci, and it''s not friendly with pci_regs.h. So can I replace pci_regs by the libpci one? Should I avoid to include both? (by having a "hook" the libpci functions) Or do you have any other suggestions? Thanks, Regards, -- Anthony PERARD _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Michael S. Tsirkin
2011-Sep-27 15:20 UTC
[Xen-devel] Re: Try to integrate the Xen PCI Passthrough code into linux: have pci_regs conflict with libpci.
On Tue, Sep 27, 2011 at 04:02:23PM +0100, Anthony PERARD wrote:> Hi, > > I''m trying to integrate the Xen PCI Passthrough code into Qemu. But we > use libpci, and it''s not friendly with pci_regs.h. > > So can I replace pci_regs by the libpci one?I prefer sticking to pci_regs in linux.> Should I avoid to include both? (by having a "hook" the libpci functions) > Or do you have any other suggestions? > > Thanks, > Regards,Can you avoid libpci? It was very useful before sysfs, but on modern systems there isn''t much that it does. -- MST _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Anthony PERARD
2011-Sep-27 16:14 UTC
Re: [Xen-devel] Re: Try to integrate the Xen PCI Passthrough code into linux: have pci_regs conflict with libpci.
On Tue, Sep 27, 2011 at 16:20, Michael S. Tsirkin <mst@redhat.com> wrote:> On Tue, Sep 27, 2011 at 04:02:23PM +0100, Anthony PERARD wrote: >> Hi, >> >> I''m trying to integrate the Xen PCI Passthrough code into Qemu. But we >> use libpci, and it''s not friendly with pci_regs.h. >> >> So can I replace pci_regs by the libpci one? > > I prefer sticking to pci_regs in linux.Fair enough.>> Should I avoid to include both? (by having a "hook" the libpci functions) >> Or do you have any other suggestions? >> >> Thanks, >> Regards, > > Can you avoid libpci? It was very useful before sysfs, but > on modern systems there isn''t much that it does.I was thinking to keep any compatibility with a *BSD system, but since there is one function that assume the existance of the sysfs, I will just "rewrote" the needed functions and remove the usage of libpci. Thanks, -- Anthony PERARD _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel