Hi Stefano,
In parse_config_data():
init_create_info(c_info); <--- sets hvm and hap to 1, then:.
c_info->hvm = 0;
if (!xlu_cfg_get_string (config, "builder", &buf) &&
!strncmp(buf, "hvm", strlen(buf)))
c_info->hvm = 1;
if (!xlu_cfg_get_long (config, "hap", &l)) <--------
already 1
c_info->hap = l; <--- letter ''el''
no big deal, but just confusing for someone reading the code...
thanks,
Mukesh
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
On Thu, 22 Sep 2011 11:30:48 -0700 Mukesh Rathor <mukesh.rathor@oracle.com> wrote:> Hi Stefano, > > In parse_config_data(): > > init_create_info(c_info); <--- sets hvm and hap to 1, then:. > > c_info->hvm = 0; > if (!xlu_cfg_get_string (config, "builder", &buf) && > !strncmp(buf, "hvm", strlen(buf))) > c_info->hvm = 1; > > if (!xlu_cfg_get_long (config, "hap", &l)) <-------- already 1 > c_info->hap = l; <--- letter ''el'' > > > no big deal, but just confusing for someone reading the code... > > thanks, > Mukesh > > > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-develNever mind, my bad... thanks, Mukesh _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On Fri, 23 Sep 2011, Mukesh Rathor wrote:> On Thu, 22 Sep 2011 11:30:48 -0700 > Mukesh Rathor <mukesh.rathor@oracle.com> wrote: > > > Hi Stefano, > > > > In parse_config_data(): > > > > init_create_info(c_info); <--- sets hvm and hap to 1, then:. > > > > c_info->hvm = 0; > > if (!xlu_cfg_get_string (config, "builder", &buf) && > > !strncmp(buf, "hvm", strlen(buf))) > > c_info->hvm = 1; > > > > if (!xlu_cfg_get_long (config, "hap", &l)) <-------- already 1 > > c_info->hap = l; <--- letter ''el'' > > > > > > no big deal, but just confusing for someone reading the code... > > > > thanks, > > Mukesh > > Never mind, my bad... thanks, Mukesh >no problems :-) _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel