Xen devel - Sep 2011 - [PATCH] expose shared page count through xenlight

Attached is a simple patch to expose the shared page information
through libxl and xl.

Cheers,
-Adin


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Hi Adin,

On Thu, 2011-09-15 at 13:17 +0100, Adin Scannell wrote:
> Attached is a simple patch to expose the shared page information
> through libxl and xl.
I think this is generally fine but I''m a bit concerned that the
"xl
list" output is now > 80 characters long by default.

Can we only print this info in verbose mode, or only if >=1 domain has
shared pages or something? I don''t suppose just printing the total
number of shared pages across the system is as useful as printing the nr
for each domain?

Perhaps we need a get-meminfo type command to get all the various memory
stats for a domain, e.g. sharing, ballooning, paging etc?

Also, was the change from \t to explicit padding in the header
intentional? I agree it''s a bit odd to use \t in the header and spaces
in the actual info lines.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Adin Scannell writes ("[Xen-devel] [PATCH] expose shared page count through
xenlight"):
> Attached is a simple patch to expose the shared page information
> through libxl and xl.
Thanks, but this will break existing callers who try to parse the
output from "xl list".

It''s a shame that we can''t easily extend this.  In the future
we will
hopefully have a json output mode and can tell people who need to
parse xl''s output to use that.

I''m not sure what the right answer is right now, though.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Hi Ian,

On Wed, Sep 21, 2011 at 5:34 AM, Ian Campbell <Ian.Campbell@citrix.com>
wrote:
> Can we only print this info in verbose mode, or only if >=1 domain has
> shared pages or something? I don''t suppose just printing the total
> number of shared pages across the system is as useful as printing the nr
> for each domain?
Sure. I''ll move the shared pages to verbose output and resend.

I''ll also see about throwing in the total number of shared frames to
the info command (separate patch).
> Also, was the change from \t to explicit padding in the header
> intentional? I agree it''s a bit odd to use \t in the header and
spaces
> in the actual info lines.
It was intentional, as the \t''s happen to line up very badly after the
change (and they should both be either spaces or tabs anyways).

Cheers,
-Adin

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

I can address the output stuff with a future patch.

For now, I''ve cut the patch to just add the shared page info to the
libxl info (as its already exposed through libxc) and at least
developers can access it programatically.

Cheers,
-Adin

On Tue, Sep 27, 2011 at 1:06 PM, Ian Jackson <Ian.Jackson@eu.citrix.com>
wrote:
> Adin Scannell writes ("[Xen-devel] [PATCH] expose shared page count
through xenlight"):
>> Attached is a simple patch to expose the shared page information
>> through libxl and xl.
>
> Thanks, but this will break existing callers who try to parse the
> output from "xl list".
>
> It''s a shame that we can''t easily extend this.  In the
future we will
> hopefully have a json output mode and can tell people who need to
> parse xl''s output to use that.
>
> I''m not sure what the right answer is right now, though.
>
> Ian.
>

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Adin Scannell writes ("Re: [Xen-devel] [PATCH] expose shared page count
through xenlight [and 1 more messages]"):
> I can address the output stuff with a future patch.
Ok.
> For now, I''ve cut the patch to just add the shared page info to
the
> libxl info (as its already exposed through libxc) and at least
> developers can access it programatically.
Right, thanks.

Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
Committed-by: Ian Jackson <ian.jackson@eu.citrix.com>

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel