Christoph Egger
2011-Aug-26 14:45 UTC
[Xen-devel] [PATCH 01/04] p2m: use defines for page sizes rather hardcoding them
Contains pieces I missed in previous patch. Sorry. -- ---to satisfy European Law for business letters: Advanced Micro Devices GmbH Einsteinring 24, 85689 Dornach b. Muenchen Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Tim Deegan
2011-Sep-01 08:40 UTC
Re: [Xen-devel] [PATCH 01/04] p2m: use defines for page sizes rather hardcoding them
Content-Description: xen_superpage1.diff> use defines for page sizes rather hardcoding them. > > Signed-off-by: Christoph Egger <Christoph.Egger@amd.com>Applied, thanks. Tim. -- Tim Deegan <tim@xen.org> Principal Software Engineer, Xen Platform Team Citrix Systems UK Ltd. (Company #02937203, SL9 0BG) _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Tim Deegan
2011-Sep-01 08:45 UTC
Re: [Xen-devel] [PATCH 01/04] p2m: use defines for page sizes rather hardcoding them
At 09:40 +0100 on 01 Sep (1314870041), Tim Deegan wrote:> Content-Description: xen_superpage1.diff > > use defines for page sizes rather hardcoding them. > > > > Signed-off-by: Christoph Egger <Christoph.Egger@amd.com> > > Applied, thanks.The rest of this series looks OK in principle but I haven''t time to look at the detail today (and I''m wondering whether there''s a way of doing it without adding yet another argument to the p2m interfaces, but I suspect not). I''ll get to it as soon as I can. Tim. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Tim Deegan
2011-Sep-05 09:02 UTC
Re: [Xen-devel] [PATCH 01/04] p2m: use defines for page sizes rather hardcoding them
At 09:45 +0100 on 01 Sep (1314870353), Tim Deegan wrote:> At 09:40 +0100 on 01 Sep (1314870041), Tim Deegan wrote: > > Content-Description: xen_superpage1.diff > > > use defines for page sizes rather hardcoding them. > > > > > > Signed-off-by: Christoph Egger <Christoph.Egger@amd.com> > > > > Applied, thanks. > > The rest of this series looks OK in principle but I haven''t time to look > at the detail today (and I''m wondering whether there''s a way of doing it > without adding yet another argument to the p2m interfaces, but I suspect > not). I''ll get to it as soon as I can.I''ve had a look and the mechanism is good, but the patches are not quite ready. Patch #2 touches too much of the p2m interfaces with the new page-order argument -- there are functions in it that now have a new argument that''s _never_ called except with NULL. Patches #4 and #5 have a lot of churn in and around spage_* for what''s basically a mask operation on an MFN. I don''t think any of it is necessary. Also, please don''t send patches that contain things like: +/* XXX: defines should be moved to a proper header */ It might make me think you didn''t re-read them before posting. :) I think they really just need trimmed back a bit before they go in. I''ll have some time on Wednesday, so I might just do that then. Cheers, Tim. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Tim Deegan
2011-Sep-07 13:44 UTC
Re: [Xen-devel] [PATCH 01/04] p2m: use defines for page sizes rather hardcoding them
At 10:02 +0100 on 05 Sep (1315216944), Tim Deegan wrote:> I think they really just need trimmed back a bit before they go in. > I''ll have some time on Wednesday, so I might just do that then.OK, I''ve cut them back to just the bits that are needed by the new callers. I ended up shuffling the code around as well, so could you please test that the attached series works for you? Cheers, Tim. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Christoph Egger
2011-Sep-08 14:05 UTC
Re: [Xen-devel] [PATCH 01/04] p2m: use defines for page sizes rather hardcoding them
On 09/07/11 15:44, Tim Deegan wrote:> At 10:02 +0100 on 05 Sep (1315216944), Tim Deegan wrote: >> I think they really just need trimmed back a bit before they go in. >> I''ll have some time on Wednesday, so I might just do that then. > > OK, I''ve cut them back to just the bits that are needed by the new > callers. I ended up shuffling the code around as well, so could you > please test that the attached series works for you?Yes, the patch series works very well. Please apply them. Acked-by: Christoph Egger <Christoph.Egger@amd.com> -- ---to satisfy European Law for business letters: Advanced Micro Devices GmbH Einsteinring 24, 85689 Dornach b. Muenchen Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel