Zhigang Wang
2011-Jul-06 22:39 UTC
[Xen-devel] [PATCH] tools/hotplug/Linux/block: fix shared loop device detection
# HG changeset patch
# User Zhigang Wang <zhigang.x.wang@oracle.com>
# Date 1309991886 14400
# Node ID 52449dfa903562aa563fef0d229e2dc61a768f4c
# Parent 2f63562df1c4230492a81793dce3672f93c93d9a
tools/hotplug/Linux/block: fix shared loop device detection
We need to prefix 0 or more ''0'' to ''$dev'':
# stat -c ''%D'' "/system.img"
13
# losetup -a
/dev/loop0: [0013]:12062248 (/system.img)
Signed-off-by: Zhigang Wang <zhigang.x.wang@oracle.com>
diff -r 2f63562df1c4 -r 52449dfa9035 tools/hotplug/Linux/block
--- a/tools/hotplug/Linux/block Mon Jun 27 17:37:12 2011 +0100
+++ b/tools/hotplug/Linux/block Wed Jul 06 18:38:06 2011 -0400
@@ -280,7 +280,7 @@ mount it read-write in a guest domain."
fi
shared_list=$(losetup -a |
- sed -n -e
"s@^\([^:]\+\)\(:[[:blank:]]\[${dev}\]:${inode}[[:blank:]](.*)\)@\1@p"
)
+ sed -n -e
"s@^\([^:]\+\)\(:[[:blank:]]\[0*${dev}\]:${inode}[[:blank:]](.*)\)@\1@p"
)
for dev in $shared_list
do
if [ -n "$dev" ]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
Olaf Hering
2011-Jul-07 08:19 UTC
Re: [Xen-devel] [PATCH] tools/hotplug/Linux/block: fix shared loop device detection
On Wed, Jul 06, Zhigang Wang wrote:> # HG changeset patch > # User Zhigang Wang <zhigang.x.wang@oracle.com> > # Date 1309991886 14400 > # Node ID 52449dfa903562aa563fef0d229e2dc61a768f4c > # Parent 2f63562df1c4230492a81793dce3672f93c93d9a > tools/hotplug/Linux/block: fix shared loop device detection > > We need to prefix 0 or more ''0'' to ''$dev'': > > # stat -c ''%D'' "/system.img" > 13 > # losetup -a > /dev/loop0: [0013]:12062248 (/system.img) > > Signed-off-by: Zhigang Wang <zhigang.x.wang@oracle.com>The leading zero was in the 4.0 code. Thanks for spotting. Acked-by: Olaf Hering <olaf@aepfle.de> Olaf _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Ian Jackson
2011-Jul-08 17:12 UTC
Re: [Xen-devel] [PATCH] tools/hotplug/Linux/block: fix shared loop device detection
Zhigang Wang writes ("[Xen-devel] [PATCH] tools/hotplug/Linux/block: fix
shared loop device detection"):> tools/hotplug/Linux/block: fix shared loop device detection
>
> We need to prefix 0 or more ''0'' to
''$dev'':
Thanks, applied.
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel