Philipp Hahn
2011-Jun-21 13:29 UTC
[Xen-devel] [PATCH] no-fork option for tapdisk2 debugging
Hello,
For debugging tapdisk2 it would be nice if forking into the background could
be disabled by passing some command line argument. The attached patch adds
such an option (-n).
The second patch re-indents four un-changed lines.
It would be nice if this could be included into the source core repository.
Sincerely
Philipp Hahn
--
Philipp Hahn Open Source Software Engineer hahn@univention.de
Univention GmbH Linux for Your Business fon: +49 421 22 232- 0
Mary-Somerville-Str.1 D-28359 Bremen fax: +49 421 22 232-99
http://www.univention.de/
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
Ian Jackson
2011-Jun-21 14:29 UTC
Re: [Xen-devel] [PATCH] no-fork option for tapdisk2 debugging
Philipp Hahn writes ("[Xen-devel] [PATCH] no-fork option for tapdisk2
debugging"):> For debugging tapdisk2 it would be nice if forking into the background
could
> be disabled by passing some command line argument. The attached patch adds
> such an option (-n).
This seems reasonable.
> The second patch re-indents four un-changed lines.
That should be folded into the first patch, which otherwise leaves the
indentation wrong.
> It would be nice if this could be included into the source core repository.
Also, you to add a Signed-off-by line to your patch to signify its
copyright status (see below).
Thanks,
Ian.
>From Documentation/SubmittingPatches in the Linux kernel tree:
Developer''s Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
Philipp Hahn
2011-Jun-21 15:12 UTC
Re: [Xen-devel] [PATCH v2] no-fork option for tapdisk2 debugging
Hello Ian, Am Dienstag 21 Juni 2011 16:29:20 schrieb Ian Jackson:> That should be folded into the first patch, which otherwise leaves the > indentation wrong.Done. I submitted it as an extra patch only for simplifying review of the additional implementation.> Also, you to add a Signed-off-by line to your patch to signify its > copyright status (see below).The original patch already contained the Signed-off-line, since I knew you (or somebody else) would be asking for it ;-) If more is needed, please ask again. Sincerely Philipp Hahn -- Philipp Hahn Open Source Software Engineer hahn@univention.de Univention GmbH Linux for Your Business fon: +49 421 22 232- 0 Mary-Somerville-Str.1 D-28359 Bremen fax: +49 421 22 232-99 http://www.univention.de/ _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Ian Jackson
2011-Jun-21 15:14 UTC
Re: [Xen-devel] [PATCH v2] no-fork option for tapdisk2 debugging
Philipp Hahn writes ("Re: [Xen-devel] [PATCH v2] no-fork option for
tapdisk2 debugging"):> Am Dienstag 21 Juni 2011 16:29:20 schrieb Ian Jackson:
> > That should be folded into the first patch, which otherwise leaves the
> > indentation wrong.
>
> Done. I submitted it as an extra patch only for simplifying review of the
> additional implementation.
Thanks, but we have tools which can suppress whitespace changes when
showing us diffs :-).
> > Also, you to add a Signed-off-by line to your patch to signify its
> > copyright status (see below).
>
> The original patch already contained the Signed-off-line, since I
> knew you (or somebody else) would be asking for it ;-) If more is
> needed, please ask again.
Sorry, I must have missed that.
But I''m afraid your patch doesn''t apply cleanly to
xen-unstable tip:
patching file tools/blktap2/drivers/tapdisk2.c
Hunk #1 FAILED at 402.
Hunk #2 FAILED at 411.
Hunk #3 succeeded at 72 (offset -359 lines).
Hunk #4 FAILED at 83.
3 out of 4 hunks FAILED -- saving rejects to file
tools/blktap2/drivers/tapdisk2.c.rej
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
Philipp Hahn
2011-Jun-21 15:40 UTC
Re: [Xen-devel] [PATCH v2] no-fork option for tapdisk2 debugging
Hello Ian, On Tuesday 21 June 2011 17:14:28 Ian Jackson wrote:> But I''m afraid your patch doesn''t apply cleanly to xen-unstable tip:Seems like someone other also missed that option and added it already. So me patch is mostly obsolete, but perhaps a little bit of documentation would be okay. Sincerely Philipp Hahn -- Philipp Hahn Open Source Software Engineer hahn@univention.de Univention GmbH Linux for Your Business fon: +49 421 22 232- 0 Mary-Somerville-Str.1 D-28359 Bremen fax: +49 421 22 232-99 http://www.univention.de/ _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Ian Jackson
2011-Jun-21 15:53 UTC
Re: [Xen-devel] [PATCH v2] no-fork option for tapdisk2 debugging
Philipp Hahn writes ("Re: [Xen-devel] [PATCH v2] no-fork option for
tapdisk2 debugging"):> On Tuesday 21 June 2011 17:14:28 Ian Jackson wrote:
> > But I''m afraid your patch doesn''t apply cleanly to
xen-unstable tip:
>
> Seems like someone other also missed that option and added it already. So
me
> patch is mostly obsolete, but perhaps a little bit of documentation would
be
> okay.
Right, thanks, I have applied your patch. (I had to do this by hand
because something in the Citrix email system mangled your tabs. Not
your fault.)
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel