Ian Campbell
2011-Jun-14 14:22 UTC
[Xen-devel] [PATCH] Correct fseg allocation for SMBIOS tables.
Anthony Perard noticed that grub was unhappy because it sees no low memory and that his e820 table was missing the first entry. He then pointed out this rather glaring error in the allocation of space for the SMBIOS tables. I''ve no idea why I didn''t see this failure. Signed-off-by: Ian Campbell <ian.campbell@citrix.com> Tested-by: Anthony Perard <anthony.perard@citrix.com> --- src/biostables.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/biostables.c b/src/biostables.c index 761b260..d8b5067 100644 --- a/src/biostables.c +++ b/src/biostables.c @@ -95,7 +95,7 @@ copy_smbios(void *pos) return; if (checksum(pos+0x10, p->length-0x10) != 0) return; - struct smbios_entry_point *newpos = malloc_fseg(sizeof(p->length)); + struct smbios_entry_point *newpos = malloc_fseg(p->length); if (!newpos) { warn_noalloc(); return; -- 1.7.2.5 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Kevin O''Connor
2011-Jun-14 23:34 UTC
[Xen-devel] Re: [SeaBIOS] [PATCH] Correct fseg allocation for SMBIOS tables.
On Tue, Jun 14, 2011 at 03:22:09PM +0100, Ian Campbell wrote:> Anthony Perard noticed that grub was unhappy because it sees no low memory and > that his e820 table was missing the first entry. He then pointed out this > rather glaring error in the allocation of space for the SMBIOS tables. > > I''ve no idea why I didn''t see this failure.Thanks - I committed this. -Kevin _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel