I have try to do patch for add of default keymap in xl.conf, i have do probably right initialization and take value from conf if not commented but i not understand how to implement it so it will be used if the value is not set in the domU conf, I post the partial patch below -- View this message in context: http://xen.1045712.n5.nabble.com/PATCH-tools-add-default-keymap-in-xl-conf-tp4421943p4421943.html Sent from the Xen - Dev mailing list archive at Nabble.com. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
# HG changeset patch
# User Fabio Fantoni
# Date 1306240203 -7200
# Branch fabio
# Node ID 3bfc3d4e4792831a80821143a06d8f4b25a9fb43
# Parent 79341a653633ffde213dfa7d071b677d419707bb
tools: add default keymap in xl.conf
Partial patch of add default keymap in xl.conf, effective use of variable
default_keymap if keymap is not set in domU configuration file is missed
Signed-off-by: Fabio Fantoni <fabio.fantoni@heliman.it>
diff -r 79341a653633 -r 3bfc3d4e4792 tools/examples/xl.conf
--- a/tools/examples/xl.conf Tue May 24 11:48:58 2011 +0200
+++ b/tools/examples/xl.conf Tue May 24 14:30:03 2011 +0200
@@ -9,3 +9,7 @@
# default vif script
#vifscript="vif-bridge"
+
+# The default keymap to use for the VM''s virtual keyboard
+# when not specififed in VM''s configuration
+#keymap="en-us"
diff -r 79341a653633 -r 3bfc3d4e4792 tools/libxl/xl.c
--- a/tools/libxl/xl.c Tue May 24 11:48:58 2011 +0200
+++ b/tools/libxl/xl.c Tue May 24 14:30:03 2011 +0200
@@ -37,6 +37,7 @@
int autoballoon = 1;
char *lockfile;
char *default_vifscript = NULL;
+char *default_keymap = NULL;
static xentoollog_level minmsglevel = XTL_PROGRESS;
@@ -77,6 +78,9 @@
if (!xlu_cfg_get_string (config, "vifscript", &buf))
default_vifscript = strdup(buf);
+ if (!xlu_cfg_get_string (config, "keymap", &buf))
+ default_keymap = strdup(buf);
+
xlu_cfg_destroy(config);
}
diff -r 79341a653633 -r 3bfc3d4e4792 tools/libxl/xl.h
--- a/tools/libxl/xl.h Tue May 24 11:48:58 2011 +0200
+++ b/tools/libxl/xl.h Tue May 24 14:30:03 2011 +0200
@@ -102,5 +102,6 @@
extern int autoballoon;
extern char *lockfile;
extern char *default_vifscript;
+extern char *default_keymap;
#endif /* XL_H */
--
View this message in context:
http://xen.1045712.n5.nabble.com/PATCH-tools-add-default-keymap-in-xl-conf-tp4421943p4421951.html
Sent from the Xen - Dev mailing list archive at Nabble.com.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
Ian Jackson
2011-May-24 16:50 UTC
[Xen-devel] Re: [PATCH] tools: add default keymap in xl.conf
Fantu writes ("[Xen-devel] Re: [PATCH] tools: add default keymap in
xl.conf"):> tools: add default keymap in xl.conf
>
> Partial patch of add default keymap in xl.conf, effective use of variable
> default_keymap if keymap is not set in domU configuration file is missed
Thanks for the suggestion. I think it would be better to have a
general mechanism for setting defaults for domains, rather than
introducing this piecemeal.
Perhaps xl should read /etc/xen/xl-domain-defaults.conf when creating
new domains (and copy the information into the userdata with the main
configuration) ?
Thanks,
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
File with default values for all domUs applied if not present in single domU conf would be perfect. Could be implemented in xen 4.2 please? -- View this message in context: http://xen.1045712.n5.nabble.com/PATCH-tools-add-default-keymap-in-xl-conf-tp4421943p4424823.html Sent from the Xen - Dev mailing list archive at Nabble.com. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Ian Jackson
2011-May-26 14:35 UTC
[Xen-devel] Re: [PATCH] tools: add default keymap in xl.conf
Fantu writes ("[Xen-devel] Re: [PATCH] tools: add default keymap in
xl.conf"):> File with default values for all domUs applied if not present in single
domU
> conf would be perfect.
> Could be implemented in xen 4.2 please?
I was offering you the opportunity to implement it :-).
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
I try to do with modify parse_config_data function in xl_cmdimpl.c but now my knowledge of c + + source and xen is too low and I failed :( I start do default config, i will post a new topic about -- View this message in context: http://xen.1045712.n5.nabble.com/PATCH-tools-add-default-keymap-in-xl-conf-tp4421943p4458233.html Sent from the Xen - Dev mailing list archive at Nabble.com. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel