Include headers that are actually needed, drop everything else. Do not use BUG() in public headers. Signed-off-by: Christoph Egger <Christoph.Egger@amd.com> -- ---to satisfy European Law for business letters: Advanced Micro Devices GmbH Einsteinring 24, 85689 Dornach b. Muenchen Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On 20/05/2011 13:58, "Christoph Egger" <Christoph.Egger@amd.com> wrote:> > Include headers that are actually needed, drop everything else.> Do not use BUG() in public headers.Why would that be a problem in an ifdef-__XEN__ region? -- Keir> Signed-off-by: Christoph Egger <Christoph.Egger@amd.com>_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On 05/20/11 16:27, Keir Fraser wrote:> On 20/05/2011 13:58, "Christoph Egger"<Christoph.Egger@amd.com> wrote: > >> >> Include headers that are actually needed, drop everything else. > >> Do not use BUG() in public headers. > > Why would that be a problem in an ifdef-__XEN__ region? > > -- KeirWhy is an ifdef-__XEN__ region needed at all in a public header ? Christoph>> Signed-off-by: Christoph Egger<Christoph.Egger@amd.com> > > >-- ---to satisfy European Law for business letters: Advanced Micro Devices GmbH Einsteinring 24, 85689 Dornach b. Muenchen Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel