George Dunlap
2011-May-16 11:05 UTC
[Xen-devel] [PATCH] tools: Fix build failure with gcc 4.4.3-4ubuntu5
c/s 23253:a3db6b91f32d causes build failure with gcc 4.4.3-4ubuntu5,
as the compiler can''t figure out that the value returned is always
a string literal.
Signed-off-by: George Dunlap <george.dunlap@eu.citrix.com>
diff -r f9bb0bbea7c2 -r 19736875b3ab tools/libxl/libxl_dm.c
--- a/tools/libxl/libxl_dm.c Thu May 12 16:42:54 2011 +0100
+++ b/tools/libxl/libxl_dm.c Mon May 16 12:04:47 2011 +0100
@@ -773,7 +773,7 @@ int libxl__create_device_model(libxl__gc
path = libxl__sprintf(gc, "/local/domain/%d/hvmloader",
info->domid);
xs_mkdir(ctx->xsh, XBT_NULL, path);
libxl__xs_write(gc, XBT_NULL, libxl__sprintf(gc, "%s/bios",
path),
- libxl__domain_bios(gc, info));
+ "%s", libxl__domain_bios(gc, info));
path = libxl__sprintf(gc, "/local/domain/0/device-model/%d",
info->domid);
xs_mkdir(ctx->xsh, XBT_NULL, path);
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
Ian Campbell
2011-May-16 12:02 UTC
Re: [Xen-devel] [PATCH] tools: Fix build failure with gcc 4.4.3-4ubuntu5
On Mon, 2011-05-16 at 12:05 +0100, George Dunlap wrote:> c/s 23253:a3db6b91f32d causes build failure with gcc 4.4.3-4ubuntu5, > as the compiler can''t figure out that the value returned is always > a string literal. > > Signed-off-by: George Dunlap <george.dunlap@eu.citrix.com>Acked-by: Ian Campbell <ian.campbell@citrix.com>> diff -r f9bb0bbea7c2 -r 19736875b3ab tools/libxl/libxl_dm.c > --- a/tools/libxl/libxl_dm.c Thu May 12 16:42:54 2011 +0100 > +++ b/tools/libxl/libxl_dm.c Mon May 16 12:04:47 2011 +0100 > @@ -773,7 +773,7 @@ int libxl__create_device_model(libxl__gc > path = libxl__sprintf(gc, "/local/domain/%d/hvmloader", info->domid); > xs_mkdir(ctx->xsh, XBT_NULL, path); > libxl__xs_write(gc, XBT_NULL, libxl__sprintf(gc, "%s/bios", path), > - libxl__domain_bios(gc, info)); > + "%s", libxl__domain_bios(gc, info)); > > path = libxl__sprintf(gc, "/local/domain/0/device-model/%d", info->domid); > xs_mkdir(ctx->xsh, XBT_NULL, path); > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Ian Jackson
2011-May-20 17:20 UTC
Re: [Xen-devel] [PATCH] tools: Fix build failure with gcc 4.4.3-4ubuntu5
George Dunlap writes ("[Xen-devel] [PATCH] tools: Fix build failure with
gcc 4.4.3-4ubuntu5"):> c/s 23253:a3db6b91f32d causes build failure with gcc 4.4.3-4ubuntu5,
> as the compiler can''t figure out that the value returned is always
> a string literal.
>
> Signed-off-by: George Dunlap <george.dunlap@eu.citrix.com>
Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
Committed-by: Ian Jackson <ian.jackson@eu.citrix.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel