Hi, attached patch lets l2 guest actually run with shadow-on-hap. Signed-off-by: Christoph Egger <Christoph.Egger@amd.com> -- ---to satisfy European Law for business letters: Advanced Micro Devices GmbH Einsteinring 24, 85689 Dornach b. Muenchen Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Christoph Egger
2011-May-11 13:26 UTC
Re: [Xen-devel] [PATCH] nestedsvm: fix shadow-on-hap
On 05/11/11 14:53, Christoph Egger wrote:> > Hi, > > attached patch lets l2 guest actually run with shadow-on-hap. > > Signed-off-by: Christoph Egger<Christoph.Egger@amd.com> > >New version. Old version missed some hunks to compile. Sorry about this. Signed-off-by: Christoph Egger <Christoph.Egger@amd.com> -- ---to satisfy European Law for business letters: Advanced Micro Devices GmbH Einsteinring 24, 85689 Dornach b. Muenchen Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
At 14:26 +0100 on 11 May (1305124015), Christoph Egger wrote:> diff -r 0c60c61ff836 xen/arch/x86/hvm/svm/entry.S > --- a/xen/arch/x86/hvm/svm/entry.S Tue May 10 11:42:02 2011 +0200 > +++ b/xen/arch/x86/hvm/svm/entry.S Wed May 11 15:24:00 2011 +0200 > @@ -65,12 +65,16 @@ ENTRY(svm_asm_do_resume) > testl $~0,(r(dx),r(ax),1) > jnz .Lsvm_process_softirqs > > + testb $0, VCPU_nsvm_hap_enabled(r(bx)) > + jz .Lsvm_asid_handle > + > mov VCPU_nhvm_p2m(r(bx)),r(ax) > test r(ax),r(ax) > sete %al > andb VCPU_nhvm_guestmode(r(bx)),%al > jnz .Lsvm_nsvm_no_p2m > > +.Lsvm_asid_handle:It would be neater to AND nsvm_hap_enabled into the no-p2m calculation rather than have another jump, but unless you feel like fixing that, this and your other 3 recent nested-SVM patches are Acked-by: Tim Deegan <Tim.Deegan@citrix.com> Tim. -- Tim Deegan <Tim.Deegan@citrix.com> Principal Software Engineer, Xen Platform Team Citrix Systems UK Ltd. (Company #02937203, SL9 0BG) _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel