Anthony PERARD
2011-May-05 13:31 UTC
[Xen-devel] bug, bad page free with hvm guest after commits about AMD IOMMU
Hi, With the last xen-unstable, when I try to run a HVM guest, the vgabios did not display anything on the screen (it is only white), and Xen print this: (XEN) mm.c:2137:d0 Error pfn 0: rd=ffff83023e8a0000, od=ffff83022f5f3000, caf=8000000000000001, taf=7400000000000001 (XEN) memory.c:196:d0 Bad page free for domain 24 (XEN) mm.c:2137:d0 Error pfn 0: rd=ffff83023e8a0000, od=ffff83022f5f3000, caf=8000000000000001, taf=7400000000000001 (XEN) memory.c:196:d0 Bad page free for domain 24 ... I found the issue come from one of this commits: 5cd3681 x86/mm: Add a generic interface for vtd and amd iommu p2m sharing. Also introduce a new parameter (iommu=sharept) to enable this 6b3faa6 x86/mm: Implement p2m table sharing for AMD IOMMU. 8d771f6 x86/mm: add AMD IOMMU control bits to p2m entries. 2452ae6 x86/mm: Move p2m type into bits of the PTE that the IOMMU doesn''t use. This happened on two machines: Intel(R) Core(TM) i7 CPU M 620 @ 2.67GHz Intel(R) Xeon(R) CPU X3450 @ 2.67GHz -- Anthony PERARD _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Tim Deegan
2011-May-05 13:40 UTC
Re: [Xen-devel] bug, bad page free with hvm guest after commits about AMD IOMMU
At 14:31 +0100 on 05 May (1304605909), Anthony PERARD wrote:> Hi, > > With the last xen-unstable, when I try to run a HVM guest, the vgabios > did not display anything on the screen (it is only white), and Xen > print this:Interesting. I get those messages but the BIOS continues OK so I hadn''t been in a hurry to investigate. I''ll take a look. Tim.> (XEN) mm.c:2137:d0 Error pfn 0: rd=ffff83023e8a0000, > od=ffff83022f5f3000, caf=8000000000000001, taf=7400000000000001 > (XEN) memory.c:196:d0 Bad page free for domain 24 > (XEN) mm.c:2137:d0 Error pfn 0: rd=ffff83023e8a0000, > od=ffff83022f5f3000, caf=8000000000000001, taf=7400000000000001 > (XEN) memory.c:196:d0 Bad page free for domain 24 > ... > > I found the issue come from one of this commits: > 5cd3681 x86/mm: Add a generic interface for vtd and amd iommu p2m > sharing. Also introduce a new parameter (iommu=sharept) to enable this > 6b3faa6 x86/mm: Implement p2m table sharing for AMD IOMMU. > 8d771f6 x86/mm: add AMD IOMMU control bits to p2m entries. > 2452ae6 x86/mm: Move p2m type into bits of the PTE that the IOMMU doesn''t use. > > This happened on two machines: > Intel(R) Core(TM) i7 CPU M 620 @ 2.67GHz > Intel(R) Xeon(R) CPU X3450 @ 2.67GHz > > -- > Anthony PERARD > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel-- Tim Deegan <Tim.Deegan@citrix.com> Principal Software Engineer, Xen Platform Team Citrix Systems UK Ltd. (Company #02937203, SL9 0BG) _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Anthony PERARD
2011-May-05 13:56 UTC
Re: [Xen-devel] bug, bad page free with hvm guest after commits about AMD IOMMU
On Thu, May 5, 2011 at 14:40, Tim Deegan <Tim.Deegan@citrix.com> wrote:> At 14:31 +0100 on 05 May (1304605909), Anthony PERARD wrote: >> Hi, >> >> With the last xen-unstable, when I try to run a HVM guest, the vgabios >> did not display anything on the screen (it is only white), and Xen >> print this: > > Interesting. I get those messages but the BIOS continues OK so I hadn''t > been in a hurry to investigate. I''ll take a look.Yes, the guest works fine after that, but on linux, there is no vga console, but a X server work fine. -- Anthony PERARD _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Tim Deegan
2011-May-05 14:44 UTC
Re: [Xen-devel] bug, bad page free with hvm guest after commits about AMD IOMMU
CC''ing John and George, who reported similar-sounding failures. At 14:56 +0100 on 05 May (1304607375), Anthony Perard wrote:> On Thu, May 5, 2011 at 14:40, Tim Deegan <Tim.Deegan@citrix.com> wrote: > > At 14:31 +0100 on 05 May (1304605909), Anthony PERARD wrote: > >> Hi, > >> > >> With the last xen-unstable, when I try to run a HVM guest, the vgabios > >> did not display anything on the screen (it is only white), and Xen > >> print this: > > > > Interesting. I get those messages but the BIOS continues OK so I hadn''t > > been in a hurry to investigate. I''ll take a look. > > Yes, the guest works fine after that, but on linux, there is no vga > console, but a X server work fine.I suspect it''s the use of type 0 to mean RAM: it means that an entry of all zeroes no longer gives type mmio so something''s not going to qemu correctly. Does the attached patch fix it for you? I''m still seeing intermittent failures with it but they may be unrelated. Tim. -- Tim Deegan <Tim.Deegan@citrix.com> Principal Software Engineer, Xen Platform Team Citrix Systems UK Ltd. (Company #02937203, SL9 0BG) _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Wei Wang2
2011-May-05 15:25 UTC
Re: [Xen-devel] bug, bad page free with hvm guest after commits about AMD IOMMU
On Thursday 05 May 2011 16:44:36 Tim Deegan wrote:> CC''ing John and George, who reported similar-sounding failures. > > At 14:56 +0100 on 05 May (1304607375), Anthony Perard wrote: > > On Thu, May 5, 2011 at 14:40, Tim Deegan <Tim.Deegan@citrix.com> wrote: > > > At 14:31 +0100 on 05 May (1304605909), Anthony PERARD wrote: > > >> Hi, > > >> > > >> With the last xen-unstable, when I try to run a HVM guest, the vgabios > > >> did not display anything on the screen (it is only white), and Xen > > >> print this: > > > > > > Interesting. I get those messages but the BIOS continues OK so I > > > hadn''t been in a hurry to investigate. I''ll take a look. > > > > Yes, the guest works fine after that, but on linux, there is no vga > > console, but a X server work fine. > > I suspect it''s the use of type 0 to mean RAM: it means that an entry of > all zeroes no longer gives type mmio so something''s not going to qemu > correctly. > > Does the attached patch fix it for you? I''m still seeing intermittent > failures with it but they may be unrelated.Tim, This patch works well with AMD. Thanks! Wei> Tim._______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Anthony PERARD
2011-May-05 15:31 UTC
Re: [Xen-devel] bug, bad page free with hvm guest after commits about AMD IOMMU
On Thu, 5 May 2011, Tim Deegan wrote:> CC''ing John and George, who reported similar-sounding failures. > > At 14:56 +0100 on 05 May (1304607375), Anthony Perard wrote: > > On Thu, May 5, 2011 at 14:40, Tim Deegan <Tim.Deegan@citrix.com> wrote: > > > At 14:31 +0100 on 05 May (1304605909), Anthony PERARD wrote: > > >> Hi, > > >> > > >> With the last xen-unstable, when I try to run a HVM guest, the vgabios > > >> did not display anything on the screen (it is only white), and Xen > > >> print this: > > > > > > Interesting. I get those messages but the BIOS continues OK so I hadn''t > > > been in a hurry to investigate. I''ll take a look. > > > > Yes, the guest works fine after that, but on linux, there is no vga > > console, but a X server work fine. > > I suspect it''s the use of type 0 to mean RAM: it means that an entry of > all zeroes no longer gives type mmio so something''s not going to qemu > correctly. > > Does the attached patch fix it for you? I''m still seeing intermittent > failures with it but they may be unrelated.Yep, the patch fix this issue. Thanks, -- Anthony PERARD _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Tim Deegan
2011-May-05 16:42 UTC
Re: [Xen-devel] bug, bad page free with hvm guest after commits about AMD IOMMU
At 16:31 +0100 on 05 May (1304613096), Anthony Perard wrote:> On Thu, 5 May 2011, Tim Deegan wrote: > > > CC''ing John and George, who reported similar-sounding failures. > > > > At 14:56 +0100 on 05 May (1304607375), Anthony Perard wrote: > > > On Thu, May 5, 2011 at 14:40, Tim Deegan <Tim.Deegan@citrix.com> wrote: > > > > At 14:31 +0100 on 05 May (1304605909), Anthony PERARD wrote: > > > >> Hi, > > > >> > > > >> With the last xen-unstable, when I try to run a HVM guest, the vgabios > > > >> did not display anything on the screen (it is only white), and Xen > > > >> print this: > > > > > > > > Interesting. I get those messages but the BIOS continues OK so I hadn''t > > > > been in a hurry to investigate. I''ll take a look. > > > > > > Yes, the guest works fine after that, but on linux, there is no vga > > > console, but a X server work fine. > > > > I suspect it''s the use of type 0 to mean RAM: it means that an entry of > > all zeroes no longer gives type mmio so something''s not going to qemu > > correctly. > > > > Does the attached patch fix it for you? I''m still seeing intermittent > > failures with it but they may be unrelated. > > Yep, the patch fix this issue.Great, thanks for the triage and testing. I''ve applied it. Tim. -- Tim Deegan <Tim.Deegan@citrix.com> Principal Software Engineer, Xen Platform Team Citrix Systems UK Ltd. (Company #02937203, SL9 0BG) _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel