Daniel Kiper
2011-May-02 21:22 UTC
[Xen-devel] [PATCH 4/4] mm: Do not define PFN_SECTION_SHIFT if !CONFIG_SPARSEMEM
Do not define PFN_SECTION_SHIFT if !CONFIG_SPARSEMEM. Signed-off-by: Daniel Kiper <dkiper@net-space.pl> --- include/linux/mm.h | 4 ---- 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/include/linux/mm.h b/include/linux/mm.h index 23465e1..d1f8cb4 100644 --- a/include/linux/mm.h +++ b/include/linux/mm.h @@ -603,10 +603,6 @@ static inline pte_t maybe_mkwrite(pte_t pte, struct vm_area_struct *vma) #define NODE_NOT_IN_PAGE_FLAGS #endif -#ifndef PFN_SECTION_SHIFT -#define PFN_SECTION_SHIFT 0 -#endif - /* * Define the bit shifts to access each section. For non-existent * sections we define the shift as 0; that plus a 0 mask ensures -- 1.5.6.5 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Dave Hansen
2011-May-03 16:10 UTC
[Xen-devel] Re: [PATCH 4/4] mm: Do not define PFN_SECTION_SHIFT if !CONFIG_SPARSEMEM
On Mon, 2011-05-02 at 23:22 +0200, Daniel Kiper wrote:> Do not define PFN_SECTION_SHIFT if !CONFIG_SPARSEMEM. > > Signed-off-by: Daniel Kiper <dkiper@net-space.pl>I''d like if this was a bit easier to verify that it didn''t break anything. Basically, we should probably limit direct use of PFN_SECTION_SHIFT to inside #ifdefs in headers. But, if something is truly using this today, it''s probably broken. It''s easy enough to work around if someone hits it, I guess. Acked-by: Dave Hansen <dave@linux.vnet.ibm.com> -- Dave _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel