I have been working on xen and dom0 kernel packages for RHEL6 and they are now at the stage where they are suitable for wider testing. There are xen 4.1 RPMs at http://xenbits.xen.org/people/mayoung/EL6.xen/ which are simply the Fedora 15 package recompiled for RHEL6. The dom0 kernel packages are at http://xenbits.xen.org/people/mayoung/testing/ and are basically the 2.6.32-71.29.1.el6 kernel with the addition of xen specific patches from Jeremy''s xen/stable-2.6.32.x branch at the 2.6.32.39 merge, and a few code and configuration changes to get it to build. It isn''t ABI compatible with true RHEL6 kernels because of the changes. It should set up grub correctly for a dom0 boot if the hypervisor is present (though I suggest you check the grub.conf file until it is better tested). Let me know if you see any problems. Michael Young _______________________________________________ Xen-users mailing list Xen-users@lists.xensource.com http://lists.xensource.com/xen-users
Pasi Kärkkäinen
2011-May-23 19:16 UTC
[Xen-users] Re: [Xen-devel] RHEL6 xen and dom0 kernel to test
On Fri, May 20, 2011 at 10:27:02PM +0100, M A Young wrote:> I have been working on xen and dom0 kernel packages for RHEL6 and they > are now at the stage where they are suitable for wider testing. >Nice! Thanks a lot for this work!> There are xen 4.1 RPMs at http://xenbits.xen.org/people/mayoung/EL6.xen/ > which are simply the Fedora 15 package recompiled for RHEL6. > > The dom0 kernel packages are at > http://xenbits.xen.org/people/mayoung/testing/ and are basically the > 2.6.32-71.29.1.el6 kernel with the addition of xen specific patches from > Jeremy''s xen/stable-2.6.32.x branch at the 2.6.32.39 merge, and a few > code and configuration changes to get it to build. It isn''t ABI > compatible with true RHEL6 kernels because of the changes. It should set > up grub correctly for a dom0 boot if the hypervisor is present (though I > suggest you check the grub.conf file until it is better tested). > > Let me know if you see any problems. >I hope I get to test them soon. I''ll let you know how it goes. -- Pasi _______________________________________________ Xen-users mailing list Xen-users@lists.xensource.com http://lists.xensource.com/xen-users
Dear all, there is a problem with xl that will still prevent it tob e a replacement for xm in /etc/init.d/xendomains. I tracked it down to the rdname function in the a.m. file, which is expecting the command xm create --dryrun --quiet <config-file> to create a Lisp-like structure, where the xendomain script will extract the DomU name from. xl create --dryrun --quiet <config-file> will not output such a structure. xl -d -f <config-file> will do, but as soon as combined with -n, it will not. My setting is starting/shutting down only DomUs mentioned in /etc/xen/auto. BR, Carsten. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Ian Campbell
2011-May-24 09:27 UTC
Re: [Xen-devel] Possible Compatibility Bug in xl create
On Mon, 2011-05-23 at 21:01 +0100, Carsten Schiers wrote:> Dear all, > > there is a problem with xl that will still prevent it tob e a > replacement for xm in /etc/init.d/xendomains. > > I tracked it down to the rdname function in the a.m. file, which is > expecting the command > > xm create --dryrun --quiet <config-file> > > to create a Lisp-like structure, where the xendomain script will extract > the DomU name from. > > xl create --dryrun --quiet <config-file> > > will not output such a structure. > > xl -d -f <config-file> > > will do, but as soon as combined with -n, it will not. > > My setting is starting/shutting down only DomUs mentioned in > /etc/xen/auto.Thanks, I was just asking the other day who/what used that sxp output... Personally think this behaviour of grepping the name out of the sxp is pretty mad (I think an xl command to parse the configuration and output a specific request field value would be far better) but in the interests of xm compatibility does the following work for you? 8<-------------------------------------- # HG changeset patch # User Ian Campbell <ian.campbell@citrix.com> # Date 1306229164 -3600 # Node ID 29bd959c779a629def4de2cda7c1cc2eae291df5 # Parent 32d62506e3be95124097775dc79c42304a18084c xl: print sxp on dry-run of create. The help text for xm create''s --dry-run says "Dry run - prints the resulting configuration in SXP but does not create the domain." so update xl implementation to match. Signed-off-by: Ian Campbell <ian.campbell@citrix.com> diff -r 32d62506e3be -r 29bd959c779a tools/libxl/xl_cmdimpl.c --- a/tools/libxl/xl_cmdimpl.c Tue May 24 10:14:10 2011 +0100 +++ b/tools/libxl/xl_cmdimpl.c Tue May 24 10:26:04 2011 +0100 @@ -1470,10 +1470,6 @@ static int create_domain(struct domain_c parse_config_data(config_file, config_data, config_len, &d_config, &d_config.dm_info); - ret = 0; - if (dom_info->dryrun) - goto out; - if (migrate_fd >= 0) { if (d_config.c_info.name) { /* when we receive a domain we get its name from the config @@ -1492,9 +1488,13 @@ static int create_domain(struct domain_c } } - if (debug) + if (debug || dom_info->dryrun) printf_info(-1, &d_config, &d_config.dm_info); + ret = 0; + if (dom_info->dryrun) + goto out; + start: domid = -1; _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Carsten Schiers
2011-May-24 09:40 UTC
AW: [Xen-devel] Possible Compatibility Bug in xl create
I''ll check that tonight. Yep, I think modifying xendomains would be the better way. Sorry that I overlooked your other day''s question. BR, Carsten. ----- Originalnachricht ----- Von: Ian Campbell <Ian.Campbell@citrix.com> Gesendet: Die, 24.5.2011 11:27 An: Carsten Schiers <carsten@schiers.de> Cc: xen-devel <xen-devel@lists.xensource.com> ; Stefano Stabellini <Stefano.Stabellini@eu.citrix.com> Betreff: Re: [Xen-devel] Possible Compatibility Bug in xl create On Mon, 2011-05-23 at 21:01 +0100, Carsten Schiers wrote:> Dear all, > > there is a problem with xl that will still prevent it tob e a > replacement for xm in /etc/init.d/xendomains. > > I tracked it down to the rdname function in the a.m. file, which is > expecting the command > > xm create --dryrun --quiet <config-file> > > to create a Lisp-like structure, where the xendomain script will extract > the DomU name from. > > xl create --dryrun --quiet <config-file> > > will not output such a structure. > > xl -d -f <config-file> > > will do, but as soon as combined with -n, it will not. > > My setting is starting/shutting down only DomUs mentioned in > /etc/xen/auto.Thanks, I was just asking the other day who/what used that sxp output... Personally think this behaviour of grepping the name out of the sxp is pretty mad (I think an xl command to parse the configuration and output a specific request field value would be far better) but in the interests of xm compatibility does the following work for you? 8<-------------------------------------- # HG changeset patch # User Ian Campbell <ian.campbell@citrix.com> # Date 1306229164 -3600 # Node ID 29bd959c779a629def4de2cda7c1cc2eae291df5 # Parent 32d62506e3be95124097775dc79c42304a18084c xl: print sxp on dry-run of create. The help text for xm create''s --dry-run says "Dry run - prints the resulting configuration in SXP but does not create the domain." so update xl implementation to match. Signed-off-by: Ian Campbell <ian.campbell@citrix.com> diff -r 32d62506e3be -r 29bd959c779a tools/libxl/xl_cmdimpl.c --- a/tools/libxl/xl_cmdimpl.c Tue May 24 10:14:10 2011 +0100 +++ b/tools/libxl/xl_cmdimpl.c Tue May 24 10:26:04 2011 +0100 @@ -1470,10 +1470,6 @@ static int create_domain(struct domain_c parse_config_data(config_file, config_data, config_len, &d_config, &d_config.dm_info); - ret = 0; - if (dom_info->dryrun) - goto out; - if (migrate_fd >= 0) { if (d_config.c_info.name) { /* when we receive a domain we get its name from the config @@ -1492,9 +1488,13 @@ static int create_domain(struct domain_c } } - if (debug) + if (debug || dom_info->dryrun) printf_info(-1, &d_config, &d_config.dm_info); + ret = 0; + if (dom_info->dryrun) + goto out; + start: domid = -1; _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Ian Campbell
2011-May-24 09:43 UTC
Re: AW: [Xen-devel] Possible Compatibility Bug in xl create
On Tue, 2011-05-24 at 10:40 +0100, Carsten Schiers wrote:> I''ll check that tonight.Thanks.> Yep, I think modifying xendomains would be the > better way. Sorry that I overlooked your other day''s question.No worries, it was just a vague aside in some other conversation I think... Ian.> > BR, > Carsten. > > ----- Originalnachricht ----- > Von: Ian Campbell <Ian.Campbell@citrix.com> > Gesendet: Die, 24.5.2011 11:27 > An: Carsten Schiers <carsten@schiers.de> > Cc: xen-devel <xen-devel@lists.xensource.com> ; Stefano Stabellini <Stefano.Stabellini@eu.citrix.com> > Betreff: Re: [Xen-devel] Possible Compatibility Bug in xl create > > On Mon, 2011-05-23 at 21:01 +0100, Carsten Schiers wrote: > > Dear all, > > > > there is a problem with xl that will still prevent it tob e a > > replacement for xm in /etc/init.d/xendomains. > > > > I tracked it down to the rdname function in the a.m. file, which is > > expecting the command > > > > xm create --dryrun --quiet <config-file> > > > > to create a Lisp-like structure, where the xendomain script will extract > > the DomU name from. > > > > xl create --dryrun --quiet <config-file> > > > > will not output such a structure. > > > > xl -d -f <config-file> > > > > will do, but as soon as combined with -n, it will not. > > > > My setting is starting/shutting down only DomUs mentioned in > > /etc/xen/auto. > > Thanks, I was just asking the other day who/what used that sxp output... > > Personally think this behaviour of grepping the name out of the sxp is > pretty mad (I think an xl command to parse the configuration and output > a specific request field value would be far better) but in the interests > of xm compatibility does the following work for you? > > 8<-------------------------------------- > > # HG changeset patch > # User Ian Campbell <ian.campbell@citrix.com> > # Date 1306229164 -3600 > # Node ID 29bd959c779a629def4de2cda7c1cc2eae291df5 > # Parent 32d62506e3be95124097775dc79c42304a18084c > xl: print sxp on dry-run of create. > > The help text for xm create''s --dry-run says "Dry run - prints the resulting > configuration in SXP but does not create the domain." so update xl > implementation to match. > > Signed-off-by: Ian Campbell <ian.campbell@citrix.com> > > diff -r 32d62506e3be -r 29bd959c779a tools/libxl/xl_cmdimpl.c > --- a/tools/libxl/xl_cmdimpl.c Tue May 24 10:14:10 2011 +0100 > +++ b/tools/libxl/xl_cmdimpl.c Tue May 24 10:26:04 2011 +0100 > @@ -1470,10 +1470,6 @@ static int create_domain(struct domain_c > > parse_config_data(config_file, config_data, config_len, &d_config, &d_config.dm_info); > > - ret = 0; > - if (dom_info->dryrun) > - goto out; > - > if (migrate_fd >= 0) { > if (d_config.c_info.name) { > /* when we receive a domain we get its name from the config > @@ -1492,9 +1488,13 @@ static int create_domain(struct domain_c > } > } > > - if (debug) > + if (debug || dom_info->dryrun) > printf_info(-1, &d_config, &d_config.dm_info); > > + ret = 0; > + if (dom_info->dryrun) > + goto out; > + > start: > domid = -1; > > > >_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Carsten Schiers
2011-May-24 20:19 UTC
AW: Re: AW: [Xen-devel] Possible Compatibility Bug in xl create
Hi, the patch is doing what you would expect, but still not solving my issue. /etc/init.d/xendomains will start all domains, but is not stopping it. It''s somewhere in the parseln function, which is not recognizing the (name xyz) part. Unfortunately, I have not enough time today to test further. I currently have no clue where the input from the parseln function will come from in stop function. I would Need to find out and check the differences between the xm and xl version. In order to make it workable, I had by the way to modify the xendomains script and remove the dependency of xend. As said, I plan to start all DomUs per /etc/xen/auto and shutdown with shutdown of Dom0 without having xend running. If you don''t see it by my description, I''ll check more tomorrow evening. BR, Carsten. -----Ursprüngliche Nachricht----- Von: Ian Campbell [mailto:Ian.Campbell@eu.citrix.com] Gesendet: Dienstag, 24. Mai 2011 11:43 An: Carsten Schiers Cc: xen-devel; Stefano Stabellini Betreff: Re: AW: [Xen-devel] Possible Compatibility Bug in xl create On Tue, 2011-05-24 at 10:40 +0100, Carsten Schiers wrote:> I''ll check that tonight.Thanks.> Yep, I think modifying xendomains would be the > better way. Sorry that I overlooked your other day''s question.No worries, it was just a vague aside in some other conversation I think... Ian.> > BR, > Carsten. > > ----- Originalnachricht ----- > Von: Ian Campbell <Ian.Campbell@citrix.com> > Gesendet: Die, 24.5.2011 11:27 > An: Carsten Schiers <carsten@schiers.de> > Cc: xen-devel <xen-devel@lists.xensource.com> ; Stefano Stabellini<Stefano.Stabellini@eu.citrix.com>> Betreff: Re: [Xen-devel] Possible Compatibility Bug in xl create > > On Mon, 2011-05-23 at 21:01 +0100, Carsten Schiers wrote: > > Dear all, > > > > there is a problem with xl that will still prevent it tob e a > > replacement for xm in /etc/init.d/xendomains. > > > > I tracked it down to the rdname function in the a.m. file, which is > > expecting the command > > > > xm create --dryrun --quiet <config-file> > > > > to create a Lisp-like structure, where the xendomain script willextract> > the DomU name from. > > > > xl create --dryrun --quiet <config-file> > > > > will not output such a structure. > > > > xl -d -f <config-file> > > > > will do, but as soon as combined with -n, it will not. > > > > My setting is starting/shutting down only DomUs mentioned in > > /etc/xen/auto. > > Thanks, I was just asking the other day who/what used that sxpoutput...> > Personally think this behaviour of grepping the name out of the sxp is > pretty mad (I think an xl command to parse the configuration andoutput> a specific request field value would be far better) but in theinterests> of xm compatibility does the following work for you? > > 8<-------------------------------------- > > # HG changeset patch > # User Ian Campbell <ian.campbell@citrix.com> > # Date 1306229164 -3600 > # Node ID 29bd959c779a629def4de2cda7c1cc2eae291df5 > # Parent 32d62506e3be95124097775dc79c42304a18084c > xl: print sxp on dry-run of create. > > The help text for xm create''s --dry-run says "Dry run - prints theresulting> configuration in SXP but does not create the domain." so update xl > implementation to match. > > Signed-off-by: Ian Campbell <ian.campbell@citrix.com> > > diff -r 32d62506e3be -r 29bd959c779a tools/libxl/xl_cmdimpl.c > --- a/tools/libxl/xl_cmdimpl.c Tue May 24 10:14:10 2011 +0100 > +++ b/tools/libxl/xl_cmdimpl.c Tue May 24 10:26:04 2011 +0100 > @@ -1470,10 +1470,6 @@ static int create_domain(struct domain_c > > parse_config_data(config_file, config_data, config_len,&d_config, &d_config.dm_info);> > - ret = 0; > - if (dom_info->dryrun) > - goto out; > - > if (migrate_fd >= 0) { > if (d_config.c_info.name) { > /* when we receive a domain we get its name from theconfig> @@ -1492,9 +1488,13 @@ static int create_domain(struct domain_c > } > } > > - if (debug) > + if (debug || dom_info->dryrun) > printf_info(-1, &d_config, &d_config.dm_info); > > + ret = 0; > + if (dom_info->dryrun) > + goto out; > + > start: > domid = -1; > > > >_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Carsten Schiers
2011-May-25 18:47 UTC
AW: Re: AW: [Xen-devel] Possible Compatibility Bug in xl create
I found the problem. The (domain_create_info) and (domain_build_info) statements from the "xl list -l" and eventually also the repeating (domid) statements in the listing of devices per domain are confusing the parseln logic, which is trying to guess a domid/domname combo from the output: root@data:~# xm list -l | grep ''(\(domain\|domid\|name\)'' (domain (domid 0) (name Domain-0) (domain (domid 10) (name blip) (domain (domid 9) (name blub) root@data:~# xl list -l | grep ''(\(domain\|domid\|name\)'' (domain (domid 9) (domain_create_info) (name blub) (domain_build_info) (domid 0) (domid 0) (domid 0) (domain (domid 10) (domain_create_info) (name blip) (domain_build_info) (domid 0) (domid 0) (domid 0) parseln() { if [[ "$1" =~ ''(domain'' ]]; then name=;id else if [[ "$1" =~ ''(name'' ]]; then name=$(echo $1 | sed -e ''s/^.*(name \(.*\))$/\1/'') else if [[ "$1" =~ ''(domid'' ]]; then id=$(echo $1 | sed -e ''s/^.*(domid \(.*\))$/\1/'') fi; fi; fi [ -n "$name" -a -n "$id" ] && return 0 || return 1 } is resetting on each (domain_create_info) and (domain_build_info) as well the name/id pair and will set domid to 0 each time it comes across the device listing (domid 0). This will result in ignoring the entry also, as stop is containing: name=;id while read LN; do parseln "$LN" || continue if test $id = 0; then continue; fi echo -n " $name" and I think it assumes in the "if test" part that it came across Domain-0. I leave it to you guys "in charge" to either modify the "xl list -l" command or rewrite /etc/init.d/xendomains. The patch is still needed. By the way: I had to patch it partly manually, the last few lines didn''t work for me when patching original xen-4.1.0. BR, Carsten. -----Ursprüngliche Nachricht----- Von: Carsten Schiers Gesendet: Dienstag, 24. Mai 2011 22:19 An: Ian.Campbell Cc: xen-devel; Stefano.Stabellini Betreff: AW: Re: AW: [Xen-devel] Possible Compatibility Bug in xl create Hi, the patch is doing what you would expect, but still not solving my issue. /etc/init.d/xendomains will start all domains, but is not stopping it. It''s somewhere in the parseln function, which is not recognizing the (name xyz) part. Unfortunately, I have not enough time today to test further. I currently have no clue where the input from the parseln function will come from in stop function. I would Need to find out and check the differences between the xm and xl version. In order to make it workable, I had by the way to modify the xendomains script and remove the dependency of xend. As said, I plan to start all DomUs per /etc/xen/auto and shutdown with shutdown of Dom0 without having xend running. If you don''t see it by my description, I''ll check more tomorrow evening. BR, Carsten. -----Ursprüngliche Nachricht----- Von: Ian Campbell [mailto:Ian.Campbell@eu.citrix.com] Gesendet: Dienstag, 24. Mai 2011 11:43 An: Carsten Schiers Cc: xen-devel; Stefano Stabellini Betreff: Re: AW: [Xen-devel] Possible Compatibility Bug in xl create On Tue, 2011-05-24 at 10:40 +0100, Carsten Schiers wrote:> I''ll check that tonight.Thanks.> Yep, I think modifying xendomains would be the > better way. Sorry that I overlooked your other day''s question.No worries, it was just a vague aside in some other conversation I think... Ian.> > BR, > Carsten. > > ----- Originalnachricht ----- > Von: Ian Campbell <Ian.Campbell@citrix.com> > Gesendet: Die, 24.5.2011 11:27 > An: Carsten Schiers <carsten@schiers.de> > Cc: xen-devel <xen-devel@lists.xensource.com> ; Stefano Stabellini<Stefano.Stabellini@eu.citrix.com>> Betreff: Re: [Xen-devel] Possible Compatibility Bug in xl create > > On Mon, 2011-05-23 at 21:01 +0100, Carsten Schiers wrote: > > Dear all, > > > > there is a problem with xl that will still prevent it tob e a > > replacement for xm in /etc/init.d/xendomains. > > > > I tracked it down to the rdname function in the a.m. file, which is > > expecting the command > > > > xm create --dryrun --quiet <config-file> > > > > to create a Lisp-like structure, where the xendomain script willextract> > the DomU name from. > > > > xl create --dryrun --quiet <config-file> > > > > will not output such a structure. > > > > xl -d -f <config-file> > > > > will do, but as soon as combined with -n, it will not. > > > > My setting is starting/shutting down only DomUs mentioned in > > /etc/xen/auto. > > Thanks, I was just asking the other day who/what used that sxpoutput...> > Personally think this behaviour of grepping the name out of the sxp is > pretty mad (I think an xl command to parse the configuration andoutput> a specific request field value would be far better) but in theinterests> of xm compatibility does the following work for you? > > 8<-------------------------------------- > > # HG changeset patch > # User Ian Campbell <ian.campbell@citrix.com> > # Date 1306229164 -3600 > # Node ID 29bd959c779a629def4de2cda7c1cc2eae291df5 > # Parent 32d62506e3be95124097775dc79c42304a18084c > xl: print sxp on dry-run of create. > > The help text for xm create''s --dry-run says "Dry run - prints theresulting> configuration in SXP but does not create the domain." so update xl > implementation to match. > > Signed-off-by: Ian Campbell <ian.campbell@citrix.com> > > diff -r 32d62506e3be -r 29bd959c779a tools/libxl/xl_cmdimpl.c > --- a/tools/libxl/xl_cmdimpl.c Tue May 24 10:14:10 2011 +0100 > +++ b/tools/libxl/xl_cmdimpl.c Tue May 24 10:26:04 2011 +0100 > @@ -1470,10 +1470,6 @@ static int create_domain(struct domain_c > > parse_config_data(config_file, config_data, config_len,&d_config, &d_config.dm_info);> > - ret = 0; > - if (dom_info->dryrun) > - goto out; > - > if (migrate_fd >= 0) { > if (d_config.c_info.name) { > /* when we receive a domain we get its name from theconfig> @@ -1492,9 +1488,13 @@ static int create_domain(struct domain_c > } > } > > - if (debug) > + if (debug || dom_info->dryrun) > printf_info(-1, &d_config, &d_config.dm_info); > > + ret = 0; > + if (dom_info->dryrun) > + goto out; > + > start: > domid = -1; > > > >_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Carsten Schiers
2011-May-25 19:07 UTC
AW: Re: AW: [Xen-devel] Possible Compatibility Bug in xl create
Crosscheck: renamed domain_create_info -> create_info_domain domain_build_info -> build_info_domain domid (in three device blocks) -> devdomid in tools/libxl/xl_cmdimpl.c and everything works as expected with my /etc/default/xendomains, which ist shutting down and restarting from /etc/xen/auto only. BR, Carsten. -----Ursprüngliche Nachricht----- Von: Carsten Schiers Gesendet: Mittwoch, 25. Mai 2011 20:47 An: fantonifabio; Ian.Campbell Cc: xen-devel; Stefano.Stabellini Betreff: AW: Re: AW: [Xen-devel] Possible Compatibility Bug in xl create I found the problem. The (domain_create_info) and (domain_build_info) statements from the "xl list -l" and eventually also the repeating (domid) statements in the listing of devices per domain are confusing the parseln logic, which is trying to guess a domid/domname combo from the output: root@data:~# xm list -l | grep ''(\(domain\|domid\|name\)'' (domain (domid 0) (name Domain-0) (domain (domid 10) (name blip) (domain (domid 9) (name blub) root@data:~# xl list -l | grep ''(\(domain\|domid\|name\)'' (domain (domid 9) (domain_create_info) (name blub) (domain_build_info) (domid 0) (domid 0) (domid 0) (domain (domid 10) (domain_create_info) (name blip) (domain_build_info) (domid 0) (domid 0) (domid 0) parseln() { if [[ "$1" =~ ''(domain'' ]]; then name=;id else if [[ "$1" =~ ''(name'' ]]; then name=$(echo $1 | sed -e ''s/^.*(name \(.*\))$/\1/'') else if [[ "$1" =~ ''(domid'' ]]; then id=$(echo $1 | sed -e ''s/^.*(domid \(.*\))$/\1/'') fi; fi; fi [ -n "$name" -a -n "$id" ] && return 0 || return 1 } is resetting on each (domain_create_info) and (domain_build_info) as well the name/id pair and will set domid to 0 each time it comes across the device listing (domid 0). This will result in ignoring the entry also, as stop is containing: name=;id while read LN; do parseln "$LN" || continue if test $id = 0; then continue; fi echo -n " $name" and I think it assumes in the "if test" part that it came across Domain-0. I leave it to you guys "in charge" to either modify the "xl list -l" command or rewrite /etc/init.d/xendomains. The patch is still needed. By the way: I had to patch it partly manually, the last few lines didn''t work for me when patching original xen-4.1.0. BR, Carsten. -----Ursprüngliche Nachricht----- Von: Carsten Schiers Gesendet: Dienstag, 24. Mai 2011 22:19 An: Ian.Campbell Cc: xen-devel; Stefano.Stabellini Betreff: AW: Re: AW: [Xen-devel] Possible Compatibility Bug in xl create Hi, the patch is doing what you would expect, but still not solving my issue. /etc/init.d/xendomains will start all domains, but is not stopping it. It''s somewhere in the parseln function, which is not recognizing the (name xyz) part. Unfortunately, I have not enough time today to test further. I currently have no clue where the input from the parseln function will come from in stop function. I would Need to find out and check the differences between the xm and xl version. In order to make it workable, I had by the way to modify the xendomains script and remove the dependency of xend. As said, I plan to start all DomUs per /etc/xen/auto and shutdown with shutdown of Dom0 without having xend running. If you don''t see it by my description, I''ll check more tomorrow evening. BR, Carsten. -----Ursprüngliche Nachricht----- Von: Ian Campbell [mailto:Ian.Campbell@eu.citrix.com] Gesendet: Dienstag, 24. Mai 2011 11:43 An: Carsten Schiers Cc: xen-devel; Stefano Stabellini Betreff: Re: AW: [Xen-devel] Possible Compatibility Bug in xl create On Tue, 2011-05-24 at 10:40 +0100, Carsten Schiers wrote:> I''ll check that tonight.Thanks.> Yep, I think modifying xendomains would be the > better way. Sorry that I overlooked your other day''s question.No worries, it was just a vague aside in some other conversation I think... Ian.> > BR, > Carsten. > > ----- Originalnachricht ----- > Von: Ian Campbell <Ian.Campbell@citrix.com> > Gesendet: Die, 24.5.2011 11:27 > An: Carsten Schiers <carsten@schiers.de> > Cc: xen-devel <xen-devel@lists.xensource.com> ; Stefano Stabellini<Stefano.Stabellini@eu.citrix.com>> Betreff: Re: [Xen-devel] Possible Compatibility Bug in xl create > > On Mon, 2011-05-23 at 21:01 +0100, Carsten Schiers wrote: > > Dear all, > > > > there is a problem with xl that will still prevent it tob e a > > replacement for xm in /etc/init.d/xendomains. > > > > I tracked it down to the rdname function in the a.m. file, which is > > expecting the command > > > > xm create --dryrun --quiet <config-file> > > > > to create a Lisp-like structure, where the xendomain script willextract> > the DomU name from. > > > > xl create --dryrun --quiet <config-file> > > > > will not output such a structure. > > > > xl -d -f <config-file> > > > > will do, but as soon as combined with -n, it will not. > > > > My setting is starting/shutting down only DomUs mentioned in > > /etc/xen/auto. > > Thanks, I was just asking the other day who/what used that sxpoutput...> > Personally think this behaviour of grepping the name out of the sxp is > pretty mad (I think an xl command to parse the configuration andoutput> a specific request field value would be far better) but in theinterests> of xm compatibility does the following work for you? > > 8<-------------------------------------- > > # HG changeset patch > # User Ian Campbell <ian.campbell@citrix.com> > # Date 1306229164 -3600 > # Node ID 29bd959c779a629def4de2cda7c1cc2eae291df5 > # Parent 32d62506e3be95124097775dc79c42304a18084c > xl: print sxp on dry-run of create. > > The help text for xm create''s --dry-run says "Dry run - prints theresulting> configuration in SXP but does not create the domain." so update xl > implementation to match. > > Signed-off-by: Ian Campbell <ian.campbell@citrix.com> > > diff -r 32d62506e3be -r 29bd959c779a tools/libxl/xl_cmdimpl.c > --- a/tools/libxl/xl_cmdimpl.c Tue May 24 10:14:10 2011 +0100 > +++ b/tools/libxl/xl_cmdimpl.c Tue May 24 10:26:04 2011 +0100 > @@ -1470,10 +1470,6 @@ static int create_domain(struct domain_c > > parse_config_data(config_file, config_data, config_len,&d_config, &d_config.dm_info);> > - ret = 0; > - if (dom_info->dryrun) > - goto out; > - > if (migrate_fd >= 0) { > if (d_config.c_info.name) { > /* when we receive a domain we get its name from theconfig> @@ -1492,9 +1488,13 @@ static int create_domain(struct domain_c > } > } > > - if (debug) > + if (debug || dom_info->dryrun) > printf_info(-1, &d_config, &d_config.dm_info); > > + ret = 0; > + if (dom_info->dryrun) > + goto out; > + > start: > domid = -1; > > > >_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Carsten Schiers
2011-May-25 20:36 UTC
AW: Re: AW: [Xen-devel] Possible Compatibility Bug in xl create
Sorry, one add-on: I have the feeling that /etc/init.d/xendomains stop will not wait for the domains to shut down. It is finished very quickly and I can see the domains shutting down with xl list afterwards. I guess this is not the default behavior, as the xm version waits for every domain to have disappeared. BR, Carsten. -----Ursprüngliche Nachricht----- Von: Carsten Schiers Gesendet: Mittwoch, 25. Mai 2011 21:07 An: fantonifabio; Ian.Campbell Cc: xen-devel; Stefano.Stabellini Betreff: AW: Re: AW: [Xen-devel] Possible Compatibility Bug in xl create Crosscheck: renamed domain_create_info -> create_info_domain domain_build_info -> build_info_domain domid (in three device blocks) -> devdomid in tools/libxl/xl_cmdimpl.c and everything works as expected with my /etc/default/xendomains, which ist shutting down and restarting from /etc/xen/auto only. BR, Carsten. -----Ursprüngliche Nachricht----- Von: Carsten Schiers Gesendet: Mittwoch, 25. Mai 2011 20:47 An: fantonifabio; Ian.Campbell Cc: xen-devel; Stefano.Stabellini Betreff: AW: Re: AW: [Xen-devel] Possible Compatibility Bug in xl create I found the problem. The (domain_create_info) and (domain_build_info) statements from the "xl list -l" and eventually also the repeating (domid) statements in the listing of devices per domain are confusing the parseln logic, which is trying to guess a domid/domname combo from the output: root@data:~# xm list -l | grep ''(\(domain\|domid\|name\)'' (domain (domid 0) (name Domain-0) (domain (domid 10) (name blip) (domain (domid 9) (name blub) root@data:~# xl list -l | grep ''(\(domain\|domid\|name\)'' (domain (domid 9) (domain_create_info) (name blub) (domain_build_info) (domid 0) (domid 0) (domid 0) (domain (domid 10) (domain_create_info) (name blip) (domain_build_info) (domid 0) (domid 0) (domid 0) parseln() { if [[ "$1" =~ ''(domain'' ]]; then name=;id else if [[ "$1" =~ ''(name'' ]]; then name=$(echo $1 | sed -e ''s/^.*(name \(.*\))$/\1/'') else if [[ "$1" =~ ''(domid'' ]]; then id=$(echo $1 | sed -e ''s/^.*(domid \(.*\))$/\1/'') fi; fi; fi [ -n "$name" -a -n "$id" ] && return 0 || return 1 } is resetting on each (domain_create_info) and (domain_build_info) as well the name/id pair and will set domid to 0 each time it comes across the device listing (domid 0). This will result in ignoring the entry also, as stop is containing: name=;id while read LN; do parseln "$LN" || continue if test $id = 0; then continue; fi echo -n " $name" and I think it assumes in the "if test" part that it came across Domain-0. I leave it to you guys "in charge" to either modify the "xl list -l" command or rewrite /etc/init.d/xendomains. The patch is still needed. By the way: I had to patch it partly manually, the last few lines didn''t work for me when patching original xen-4.1.0. BR, Carsten. -----Ursprüngliche Nachricht----- Von: Carsten Schiers Gesendet: Dienstag, 24. Mai 2011 22:19 An: Ian.Campbell Cc: xen-devel; Stefano.Stabellini Betreff: AW: Re: AW: [Xen-devel] Possible Compatibility Bug in xl create Hi, the patch is doing what you would expect, but still not solving my issue. /etc/init.d/xendomains will start all domains, but is not stopping it. It''s somewhere in the parseln function, which is not recognizing the (name xyz) part. Unfortunately, I have not enough time today to test further. I currently have no clue where the input from the parseln function will come from in stop function. I would Need to find out and check the differences between the xm and xl version. In order to make it workable, I had by the way to modify the xendomains script and remove the dependency of xend. As said, I plan to start all DomUs per /etc/xen/auto and shutdown with shutdown of Dom0 without having xend running. If you don''t see it by my description, I''ll check more tomorrow evening. BR, Carsten. -----Ursprüngliche Nachricht----- Von: Ian Campbell [mailto:Ian.Campbell@eu.citrix.com] Gesendet: Dienstag, 24. Mai 2011 11:43 An: Carsten Schiers Cc: xen-devel; Stefano Stabellini Betreff: Re: AW: [Xen-devel] Possible Compatibility Bug in xl create On Tue, 2011-05-24 at 10:40 +0100, Carsten Schiers wrote:> I''ll check that tonight.Thanks.> Yep, I think modifying xendomains would be the > better way. Sorry that I overlooked your other day''s question.No worries, it was just a vague aside in some other conversation I think... Ian.> > BR, > Carsten. > > ----- Originalnachricht ----- > Von: Ian Campbell <Ian.Campbell@citrix.com> > Gesendet: Die, 24.5.2011 11:27 > An: Carsten Schiers <carsten@schiers.de> > Cc: xen-devel <xen-devel@lists.xensource.com> ; Stefano Stabellini<Stefano.Stabellini@eu.citrix.com>> Betreff: Re: [Xen-devel] Possible Compatibility Bug in xl create > > On Mon, 2011-05-23 at 21:01 +0100, Carsten Schiers wrote: > > Dear all, > > > > there is a problem with xl that will still prevent it tob e a > > replacement for xm in /etc/init.d/xendomains. > > > > I tracked it down to the rdname function in the a.m. file, which is > > expecting the command > > > > xm create --dryrun --quiet <config-file> > > > > to create a Lisp-like structure, where the xendomain script willextract> > the DomU name from. > > > > xl create --dryrun --quiet <config-file> > > > > will not output such a structure. > > > > xl -d -f <config-file> > > > > will do, but as soon as combined with -n, it will not. > > > > My setting is starting/shutting down only DomUs mentioned in > > /etc/xen/auto. > > Thanks, I was just asking the other day who/what used that sxpoutput...> > Personally think this behaviour of grepping the name out of the sxp is > pretty mad (I think an xl command to parse the configuration andoutput> a specific request field value would be far better) but in theinterests> of xm compatibility does the following work for you? > > 8<-------------------------------------- > > # HG changeset patch > # User Ian Campbell <ian.campbell@citrix.com> > # Date 1306229164 -3600 > # Node ID 29bd959c779a629def4de2cda7c1cc2eae291df5 > # Parent 32d62506e3be95124097775dc79c42304a18084c > xl: print sxp on dry-run of create. > > The help text for xm create''s --dry-run says "Dry run - prints theresulting> configuration in SXP but does not create the domain." so update xl > implementation to match. > > Signed-off-by: Ian Campbell <ian.campbell@citrix.com> > > diff -r 32d62506e3be -r 29bd959c779a tools/libxl/xl_cmdimpl.c > --- a/tools/libxl/xl_cmdimpl.c Tue May 24 10:14:10 2011 +0100 > +++ b/tools/libxl/xl_cmdimpl.c Tue May 24 10:26:04 2011 +0100 > @@ -1470,10 +1470,6 @@ static int create_domain(struct domain_c > > parse_config_data(config_file, config_data, config_len,&d_config, &d_config.dm_info);> > - ret = 0; > - if (dom_info->dryrun) > - goto out; > - > if (migrate_fd >= 0) { > if (d_config.c_info.name) { > /* when we receive a domain we get its name from theconfig> @@ -1492,9 +1488,13 @@ static int create_domain(struct domain_c > } > } > > - if (debug) > + if (debug || dom_info->dryrun) > printf_info(-1, &d_config, &d_config.dm_info); > > + ret = 0; > + if (dom_info->dryrun) > + goto out; > + > start: > domid = -1; > > > >_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Carsten Schiers
2011-May-25 20:47 UTC
AW: Re: AW: [Xen-devel] Possible Compatibility Bug in xl create
OK, last message for today ;o). --wait option of xl will not wait for domain to have shut down. BR, Carsten. -----Ursprüngliche Nachricht----- Von: Carsten Schiers Gesendet: Mittwoch, 25. Mai 2011 22:37 An: ''fantonifabio''; ''Ian.Campbell'' Cc: ''xen-devel''; ''Stefano.Stabellini'' Betreff: AW: Re: AW: [Xen-devel] Possible Compatibility Bug in xl create Sorry, one add-on: I have the feeling that /etc/init.d/xendomains stop will not wait for the domains to shut down. It is finished very quickly and I can see the domains shutting down with xl list afterwards. I guess this is not the default behavior, as the xm version waits for every domain to have disappeared. BR, Carsten. -----Ursprüngliche Nachricht----- Von: Carsten Schiers Gesendet: Mittwoch, 25. Mai 2011 21:07 An: fantonifabio; Ian.Campbell Cc: xen-devel; Stefano.Stabellini Betreff: AW: Re: AW: [Xen-devel] Possible Compatibility Bug in xl create Crosscheck: renamed domain_create_info -> create_info_domain domain_build_info -> build_info_domain domid (in three device blocks) -> devdomid in tools/libxl/xl_cmdimpl.c and everything works as expected with my /etc/default/xendomains, which ist shutting down and restarting from /etc/xen/auto only. BR, Carsten. -----Ursprüngliche Nachricht----- Von: Carsten Schiers Gesendet: Mittwoch, 25. Mai 2011 20:47 An: fantonifabio; Ian.Campbell Cc: xen-devel; Stefano.Stabellini Betreff: AW: Re: AW: [Xen-devel] Possible Compatibility Bug in xl create I found the problem. The (domain_create_info) and (domain_build_info) statements from the "xl list -l" and eventually also the repeating (domid) statements in the listing of devices per domain are confusing the parseln logic, which is trying to guess a domid/domname combo from the output: root@data:~# xm list -l | grep ''(\(domain\|domid\|name\)'' (domain (domid 0) (name Domain-0) (domain (domid 10) (name blip) (domain (domid 9) (name blub) root@data:~# xl list -l | grep ''(\(domain\|domid\|name\)'' (domain (domid 9) (domain_create_info) (name blub) (domain_build_info) (domid 0) (domid 0) (domid 0) (domain (domid 10) (domain_create_info) (name blip) (domain_build_info) (domid 0) (domid 0) (domid 0) parseln() { if [[ "$1" =~ ''(domain'' ]]; then name=;id else if [[ "$1" =~ ''(name'' ]]; then name=$(echo $1 | sed -e ''s/^.*(name \(.*\))$/\1/'') else if [[ "$1" =~ ''(domid'' ]]; then id=$(echo $1 | sed -e ''s/^.*(domid \(.*\))$/\1/'') fi; fi; fi [ -n "$name" -a -n "$id" ] && return 0 || return 1 } is resetting on each (domain_create_info) and (domain_build_info) as well the name/id pair and will set domid to 0 each time it comes across the device listing (domid 0). This will result in ignoring the entry also, as stop is containing: name=;id while read LN; do parseln "$LN" || continue if test $id = 0; then continue; fi echo -n " $name" and I think it assumes in the "if test" part that it came across Domain-0. I leave it to you guys "in charge" to either modify the "xl list -l" command or rewrite /etc/init.d/xendomains. The patch is still needed. By the way: I had to patch it partly manually, the last few lines didn''t work for me when patching original xen-4.1.0. BR, Carsten. -----Ursprüngliche Nachricht----- Von: Carsten Schiers Gesendet: Dienstag, 24. Mai 2011 22:19 An: Ian.Campbell Cc: xen-devel; Stefano.Stabellini Betreff: AW: Re: AW: [Xen-devel] Possible Compatibility Bug in xl create Hi, the patch is doing what you would expect, but still not solving my issue. /etc/init.d/xendomains will start all domains, but is not stopping it. It''s somewhere in the parseln function, which is not recognizing the (name xyz) part. Unfortunately, I have not enough time today to test further. I currently have no clue where the input from the parseln function will come from in stop function. I would Need to find out and check the differences between the xm and xl version. In order to make it workable, I had by the way to modify the xendomains script and remove the dependency of xend. As said, I plan to start all DomUs per /etc/xen/auto and shutdown with shutdown of Dom0 without having xend running. If you don''t see it by my description, I''ll check more tomorrow evening. BR, Carsten. -----Ursprüngliche Nachricht----- Von: Ian Campbell [mailto:Ian.Campbell@eu.citrix.com] Gesendet: Dienstag, 24. Mai 2011 11:43 An: Carsten Schiers Cc: xen-devel; Stefano Stabellini Betreff: Re: AW: [Xen-devel] Possible Compatibility Bug in xl create On Tue, 2011-05-24 at 10:40 +0100, Carsten Schiers wrote:> I''ll check that tonight.Thanks.> Yep, I think modifying xendomains would be the > better way. Sorry that I overlooked your other day''s question.No worries, it was just a vague aside in some other conversation I think... Ian.> > BR, > Carsten. > > ----- Originalnachricht ----- > Von: Ian Campbell <Ian.Campbell@citrix.com> > Gesendet: Die, 24.5.2011 11:27 > An: Carsten Schiers <carsten@schiers.de> > Cc: xen-devel <xen-devel@lists.xensource.com> ; Stefano Stabellini<Stefano.Stabellini@eu.citrix.com>> Betreff: Re: [Xen-devel] Possible Compatibility Bug in xl create > > On Mon, 2011-05-23 at 21:01 +0100, Carsten Schiers wrote: > > Dear all, > > > > there is a problem with xl that will still prevent it tob e a > > replacement for xm in /etc/init.d/xendomains. > > > > I tracked it down to the rdname function in the a.m. file, which is > > expecting the command > > > > xm create --dryrun --quiet <config-file> > > > > to create a Lisp-like structure, where the xendomain script willextract> > the DomU name from. > > > > xl create --dryrun --quiet <config-file> > > > > will not output such a structure. > > > > xl -d -f <config-file> > > > > will do, but as soon as combined with -n, it will not. > > > > My setting is starting/shutting down only DomUs mentioned in > > /etc/xen/auto. > > Thanks, I was just asking the other day who/what used that sxpoutput...> > Personally think this behaviour of grepping the name out of the sxp is > pretty mad (I think an xl command to parse the configuration andoutput> a specific request field value would be far better) but in theinterests> of xm compatibility does the following work for you? > > 8<-------------------------------------- > > # HG changeset patch > # User Ian Campbell <ian.campbell@citrix.com> > # Date 1306229164 -3600 > # Node ID 29bd959c779a629def4de2cda7c1cc2eae291df5 > # Parent 32d62506e3be95124097775dc79c42304a18084c > xl: print sxp on dry-run of create. > > The help text for xm create''s --dry-run says "Dry run - prints theresulting> configuration in SXP but does not create the domain." so update xl > implementation to match. > > Signed-off-by: Ian Campbell <ian.campbell@citrix.com> > > diff -r 32d62506e3be -r 29bd959c779a tools/libxl/xl_cmdimpl.c > --- a/tools/libxl/xl_cmdimpl.c Tue May 24 10:14:10 2011 +0100 > +++ b/tools/libxl/xl_cmdimpl.c Tue May 24 10:26:04 2011 +0100 > @@ -1470,10 +1470,6 @@ static int create_domain(struct domain_c > > parse_config_data(config_file, config_data, config_len,&d_config, &d_config.dm_info);> > - ret = 0; > - if (dom_info->dryrun) > - goto out; > - > if (migrate_fd >= 0) { > if (d_config.c_info.name) { > /* when we receive a domain we get its name from theconfig> @@ -1492,9 +1488,13 @@ static int create_domain(struct domain_c > } > } > > - if (debug) > + if (debug || dom_info->dryrun) > printf_info(-1, &d_config, &d_config.dm_info); > > + ret = 0; > + if (dom_info->dryrun) > + goto out; > + > start: > domid = -1; > > > >_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Ian Jackson
2011-May-26 14:31 UTC
AW: Re: AW: [Xen-devel] Possible Compatibility Bug in xl create
Carsten Schiers writes ("AW: Re: AW: [Xen-devel] Possible Compatibility Bug in xl create"):> Crosscheck: renamed > domain_create_info -> create_info_domain > domain_build_info -> build_info_domain > domid (in three device blocks) -> devdomid > in tools/libxl/xl_cmdimpl.c and everything works as expected with > my /etc/default/xendomains, which ist shutting down and restarting > from /etc/xen/auto only.Would you care to send a patch to the "printf (blah blah)" output ? The only purpose for that code is for compatibility for situations exactly like yours and we should make it work like it used to. Please ensure to add a Signed-off-by line to your patch to signify its copyright status (see below). Thanks, Ian.>From Documentation/SubmittingPatches in the Linux kernel tree:Developer''s Certificate of Origin 1.1 By making a contribution to this project, I certify that: (a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or (b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or (c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it. (d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Ian Jackson
2011-May-26 14:31 UTC
AW: Re: AW: [Xen-devel] Possible Compatibility Bug in xl create
Carsten Schiers writes ("AW: Re: AW: [Xen-devel] Possible Compatibility Bug in xl create"):> OK, last message for today ;o). > > --wait option of xl will not wait for domain to have shut down.This is a bug. Ian. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Carsten Schiers
2011-May-26 18:26 UTC
[Xen-devel] [PATCH 1 of 2] xl: improve compatibility with xm
xl: improve compatibility with xm /etc/init.d/xendomains relies on simple pattern matching from sructures being printed by "xl list -l" command. so update xl implementation to match. Signed-off-by: Carsten Schiers <carsten@schiers.de> diff -r 37c77bacb52a tools/libxl/xl_cmdimpl.c --- a/tools/libxl/xl_cmdimpl.c Mon May 23 17:38:28 2011 +0100 +++ b/tools/libxl/xl_cmdimpl.c Thu May 26 19:58:46 2011 +0200 @@ -294,7 +294,7 @@ libxl_domain_build_info *b_info = &d_config->b_info; printf("(domain\n\t(domid %d)\n", domid); - printf("\t(domain_create_info)\n"); + printf("\t(create_info)\n"); printf("\t(hvm %d)\n", c_info->hvm); printf("\t(hap %d)\n", c_info->hap); printf("\t(oos %d)\n", c_info->oos); @@ -321,7 +321,7 @@ printf("\t(platformdata (null))\n"); - printf("\t(domain_build_info)\n"); + printf("\t(build_info)\n"); printf("\t(max_vcpus %d)\n", b_info->max_vcpus); printf("\t(tsc_mode %d)\n", b_info->tsc_mode); printf("\t(max_memkb %d)\n", b_info->max_memkb); @@ -381,7 +381,7 @@ printf("\t(device\n"); printf("\t\t(tap\n"); printf("\t\t\t(backend_domid %d)\n", d_config->disks[i].backend_domid); - printf("\t\t\t(domid %d)\n", domid); + printf("\t\t\t(frontend_domid %d)\n", domid); printf("\t\t\t(physpath %s)\n", d_config->disks[i].pdev_path); printf("\t\t\t(phystype %d)\n", d_config->disks[i].backend); printf("\t\t\t(virtpath %s)\n", d_config->disks[i].vdev); @@ -396,7 +396,7 @@ printf("\t(device\n"); printf("\t\t(vif\n"); printf("\t\t\t(backend_domid %d)\n", d_config->vifs[i].backend_domid); - printf("\t\t\t(domid %d)\n", domid); + printf("\t\t\t(frontend_domid %d)\n", domid); printf("\t\t\t(devid %d)\n", d_config->vifs[i].devid); printf("\t\t\t(mtu %d)\n", d_config->vifs[i].mtu); printf("\t\t\t(model %s)\n", d_config->vifs[i].model); @@ -426,7 +426,7 @@ printf("\t(device\n"); printf("\t\t(vfb\n"); printf("\t\t\t(backend_domid %d)\n", d_config->vfbs[i].backend_domid); - printf("\t\t\t(domid %d)\n", domid); + printf("\t\t\t(frontend_domid %d)\n", domid); printf("\t\t\t(devid %d)\n", d_config->vfbs[i].devid); printf("\t\t\t(vnc %d)\n", d_config->vfbs[i].vnc); printf("\t\t\t(vnclisten %s)\n", d_config->vfbs[i].vnclisten); _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Ian Campbell
2011-May-27 08:41 UTC
Re: [Xen-devel] [PATCH 1 of 2] xl: improve compatibility with xm
On Thu, 2011-05-26 at 19:26 +0100, Carsten Schiers wrote:> xl: improve compatibility with xm > > /etc/init.d/xendomains relies on simple pattern matching from sructures > being > printed by "xl list -l" command. so update xl implementation to match.Thanks. Does this mean that "xl list -l" now matches "xm list -l" for you, or just that it is close enough to make xendomains happy?> > Signed-off-by: Carsten Schiers <carsten@schiers.de> > > diff -r 37c77bacb52a tools/libxl/xl_cmdimpl.c > --- a/tools/libxl/xl_cmdimpl.c Mon May 23 17:38:28 2011 +0100 > +++ b/tools/libxl/xl_cmdimpl.c Thu May 26 19:58:46 2011 +0200 > @@ -294,7 +294,7 @@ > libxl_domain_build_info *b_info = &d_config->b_info; > > printf("(domain\n\t(domid %d)\n", domid); > - printf("\t(domain_create_info)\n"); > + printf("\t(create_info)\n"); > printf("\t(hvm %d)\n", c_info->hvm); > printf("\t(hap %d)\n", c_info->hap); > printf("\t(oos %d)\n", c_info->oos); > @@ -321,7 +321,7 @@ > printf("\t(platformdata (null))\n"); > > > - printf("\t(domain_build_info)\n"); > + printf("\t(build_info)\n"); > printf("\t(max_vcpus %d)\n", b_info->max_vcpus); > printf("\t(tsc_mode %d)\n", b_info->tsc_mode); > printf("\t(max_memkb %d)\n", b_info->max_memkb); > @@ -381,7 +381,7 @@ > printf("\t(device\n"); > printf("\t\t(tap\n"); > printf("\t\t\t(backend_domid %d)\n", > d_config->disks[i].backend_domid); > - printf("\t\t\t(domid %d)\n", domid); > + printf("\t\t\t(frontend_domid %d)\n", domid); > printf("\t\t\t(physpath %s)\n", d_config->disks[i].pdev_path); > printf("\t\t\t(phystype %d)\n", d_config->disks[i].backend); > printf("\t\t\t(virtpath %s)\n", d_config->disks[i].vdev); > @@ -396,7 +396,7 @@ > printf("\t(device\n"); > printf("\t\t(vif\n"); > printf("\t\t\t(backend_domid %d)\n", > d_config->vifs[i].backend_domid); > - printf("\t\t\t(domid %d)\n", domid); > + printf("\t\t\t(frontend_domid %d)\n", domid); > printf("\t\t\t(devid %d)\n", d_config->vifs[i].devid); > printf("\t\t\t(mtu %d)\n", d_config->vifs[i].mtu); > printf("\t\t\t(model %s)\n", d_config->vifs[i].model); > @@ -426,7 +426,7 @@ > printf("\t(device\n"); > printf("\t\t(vfb\n"); > printf("\t\t\t(backend_domid %d)\n", > d_config->vfbs[i].backend_domid); > - printf("\t\t\t(domid %d)\n", domid); > + printf("\t\t\t(frontend_domid %d)\n", domid); > printf("\t\t\t(devid %d)\n", d_config->vfbs[i].devid); > printf("\t\t\t(vnc %d)\n", d_config->vfbs[i].vnc); > printf("\t\t\t(vnclisten %s)\n", d_config->vfbs[i].vnclisten); >_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Carsten Schiers
2011-May-27 08:58 UTC
AW: Re: AW: [Xen-devel] Possible Compatibility Bug in xl create
After some analysis, I have to say it''s - a bug because -w option isn''t recognized - but also a missing implementation of the --wait long option - it''s also called with --halt option, which is ignored. I cannot promise to fix it, nevertheless I will try. But I never used this getopt stuff. BR, Carsten. ----- Originalnachricht ----- Von: Ian Jackson <Ian.Jackson@eu.citrix.com> Gesendet: Don, 26.5.2011 16:31 An: Carsten Schiers <carsten@schiers.de> Cc: Ian.Campbell <Ian.Campbell@eu.citrix.com> ; xen-devel <xen-devel@lists.xensource.com> ; Stefano.Stabellini <Stefano.Stabellini@eu.citrix.com> ; fantonifabio <fantonifabio@tiscali.it> Betreff: AW: Re: AW: [Xen-devel] Possible Compatibility Bug in xl create Carsten Schiers writes ("AW: Re: AW: [Xen-devel] Possible Compatibility Bug in xl create"):> OK, last message for today ;o). > > --wait option of xl will not wait for domain to have shut down.This is a bug. Ian. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Ian Jackson
2011-Jun-02 16:29 UTC
Re: [Xen-devel] [PATCH 1 of 2] xl: improve compatibility with xm
Carsten Schiers writes ("[Xen-devel] [PATCH 1 of 2] xl: improve compatibility with xm"):> - printf("\t(domain_build_info)\n"); > + printf("\t(build_info)\n");...> printf("\t\t\t(backend_domid %d)\n", > d_config->disks[i].backend_domid);This patch has been wordwrapped by your mailer. Can you please arrange for it not to be ? Thanks, Ian. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Stefano Stabellini
2011-Jun-02 16:45 UTC
Re: [Xen-devel] [PATCH 1 of 2] xl: improve compatibility with xm
On Thu, 2 Jun 2011, Ian Jackson wrote:> Carsten Schiers writes ("[Xen-devel] [PATCH 1 of 2] xl: improve compatibility with xm"): > > - printf("\t(domain_build_info)\n"); > > + printf("\t(build_info)\n"); > ... > > printf("\t\t\t(backend_domid %d)\n", > > d_config->disks[i].backend_domid); > > This patch has been wordwrapped by your mailer. Can you please > arrange for it not to be ?see Documentation/email-clients.txt under the Linux tree _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Ian Jackson
2011-Jun-02 16:58 UTC
Re: [Xen-devel] [PATCH 1 of 2] xl: improve compatibility with xm
Stefano Stabellini writes ("Re: [Xen-devel] [PATCH 1 of 2] xl: improve compatibility with xm"):> On Thu, 2 Jun 2011, Ian Jackson wrote: > > This patch has been wordwrapped by your mailer. Can you please > > arrange for it not to be ? > > see Documentation/email-clients.txt under the Linux treeThanks for the reference. Ian. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Carsten Schiers
2011-Jun-03 06:43 UTC
AW: Re: [Xen-devel] [PATCH 1 of 2] xl: improve compatibility with xm
Sorry folks, I tried to resent, but then, I saw that I was only in CC of the mail, so I did not do anything wrong ?!? BR, C. -----Ursprüngliche Nachricht----- Von: Stefano Stabellini [mailto:stefano.stabellini@eu.citrix.com] Gesendet: Donnerstag, 2. Juni 2011 18:46 An: Ian Jackson Cc: Ian Campbell; xen-devel; Carsten Schiers; Stefano Stabellini Betreff: Re: [Xen-devel] [PATCH 1 of 2] xl: improve compatibility with xm On Thu, 2 Jun 2011, Ian Jackson wrote:> Carsten Schiers writes ("[Xen-devel] [PATCH 1 of 2] xl: improvecompatibility with xm"):> > - printf("\t(domain_build_info)\n"); > > + printf("\t(build_info)\n"); > ... > > printf("\t\t\t(backend_domid %d)\n", > > d_config->disks[i].backend_domid); > > This patch has been wordwrapped by your mailer. Can you please > arrange for it not to be ?see Documentation/email-clients.txt under the Linux tree _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Ian Campbell
2011-Jun-03 06:55 UTC
Re: AW: Re: [Xen-devel] [PATCH 1 of 2] xl: improve compatibility with xm
On Fri, 2011-06-03 at 07:43 +0100, Carsten Schiers wrote:> Sorry folks, I tried to resent, but then, I saw that I was only in CC of > the mail, so I did not do anything wrong ?!? BR, C.IanJ''s original comment about word wrapping was To: you so I think resending was the right thing to do. The Cc: you got below is Stefano''s response to IanJ''s mail, it was aimed at you but To: Ian only because that''s what the Reply button does. (BTW, just curious, what does "BR" mean?) Ian.> -----Ursprüngliche Nachricht----- > Von: Stefano Stabellini [mailto:stefano.stabellini@eu.citrix.com] > Gesendet: Donnerstag, 2. Juni 2011 18:46 > An: Ian Jackson > Cc: Ian Campbell; xen-devel; Carsten Schiers; Stefano Stabellini > Betreff: Re: [Xen-devel] [PATCH 1 of 2] xl: improve compatibility with > xm > > On Thu, 2 Jun 2011, Ian Jackson wrote: > > Carsten Schiers writes ("[Xen-devel] [PATCH 1 of 2] xl: improve > compatibility with xm"): > > > - printf("\t(domain_build_info)\n"); > > > + printf("\t(build_info)\n"); > > ... > > > printf("\t\t\t(backend_domid %d)\n", > > > d_config->disks[i].backend_domid); > > > > This patch has been wordwrapped by your mailer. Can you please > > arrange for it not to be ? > > see Documentation/email-clients.txt under the Linux tree > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel > >_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Juergen Gotteswinter
2011-Jul-11 15:58 UTC
Re: [Xen-users] Re: [Xen-devel] RHEL6 xen and dom0 kernel to test
Am 23.05.11 21:16, schrieb Pasi Kärkkäinen:> On Fri, May 20, 2011 at 10:27:02PM +0100, M A Young wrote: >> I have been working on xen and dom0 kernel packages for RHEL6 and they >> are now at the stage where they are suitable for wider testing. >> > > Nice! Thanks a lot for this work! > >> There are xen 4.1 RPMs at http://xenbits.xen.org/people/mayoung/EL6.xen/ >> which are simply the Fedora 15 package recompiled for RHEL6. >> >> The dom0 kernel packages are at >> http://xenbits.xen.org/people/mayoung/testing/ and are basically the >> 2.6.32-71.29.1.el6 kernel with the addition of xen specific patches from >> Jeremy''s xen/stable-2.6.32.x branch at the 2.6.32.39 merge, and a few >> code and configuration changes to get it to build. It isn''t ABI >> compatible with true RHEL6 kernels because of the changes. It should set >> up grub correctly for a dom0 boot if the hypervisor is present (though I >> suggest you check the grub.conf file until it is better tested). >> >> Let me know if you see any problems. >> > > I hope I get to test them soon. I''ll let you know how it goes. > > -- Pasi > > > _______________________________________________ > Xen-users mailing list > Xen-users@lists.xensource.com > http://lists.xensource.com/xen-usersare there any experiences yet if this can be considered stable? cheers, juergen _______________________________________________ Xen-users mailing list Xen-users@lists.xensource.com http://lists.xensource.com/xen-users
On Fri, May 20, 2011 at 10:27:02PM +0100, M A Young wrote:> I have been working on xen and dom0 kernel packages for RHEL6 and they > are now at the stage where they are suitable for wider testing. > > There are xen 4.1 RPMs at http://xenbits.xen.org/people/mayoung/EL6.xen/ > which are simply the Fedora 15 package recompiled for RHEL6. > > The dom0 kernel packages are at > http://xenbits.xen.org/people/mayoung/testing/ and are basically the > 2.6.32-71.29.1.el6 kernel with the addition of xen specific patches from > Jeremy''s xen/stable-2.6.32.x branch at the 2.6.32.39 merge, and a few > code and configuration changes to get it to build. It isn''t ABI > compatible with true RHEL6 kernels because of the changes. It should set > up grub correctly for a dom0 boot if the hypervisor is present (though I > suggest you check the grub.conf file until it is better tested). > > Let me know if you see any problems. >Hey, Do you have plans to rebase to the rhel 6.1 kernel? CentOS guys were also asking that they''d like to import the rpms to centosplus repositories.. what do you think of that? btw. This patch should be included in the dom0 kernel rpms, it''s not yet in xen/stable-2.6.32.x branch: http://lists.xensource.com/archives/html/xen-devel/2011-06/msg00850.html And the instructions how to apply the patch: http://lists.xensource.com/archives/html/xen-devel/2011-06/msg01729.html -- Pasi _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Pasi, I would guess "howto" bellow might reduce pain, which causes in meantime Xen 4.1 on Ubuntu 11.10 (3.0.0.6-generic) . http://bderzhavets.wordpress.com/2011/07/23/build-xen-4-1-1-on-ubuntu-11-10/ Thanks. Boris. _______________________________________________ Xen-users mailing list Xen-users@lists.xensource.com http://lists.xensource.com/xen-users
On Mon, Jul 25, 2011 at 09:52:12AM -0700, Boris Derzhavets wrote:> Pasi, > > I would guess "howto" bellow might reduce pain, which causes in meantime > Xen 4.1 on Ubuntu 11.10 (3.0.0.6-generic) . > > http://bderzhavets.wordpress.com/2011/07/23/build-xen-4-1-1-on-ubuntu-11-10/ >Boris: Great, thanks! -- Pasi _______________________________________________ Xen-users mailing list Xen-users@lists.xensource.com http://lists.xensource.com/xen-users
Juergen Gotteswinter
2011-Jul-29 14:01 UTC
Re: [Xen-users] RHEL6 xen and dom0 kernel to test
Am 20.05.11 23:27, schrieb M A Young:> I have been working on xen and dom0 kernel packages for RHEL6 and they > are now at the stage where they are suitable for wider testing. > > There are xen 4.1 RPMs at http://xenbits.xen.org/people/mayoung/EL6.xen/ > which are simply the Fedora 15 package recompiled for RHEL6. > > The dom0 kernel packages are at > http://xenbits.xen.org/people/mayoung/testing/ and are basically the > 2.6.32-71.29.1.el6 kernel with the addition of xen specific patches from > Jeremy''s xen/stable-2.6.32.x branch at the 2.6.32.39 merge, and a few > code and configuration changes to get it to build. It isn''t ABI > compatible with true RHEL6 kernels because of the changes. It should set > up grub correctly for a dom0 boot if the hypervisor is present (though I > suggest you check the grub.conf file until it is better tested). > > Let me know if you see any problems. > > Michael Young > > _______________________________________________ > Xen-users mailing list > Xen-users@lists.xensource.com > http://lists.xensource.com/xen-usersWorks fine for me so far, no issues at all. Using it on SL6 _______________________________________________ Xen-users mailing list Xen-users@lists.xensource.com http://lists.xensource.com/xen-users
InterNetX - Juergen Gotteswinter
2011-Jul-31 20:31 UTC
Re: [Xen-users] RHEL6 xen and dom0 kernel to test
Juergen Gotteswinter <jg@internetx.de> hat am 29. Juli 2011 um 16:01 geschrieben:> Am 20.05.11 23:27, schrieb M A Young: > > I have been working on xen and dom0 kernel packages for RHEL6 and they > > are now at the stage where they are suitable for wider testing. > > > > There are xen 4.1 RPMs at http://xenbits.xen.org/people/mayoung/EL6.xen/ > > which are simply the Fedora 15 package recompiled for RHEL6. > > > > The dom0 kernel packages are at > > http://xenbits.xen.org/people/mayoung/testing/ and are basically the > > 2.6.32-71.29.1.el6 kernel with the addition of xen specific patches from > > Jeremy''s xen/stable-2.6.32.x branch at the 2.6.32.39 merge, and a few > > code and configuration changes to get it to build. It isn''t ABI > > compatible with true RHEL6 kernels because of the changes. It should set > > up grub correctly for a dom0 boot if the hypervisor is present (though I > > suggest you check the grub.conf file until it is better tested). > > > > Let me know if you see any problems. > > > > Michael Young > > > > _______________________________________________ > > Xen-users mailing list > > Xen-users@lists.xensource.com > > http://lists.xensource.com/xen-users > > Works fine for me so far, no issues at all. Using it on SL6 > > _______________________________________________ > Xen-users mailing list > Xen-users@lists.xensource.com > http://lists.xensource.com/xen-usersHi, works fine so far, but when i try to compile drbd against this xen / kernel pacakges this errors show up: /usr/src/kernels/2.6.32-71.29.1.el6.xendom0.x86_64/arch/x86/include/asm/io.h:10:21: error: error: xen/xen.h: No such file or directoryxen/xen.h: No such file or directory In file included from include/linux/scatterlist.h:8, from include/linux/dma-mapping.h:7, from include/linux/dmaengine.h:26, from include/linux/skbuff.h:30, from include/linux/if_ether.h:124, from include/linux/netdevice.h:29, from include/net/sock.h:50, from include/linux/connector.h:80, from /root/rpmbuild/BUILD/drbd-8.3.10/drbd/linux/drbd.h:28, from /root/rpmbuild/BUILD/drbd-8.3.10/drbd/drbd_worker.c:28:/usr/src/kernels/2.6.32-71.29.1.el6.xendom0.x86_64/arch/x86/include/asm/io.h:10:21: error: xen/xen.h: No such file or directorymake[3]: *** [/root/rpmbuild/BUILD/drbd-8.3.10/drbd/drbd_buildtag.o] Error 1make[3]: *** Waiting for unfinished jobs....make[3]: *** [/root/rpmbuild/BUILD/drbd-8.3.10/drbd/drbd_proc.o] Error 1make[3]: *** [/root/rpmbuild/BUILD/drbd-8.3.10/drbd/drbd_bitmap.o] Error 1make[3]: *** [/root/rpmbuild/BUILD/drbd-8.3.10/drbd/drbd_worker.o] Error 1make[2]: *** [_module_/root/rpmbuild/BUILD/drbd-8.3.10/drbd] Error 2make[2]: Leaving directory `/usr/src/kernels/2.6.32-71.29.1.el6.xendom0.x86_64''make[1]: *** [kbuild] Error 2make[1]: Leaving directory `/root/rpmbuild/BUILD/drbd-8.3.10/drbd''make: *** [module] Error 2error: Bad exit status from /var/tmp/rpm-tmp.XO5eV5 (%build) and so on... development rpms are all installed. any ideas how to fix this? cheers, juergen _______________________________________________ Xen-users mailing list Xen-users@lists.xensource.com http://lists.xensource.com/xen-users