Ian Campbell
2011-Apr-14 08:46 UTC
[Xen-devel] [PATCH] tools: libxl: do not specify protocol node for disk or net
# HG changeset patch
# User Ian Campbell <ian.campbell@citrix.com>
# Date 1302769033 -3600
# Node ID 139f34d06ec322faf6054f4acb983efa4ee4b0e7
# Parent 8877c9fab89d05b551c2f104cf498008081a1b98
tools: libxl: do not specify protocol node for disk or net
This node is written by the front/backends as part of their negotiation about
how to speak to each other. The toolstack has no part in this and it certainly
shouldn''t be hardcoding the 32 bit protocol!
Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
diff -r 8877c9fab89d -r 139f34d06ec3 tools/libxl/libxl.c
--- a/tools/libxl/libxl.c Thu Apr 14 09:17:13 2011 +0100
+++ b/tools/libxl/libxl.c Thu Apr 14 09:17:13 2011 +0100
@@ -1060,11 +1060,6 @@ int libxl_device_disk_add(libxl_ctx *ctx
flexarray_append(front, "device-type");
flexarray_append(front, disk->is_cdrom ? "cdrom" :
"disk");
- if (0 /* protocol != native*/) {
- flexarray_append(front, "protocol");
- flexarray_append(front, "x86_32-abi"); /* hardcoded ! */
- }
-
libxl__device_generic_add(&gc, &device,
libxl__xs_kvs_of_flexarray(&gc, back,
back->count),
libxl__xs_kvs_of_flexarray(&gc, front,
front->count));
@@ -1304,11 +1299,6 @@ int libxl_device_nic_add(libxl_ctx *ctx,
flexarray_append(front, libxl__sprintf(&gc,
"%02x:%02x:%02x:%02x:%02x:%02x",
nic->mac[0],
nic->mac[1], nic->mac[2],
nic->mac[3],
nic->mac[4], nic->mac[5]));
- if (0 /* protocol != native*/) {
- flexarray_append(front, "protocol");
- flexarray_append(front, "x86_32-abi"); /* hardcoded ! */
- }
-
libxl__device_generic_add(&gc, &device,
libxl__xs_kvs_of_flexarray(&gc, back,
back->count),
libxl__xs_kvs_of_flexarray(&gc, front,
front->count));
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel