Shriram Rajagopalan
2011-Apr-11 17:58 UTC
[Xen-devel] [PATCH] remus: fix incorrect error handling for switch_qemu_logdirty in checkpoint code
# HG changeset patch # User Shriram Rajagopalan <rshriram@cs.ubc.ca> # Date 1302544427 25200 # Node ID fefe3359ab726e634c00704eadeacfcf30b70c07 # Parent 697ac895c11c6d5d82524de56796cee98fded2a5 remus: fix incorrect error handling for switch_qemu_logdirty in checkpoint code c/s 22275: "tools: cleanup domain save switch_qemu_logdirty callback" introduced a whole bunch of error code fixups. In the process, it also ended up treating the success return code (0) from switch_qemu_logdirty as an error and vice versa. Signed-off-by: Shriram Rajagopalan <rshriram@cs.ubc.ca> diff -r 697ac895c11c -r fefe3359ab72 tools/python/xen/lowlevel/checkpoint/libcheckpoint.c --- a/tools/python/xen/lowlevel/checkpoint/libcheckpoint.c Sat Apr 09 12:42:24 2011 +0100 +++ b/tools/python/xen/lowlevel/checkpoint/libcheckpoint.c Mon Apr 11 10:53:47 2011 -0700 @@ -185,7 +185,7 @@ hvm = s->domtype > dt_pv; if (hvm) { flags |= XCFLAGS_HVM; - if (!switch_qemu_logdirty(s, 1)) + if (switch_qemu_logdirty(s, 1)) return -1; } _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Maybe Matching Threads
- [PATCH 0 of 3] Support for VM generation ID save/restore and migrate
- how to change checkpoint interval
- [PATCH 0 of 4] Support for VM generation ID save/restore and migrate
- [PATCH 0 of 2] Support for VM generation ID save/restore and migrate
- [PATCH 0 of 6] Add support for a VM generation ID virtual device (v2)