Christoph Egger
2011-Apr-06 14:32 UTC
[Xen-devel] [PATCH] xen: fix hypervisor crash with xentrace
Hi, Attached patch fixes hypervisor crashes when xentrace buffer gets initialized. The xen backtraces I have seen are: (XEN) Xen call trace: (XEN) [<ffff82c48025cf70>] early_stack+0x0/0x48 (XEN) [<ffff82c4801278d0>] tb_control+0x182/0x278 (XEN) [<ffff82c480124aac>] do_sysctl+0x1fc/0xa40 (XEN) [<ffff82c480213248>] syscall_enter+0xc8/0x122 (XEN) (XEN) Pagetable walk from ffff82c48025cf70: (XEN) L4[0x105] = 00000000cfcaa027 5555555555555555 (XEN) L3[0x112] = 00000000cfcab027 5555555555555555 (XEN) L2[0x001] = 000000022f27b063 5555555555555555 (XEN) L1[0x05c] = 00000000cfc5c262 5555555555555555 (XEN) (XEN) **************************************** (XEN) Panic on CPU 0: (XEN) FATAL PAGE FAULT (XEN) [error_code=0010] (XEN) Faulting linear address: ffff82c48025cf70 (XEN) **************************************** (XEN) Xen call trace: (XEN) [<ffff82c48025d852>] notifier_chain_register+0x0/0x35 (XEN) [<ffff82c4801275b2>] alloc_trace_bufs+0x5cd/0x7a9 (XEN) [<ffff82c480127910>] tb_control+0x182/0x278 (XEN) [<ffff82c480124aec>] do_sysctl+0x1fc/0xa40 (XEN) [<ffff82c480213288>] syscall_enter+0xc8/0x122 (XEN) (XEN) Pagetable walk from ffff82c48025d852: (XEN) L4[0x105] = 00000000cfcaa027 5555555555555555 (XEN) L3[0x112] = 00000000cfcab027 5555555555555555 (XEN) L2[0x001] = 000000022f27b063 5555555555555555 (XEN) L1[0x05d] = 00000000cfc5d262 5555555555555555 (XEN) (XEN) **************************************** (XEN) Panic on CPU 1: (XEN) FATAL PAGE FAULT (XEN) [error_code=0010] (XEN) Faulting linear address: ffff82c48025d852 (XEN) **************************************** Signed-off-by: Christoph Egger <Christoph.Egger@amd.com> -- ---to satisfy European Law for business letters: Advanced Micro Devices GmbH Einsteinring 24, 85609 Dornach b. Muenchen Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Christoph Egger
2011-Apr-06 14:36 UTC
Re: [Xen-devel] [PATCH] xen: fix hypervisor crash with xentrace
On 04/06/11 16:32, Christoph Egger wrote:> > Hi, > > Attached patch fixes hypervisor crashes when xentrace buffer gets initialized.Forgot to mention this regression was introduced in c/s 23134:f5d33782a57b by Jan Beulich.> > The xen backtraces I have seen are: > > (XEN) Xen call trace: > (XEN) [<ffff82c48025cf70>] early_stack+0x0/0x48 > (XEN) [<ffff82c4801278d0>] tb_control+0x182/0x278 > (XEN) [<ffff82c480124aac>] do_sysctl+0x1fc/0xa40 > (XEN) [<ffff82c480213248>] syscall_enter+0xc8/0x122 > (XEN) > (XEN) Pagetable walk from ffff82c48025cf70: > (XEN) L4[0x105] = 00000000cfcaa027 5555555555555555 > (XEN) L3[0x112] = 00000000cfcab027 5555555555555555 > (XEN) L2[0x001] = 000000022f27b063 5555555555555555 > (XEN) L1[0x05c] = 00000000cfc5c262 5555555555555555 > (XEN) > (XEN) **************************************** > (XEN) Panic on CPU 0: > (XEN) FATAL PAGE FAULT > (XEN) [error_code=0010] > (XEN) Faulting linear address: ffff82c48025cf70 > (XEN) **************************************** > > > (XEN) Xen call trace: > (XEN) [<ffff82c48025d852>] notifier_chain_register+0x0/0x35 > (XEN) [<ffff82c4801275b2>] alloc_trace_bufs+0x5cd/0x7a9 > (XEN) [<ffff82c480127910>] tb_control+0x182/0x278 > (XEN) [<ffff82c480124aec>] do_sysctl+0x1fc/0xa40 > (XEN) [<ffff82c480213288>] syscall_enter+0xc8/0x122 > (XEN) > (XEN) Pagetable walk from ffff82c48025d852: > (XEN) L4[0x105] = 00000000cfcaa027 5555555555555555 > (XEN) L3[0x112] = 00000000cfcab027 5555555555555555 > (XEN) L2[0x001] = 000000022f27b063 5555555555555555 > (XEN) L1[0x05d] = 00000000cfc5d262 5555555555555555 > (XEN) > (XEN) **************************************** > (XEN) Panic on CPU 1: > (XEN) FATAL PAGE FAULT > (XEN) [error_code=0010] > (XEN) Faulting linear address: ffff82c48025d852 > (XEN) **************************************** > > > Signed-off-by: Christoph Egger<Christoph.Egger@amd.com> > >-- ---to satisfy European Law for business letters: Advanced Micro Devices GmbH Einsteinring 24, 85689 Dornach b. Muenchen Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2011-Apr-06 14:54 UTC
Re: [Xen-devel] [PATCH] xen: fix hypervisor crash with xentrace
On 06/04/2011 15:32, "Christoph Egger" <Christoph.Egger@amd.com> wrote:> > Hi, > > Attached patch fixes hypervisor crashes when xentrace buffer gets initialized.Should be fixed by c/s 23173. Thanks! -- Keir> The xen backtraces I have seen are: > > (XEN) Xen call trace: > (XEN) [<ffff82c48025cf70>] early_stack+0x0/0x48 > (XEN) [<ffff82c4801278d0>] tb_control+0x182/0x278 > (XEN) [<ffff82c480124aac>] do_sysctl+0x1fc/0xa40 > (XEN) [<ffff82c480213248>] syscall_enter+0xc8/0x122 > (XEN) > (XEN) Pagetable walk from ffff82c48025cf70: > (XEN) L4[0x105] = 00000000cfcaa027 5555555555555555 > (XEN) L3[0x112] = 00000000cfcab027 5555555555555555 > (XEN) L2[0x001] = 000000022f27b063 5555555555555555 > (XEN) L1[0x05c] = 00000000cfc5c262 5555555555555555 > (XEN) > (XEN) **************************************** > (XEN) Panic on CPU 0: > (XEN) FATAL PAGE FAULT > (XEN) [error_code=0010] > (XEN) Faulting linear address: ffff82c48025cf70 > (XEN) **************************************** > > > (XEN) Xen call trace: > (XEN) [<ffff82c48025d852>] notifier_chain_register+0x0/0x35 > (XEN) [<ffff82c4801275b2>] alloc_trace_bufs+0x5cd/0x7a9 > (XEN) [<ffff82c480127910>] tb_control+0x182/0x278 > (XEN) [<ffff82c480124aec>] do_sysctl+0x1fc/0xa40 > (XEN) [<ffff82c480213288>] syscall_enter+0xc8/0x122 > (XEN) > (XEN) Pagetable walk from ffff82c48025d852: > (XEN) L4[0x105] = 00000000cfcaa027 5555555555555555 > (XEN) L3[0x112] = 00000000cfcab027 5555555555555555 > (XEN) L2[0x001] = 000000022f27b063 5555555555555555 > (XEN) L1[0x05d] = 00000000cfc5d262 5555555555555555 > (XEN) > (XEN) **************************************** > (XEN) Panic on CPU 1: > (XEN) FATAL PAGE FAULT > (XEN) [error_code=0010] > (XEN) Faulting linear address: ffff82c48025d852 > (XEN) **************************************** > > > Signed-off-by: Christoph Egger <Christoph.Egger@amd.com> >_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Jan Beulich
2011-Apr-06 15:01 UTC
Re: [Xen-devel] [PATCH] xen: fix hypervisor crash with xentrace
>>> On 06.04.11 at 16:36, Christoph Egger <Christoph.Egger@amd.com> wrote: > On 04/06/11 16:32, Christoph Egger wrote: >> >> Hi, >> >> Attached patch fixes hypervisor crashes when xentrace buffer gets > initialized. > > Forgot to mention this regression was introduced in c/s > 23134:f5d33782a57b by Jan Beulich.But just removing the __init-s isn''t the right way to fix this (Did you notice the comment in register_cpu_notifier(), which I also pointed out in the changeset description). Apparently I overlooked a call to register_cpu_notifier(), and it''s that which ought to get moved into an __init function. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Jan Beulich
2011-Apr-06 15:03 UTC
Re: [Xen-devel] [PATCH] xen: fix hypervisor crash with xentrace
>>> On 06.04.11 at 16:32, Christoph Egger <Christoph.Egger@amd.com> wrote: > Attached patch fixes hypervisor crashes when xentrace buffer gets > initialized.Just saw that Keir already fixed this the proper way as c/s 23173:94cef9aaf0cd. Thanks, Keir! Jan> The xen backtraces I have seen are: > > (XEN) Xen call trace: > (XEN) [<ffff82c48025cf70>] early_stack+0x0/0x48 > (XEN) [<ffff82c4801278d0>] tb_control+0x182/0x278 > (XEN) [<ffff82c480124aac>] do_sysctl+0x1fc/0xa40 > (XEN) [<ffff82c480213248>] syscall_enter+0xc8/0x122 > (XEN) > (XEN) Pagetable walk from ffff82c48025cf70: > (XEN) L4[0x105] = 00000000cfcaa027 5555555555555555 > (XEN) L3[0x112] = 00000000cfcab027 5555555555555555 > (XEN) L2[0x001] = 000000022f27b063 5555555555555555 > (XEN) L1[0x05c] = 00000000cfc5c262 5555555555555555 > (XEN) > (XEN) **************************************** > (XEN) Panic on CPU 0: > (XEN) FATAL PAGE FAULT > (XEN) [error_code=0010] > (XEN) Faulting linear address: ffff82c48025cf70 > (XEN) **************************************** > > > (XEN) Xen call trace: > (XEN) [<ffff82c48025d852>] notifier_chain_register+0x0/0x35 > (XEN) [<ffff82c4801275b2>] alloc_trace_bufs+0x5cd/0x7a9 > (XEN) [<ffff82c480127910>] tb_control+0x182/0x278 > (XEN) [<ffff82c480124aec>] do_sysctl+0x1fc/0xa40 > (XEN) [<ffff82c480213288>] syscall_enter+0xc8/0x122 > (XEN) > (XEN) Pagetable walk from ffff82c48025d852: > (XEN) L4[0x105] = 00000000cfcaa027 5555555555555555 > (XEN) L3[0x112] = 00000000cfcab027 5555555555555555 > (XEN) L2[0x001] = 000000022f27b063 5555555555555555 > (XEN) L1[0x05d] = 00000000cfc5d262 5555555555555555 > (XEN) > (XEN) **************************************** > (XEN) Panic on CPU 1: > (XEN) FATAL PAGE FAULT > (XEN) [error_code=0010] > (XEN) Faulting linear address: ffff82c48025d852 > (XEN) **************************************** > > > Signed-off-by: Christoph Egger <Christoph.Egger@amd.com> >_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel