xl tools stack currently do not have pci passthrough filtering logic we have in xm for such things as whether the passthrough device belongs to pciback or pci-stub driver, PCI BAR 4KB page size alignment, ACS support in PCIe switches, etc ... Do you have plans to add this logic in libxl for Xen 4.1.1 release? Allen _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Stefano Stabellini
2011-Mar-31 15:57 UTC
[Xen-devel] Re: pci passthrough filtering in libxl
On Thu, 31 Mar 2011, Kay, Allen M wrote:> xl tools stack currently do not have pci passthrough filtering logic we have in xm for such things as whether the passthrough device belongs to pciback or pci-stub driver, PCI BAR 4KB page size alignment, ACS support in PCIe switches, etc ... > > Do you have plans to add this logic in libxl for Xen 4.1.1 release?We don''t a plan to do it in the immediate future but we would gladly accept patches :-) _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
I have submitted a patch for checking for pciback but I have not seen it checked in yet. -----Original Message----- From: Stefano Stabellini [mailto:stefano.stabellini@eu.citrix.com] Sent: Thursday, March 31, 2011 8:57 AM To: Kay, Allen M Cc: Stefano Stabellini; Gianni Tedesco; Ian Campbell; Ian Jackson; xen-devel@lists.xensource.com; Keir Fraser Subject: Re: pci passthrough filtering in libxl On Thu, 31 Mar 2011, Kay, Allen M wrote:> xl tools stack currently do not have pci passthrough filtering logic we have in xm for such things as whether the passthrough device belongs to pciback or pci-stub driver, PCI BAR 4KB page size alignment, ACS support in PCIe switches, etc ... > > Do you have plans to add this logic in libxl for Xen 4.1.1 release?We don''t a plan to do it in the immediate future but we would gladly accept patches :-) _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Stefano Stabellini
2011-Mar-31 16:12 UTC
[Xen-devel] RE: pci passthrough filtering in libxl
On Thu, 31 Mar 2011, Kay, Allen M wrote:> I have submitted a patch for checking for pciback but I have not seen it checked in yet.Ian is bit behind with patches at the moment... _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Kay, Allen M writes ("RE: pci passthrough filtering in libxl"):> I have submitted a patch for checking for pciback but I have not seen it checked in yet.I seem to have overlooked that one; at least, it''s not in my inbox marked as outstanding. Sorry. Can you repost it please ? Thanks, Ian. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Here it is: Checks to make sure passthrough device is bound to pciback before given it to the guest. Signed-off-by: Allen Kay <allen.m.kay@intel.com> -----Original Message----- From: Ian Jackson [mailto:Ian.Jackson@eu.citrix.com] Sent: Thursday, March 31, 2011 11:18 AM To: Kay, Allen M Cc: Stefano Stabellini; Gianni Tedesco; Ian Campbell; xen-devel@lists.xensource.com; Keir Fraser Subject: RE: pci passthrough filtering in libxl Kay, Allen M writes ("RE: pci passthrough filtering in libxl"):> I have submitted a patch for checking for pciback but I have not seen it checked in yet.I seem to have overlooked that one; at least, it''s not in my inbox marked as outstanding. Sorry. Can you repost it please ? Thanks, Ian. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Kay, Allen M writes ("RE: pci passthrough filtering in libxl"):> Checks to make sure passthrough device is bound to pciback before given it to the guest.Thanks, that looks reasonable to me. Unfortunately it doesn''t now apply to xen-unstable tip: patching file tools/libxl/libxl_pci.c Hunk #1 FAILED at 764. Hunk #2 succeeded at 779 with fuzz 2 (offset -10 lines). 1 out of 2 hunks FAILED -- saving rejects to file tools/libxl/libxl_pci.c.rej There''s been a lot of stuff going into tools/libxl recently and there''s more big patches outstanding. Could you perhaps wait a week or so and then refresh the patch and repost it ? Thanks, Ian. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel