Ian Jackson
2011-Mar-23 15:52 UTC
[Xen-devel] Re: [PATCH 25 of 30] libxl: move libxl_doimid_valid_guest out of line
Ian Campbell writes ("[PATCH 25 of 30] libxl: move libxl_doimid_valid_guest
out of line"):> libxl: move libxl_doimid_valid_guest out of line
Why ?
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
Ian Campbell
2011-Mar-23 15:59 UTC
[Xen-devel] Re: [PATCH 25 of 30] libxl: move libxl_doimid_valid_guest out of line
On Wed, 2011-03-23 at 15:52 +0000, Ian Jackson wrote:> Ian Campbell writes ("[PATCH 25 of 30] libxl: move libxl_doimid_valid_guest out of line"): > > libxl: move libxl_doimid_valid_guest out of line > > Why ?Why should it be inline? What actually led to the changes was that a subsequent patch removed the indirect dependency which defined DOMID_FIRST_RESERVED. Rather than finding and adding the appropriate xen header to libxl.h (which is a valid option) I decided that the function shouldn''t have been inline in the first place... Ian. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Ian Jackson
2011-Mar-23 16:57 UTC
[Xen-devel] Re: [PATCH 25 of 30] libxl: move libxl_doimid_valid_guest out of line
Ian Campbell writes ("Re: [PATCH 25 of 30] libxl: move
libxl_doimid_valid_guest out of line"):> Why should it be inline?
In general, I think it''s fine to have trivial operations like this
inlined. Things which one would otherwise maybe use a macro for.
> What actually led to the changes was that a subsequent patch removed the
> indirect dependency which defined DOMID_FIRST_RESERVED. Rather than
> finding and adding the appropriate xen header to libxl.h (which is a
> valid option) I decided that the function shouldn''t have been
inline in
> the first place...
I think it''s fine to import Xen headers into libxl.h.
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
Ian Campbell
2011-Mar-24 14:28 UTC
[Xen-devel] Re: [PATCH 25 of 30] libxl: move libxl_doimid_valid_guest out of line
On Wed, 2011-03-23 at 16:57 +0000, Ian Jackson wrote:> Ian Campbell writes ("Re: [PATCH 25 of 30] libxl: move libxl_doimid_valid_guest out of line"): > > Why should it be inline? > > In general, I think it''s fine to have trivial operations like this > inlined. Things which one would otherwise maybe use a macro for. > > > What actually led to the changes was that a subsequent patch removed the > > indirect dependency which defined DOMID_FIRST_RESERVED. Rather than > > finding and adding the appropriate xen header to libxl.h (which is a > > valid option) I decided that the function shouldn''t have been inline in > > the first place... > > I think it''s fine to import Xen headers into libxl.h.In any case whatever it was which caused me to do this is not present in the final series I ended up sending and neither this patch nor any additional #includes are required AFAICT. Ian. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel