Ian Jackson
2011-Mar-23 15:40 UTC
[Xen-devel] Re: [PATCH 20 of 30] tools: ocaml: push CFLAGS usage down into the specific bindings
Ian Campbell writes ("[PATCH 20 of 30] tools: ocaml: push CFLAGS usage down
into the specific bindings"):> -
> -#ifndef xen_mb
> -#define xen_mb() mb()
> -#endif
This may be unneeded (I haven''t checked) but if so shouldn''t
it be
mentioned in the commit message ?
> -#xs.cmxa: $(foreach obj,$(OBJS),$(obj).cmx)
etc.
Also.
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
Ian Campbell
2011-Mar-23 15:50 UTC
[Xen-devel] Re: [PATCH 20 of 30] tools: ocaml: push CFLAGS usage down into the specific bindings
On Wed, 2011-03-23 at 15:40 +0000, Ian Jackson wrote:> Ian Campbell writes ("[PATCH 20 of 30] tools: ocaml: push CFLAGS usage down into the specific bindings"): > > - > > -#ifndef xen_mb > > -#define xen_mb() mb() > > -#endif > > This may be unneeded (I haven''t checked) but if so shouldn''t it be > mentioned in the commit message ? > > > -#xs.cmxa: $(foreach obj,$(OBJS),$(obj).cmx) > etc. > > Also.Sorry, they both should have been separate patches. I''ll wait till you''ve applied the bits you are going to apply and then resend the bits you didn''t. Ian. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel