By accident CONFIG_XEN got disabled in my .config. I noticed that in xen.git/drivers/acpi/Makefile processor_xen.o is compiled unconditionally. I think it should be processor-$(CONFIG_XEN) instead of processor-y because it references xen_pcpu_index(). Olaf _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Ian Jackson
2011-Mar-15 18:13 UTC
Re: [Xen-devel] processor_xen.o should depend on CONFIG_XEN
Olaf Hering writes ("[Xen-devel] processor_xen.o should depend on
CONFIG_XEN"):> By accident CONFIG_XEN got disabled in my .config. I noticed that in
> xen.git/drivers/acpi/Makefile processor_xen.o is compiled unconditionally.
> I think it should be processor-$(CONFIG_XEN) instead of processor-y
> because it references xen_pcpu_index().
Would you care to write a patch to this effect ?
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
Olaf Hering
2011-Mar-18 15:23 UTC
[Xen-devel] [PATCH] processor_xen.o should depend on CONFIG_XEN
processor_xen.c references symbols which are only availabe if CONFIG_XEN is enabled. Signed-off-by: Olaf Hering <olaf@aepfle.de> --- drivers/acpi/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux-2.6.32.32-0.2-pvops/drivers/acpi/Makefile ==================================================================--- linux-2.6.32.32-0.2-pvops.orig/drivers/acpi/Makefile +++ linux-2.6.32.32-0.2-pvops/drivers/acpi/Makefile @@ -61,7 +61,7 @@ obj-$(CONFIG_ACPI_POWER_METER) += power_ # processor has its own "processor." module_param namespace processor-y := processor_core.o processor_throttling.o processor-y += processor_idle.o processor_thermal.o -processor-y += processor_xen.o +processor-$(CONFIG_XEN) += processor_xen.o processor-$(CONFIG_CPU_FREQ) += processor_perflib.o obj-$(CONFIG_ACPI_PROCESSOR_AGGREGATOR) += acpi_pad.o _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Ian Jackson
2011-Mar-18 16:32 UTC
[Xen-devel] Re: [PATCH] processor_xen.o should depend on CONFIG_XEN
Olaf Hering writes ("[PATCH] processor_xen.o should depend on
CONFIG_XEN"):> processor_xen.c references symbols which are only availabe if CONFIG_XEN
> is enabled.
Thanks. This should be sent to linux-kernel and perhaps go in via the
Xen tree ?
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
Konrad Rzeszutek Wilk
2011-Mar-18 16:43 UTC
Re: [Xen-devel] [PATCH] processor_xen.o should depend on CONFIG_XEN
On Fri, Mar 18, 2011 at 04:23:33PM +0100, Olaf Hering wrote:> processor_xen.c references symbols which are only availabe if CONFIG_XEN > is enabled.Hehe. I saw this for 2.6.38 some time ago from Ian Campbell and promptly forgot. Now it comes up again. Will stick it on 2.6.39 bug-fix branch shortly.> > Signed-off-by: Olaf Hering <olaf@aepfle.de> > > --- > drivers/acpi/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > Index: linux-2.6.32.32-0.2-pvops/drivers/acpi/Makefile > ==================================================================> --- linux-2.6.32.32-0.2-pvops.orig/drivers/acpi/Makefile > +++ linux-2.6.32.32-0.2-pvops/drivers/acpi/Makefile > @@ -61,7 +61,7 @@ obj-$(CONFIG_ACPI_POWER_METER) += power_ > # processor has its own "processor." module_param namespace > processor-y := processor_core.o processor_throttling.o > processor-y += processor_idle.o processor_thermal.o > -processor-y += processor_xen.o > +processor-$(CONFIG_XEN) += processor_xen.o > processor-$(CONFIG_CPU_FREQ) += processor_perflib.o > > obj-$(CONFIG_ACPI_PROCESSOR_AGGREGATOR) += acpi_pad.o > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Olaf Hering
2011-Mar-18 17:20 UTC
Re: [Xen-devel] [PATCH] processor_xen.o should depend on CONFIG_XEN
On Fri, Mar 18, Konrad Rzeszutek Wilk wrote:> On Fri, Mar 18, 2011 at 04:23:33PM +0100, Olaf Hering wrote: > > processor_xen.c references symbols which are only availabe if CONFIG_XEN > > is enabled. > > Hehe. I saw this for 2.6.38 some time ago from Ian Campbell and promptly > forgot. Now it comes up again. Will stick it on 2.6.39 bug-fix branch shortly.Thats mainly for stable-2.6.32.x, if it applies to other trees too, fine with me. Olaf _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel