Jan Beulich
2011-Feb-23 11:24 UTC
[Xen-devel] [PATCH] amd-k8-mce: remove a stray break statement
This was a leftover of converting from a switch to an if/else somewhere between 3.4 and 4.0. It also looks suspicious that MCEQUIRK_K7_BANK0 is not actually used anywhere. Perhaps amd_k7_mcheck_init() and amd_k8_mcheck_init() were intended to get (partially) folded? Signed-off-by: Jan Beulich <jbeulich@novell.com> --- a/xen/arch/x86/cpu/mcheck/amd_k8.c +++ b/xen/arch/x86/cpu/mcheck/amd_k8.c @@ -92,7 +92,6 @@ enum mcheck_type amd_k8_mcheck_init(stru /* Enable error reporting of all errors */ wrmsrl(MSR_IA32_MCx_CTL(i), 0xffffffffffffffffULL); wrmsrl(MSR_IA32_MCx_STATUS(i), 0x0ULL); - break; } } _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2011-Feb-23 11:35 UTC
Re: [Xen-devel] [PATCH] amd-k8-mce: remove a stray break statement
On 23/02/2011 11:24, "Jan Beulich" <JBeulich@novell.com> wrote:> This was a leftover of converting from a switch to an if/else somewhere > between 3.4 and 4.0.So the patch is for 4.0-testing and unstable? -- Keir> It also looks suspicious that MCEQUIRK_K7_BANK0 is not actually used > anywhere. Perhaps amd_k7_mcheck_init() and amd_k8_mcheck_init() were > intended to get (partially) folded? > > Signed-off-by: Jan Beulich <jbeulich@novell.com> > > --- a/xen/arch/x86/cpu/mcheck/amd_k8.c > +++ b/xen/arch/x86/cpu/mcheck/amd_k8.c > @@ -92,7 +92,6 @@ enum mcheck_type amd_k8_mcheck_init(stru > /* Enable error reporting of all errors */ > wrmsrl(MSR_IA32_MCx_CTL(i), 0xffffffffffffffffULL); > wrmsrl(MSR_IA32_MCx_STATUS(i), 0x0ULL); > - break; > } > } > > > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Jan Beulich
2011-Feb-23 11:41 UTC
Re: [Xen-devel] [PATCH] amd-k8-mce: remove a stray break statement
>>> On 23.02.11 at 12:35, Keir Fraser <keir.xen@gmail.com> wrote: > On 23/02/2011 11:24, "Jan Beulich" <JBeulich@novell.com> wrote: > >> This was a leftover of converting from a switch to an if/else somewhere >> between 3.4 and 4.0. > > So the patch is for 4.0-testing and unstable?Yes, I tried to imply this with the above description. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel