Tim Deegan
2011-Feb-14 13:50 UTC
[Xen-devel] [PATCH] x86/mm: partially revert 21093:4a3e131f7498
p2m internals should always gate on whether HAP is enabled for the domain, not whether a HAP paging mode is currently advertised. This lets us revert the change to hap_enable() that advertises the new mode before it''s safe to use it. Signed-off-by: Tim Deegan <Tim.Deegan@citrix.com> _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Olaf Hering
2011-Feb-16 16:11 UTC
Re: [Xen-devel] [PATCH] x86/mm: partially revert 21093:4a3e131f7498
On Mon, Feb 14, Tim Deegan wrote:> diff -r af84691a6cf9 -r 20140bcb4c04 xen/arch/x86/mm/p2m.c > --- a/xen/arch/x86/mm/p2m.c Mon Feb 14 10:41:12 2011 +0000 > +++ b/xen/arch/x86/mm/p2m.c Mon Feb 14 13:40:32 2011 +0000> @@ -2314,7 +2313,7 @@ static int gfn_check_limit( > * hardware translation limit. This limitation is checked by comparing > * gfn with 0xfffffUL. > */ > - if ( !paging_mode_hap(d) || ((gfn + (1ul << order)) <= 0x100000UL) || > + if ( !hap_enabled(d) || ((gfn + (1ul << order)) <= 0x100000UL)This removes the || p2m.c: In function ''gfn_check_limit'': p2m.c:2317: error: called object ''(1ul << (int)order) + gfn <= 1048576ul'' is not a function make[4]: *** [p2m.o] Error 1 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel