Juergen Gross
2011-Feb-14 09:27 UTC
[Xen-devel] [PATCH] correct xl cpupool-create with extra parameters
xl cpupool-create won''t take always extra parameters specified on the command line, as a 0-byte is missing at the end of the configuration file contents. Signed-off-by: juergen.gross@ts.fujitsu.com 1 file changed, 6 insertions(+), 7 deletions(-) tools/libxl/xl_cmdimpl.c | 13 ++++++------- _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Ian Jackson
2011-Feb-14 16:55 UTC
Re: [Xen-devel] [PATCH] correct xl cpupool-create with extra parameters
Juergen Gross writes ("[Xen-devel] [PATCH] correct xl cpupool-create with
extra parameters"):> xl cpupool-create won''t take always extra parameters specified on
the command
> line, as a 0-byte is missing at the end of the configuration file contents.
Thanks, this looks right to me; I have applied it.
Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
Having said that, I think this approach (reallocing the config data
buffer and tacking the args on the end) is pretty nasty really. The
right thing would be probably call xlu_cfg_read* more than once.
Let''s not do that now, though.
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel