Gianni Tedesco
2011-Feb-11 15:42 UTC
[Xen-devel] [PATCH]: libxc: set all VCPU''s online by default in HVM info table
This sets a saner default for the cpu-online-map by setting all bits to
1. The default assumption ought to be that nr-vcpus =nr-vcpus-at-start. If that
is not true, then the toolstack must modify
the bitmap, but if it is true, the toolstack oughtn''t need to do
anything further.
Signed-off-by: Gianni Tedesco <gianni.tedesco@citrix.com>
diff -r a0662e3bedea tools/libxc/xc_hvm_build.c
--- a/tools/libxc/xc_hvm_build.c Fri Feb 11 14:28:14 2011 +0000
+++ b/tools/libxc/xc_hvm_build.c Fri Feb 11 14:39:47 2011 +0000
@@ -70,6 +70,7 @@ static void build_hvm_info(void *hvm_inf
hvm_info->acpi_enabled = 1;
hvm_info->apic_mode = 1;
hvm_info->nr_vcpus = 1;
+ memset(hvm_info->vcpu_online, 0xff, sizeof(hvm_info->vcpu_online));
/* Memory parameters. */
hvm_info->low_mem_pgend = lowmem_end >> PAGE_SHIFT;
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
Stefano Stabellini
2011-Feb-16 13:24 UTC
Re: [Xen-devel] [PATCH]: libxc: set all VCPU''s online by default in HVM info table
On Fri, 11 Feb 2011, Gianni Tedesco wrote:> This sets a saner default for the cpu-online-map by setting all bits to > 1. The default assumption ought to be that nr-vcpus => nr-vcpus-at-start. If that is not true, then the toolstack must modify > the bitmap, but if it is true, the toolstack oughtn''t need to do > anything further. > > Signed-off-by: Gianni Tedesco <gianni.tedesco@citrix.com> >Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>> diff -r a0662e3bedea tools/libxc/xc_hvm_build.c > --- a/tools/libxc/xc_hvm_build.c Fri Feb 11 14:28:14 2011 +0000 > +++ b/tools/libxc/xc_hvm_build.c Fri Feb 11 14:39:47 2011 +0000 > @@ -70,6 +70,7 @@ static void build_hvm_info(void *hvm_inf > hvm_info->acpi_enabled = 1; > hvm_info->apic_mode = 1; > hvm_info->nr_vcpus = 1; > + memset(hvm_info->vcpu_online, 0xff, sizeof(hvm_info->vcpu_online)); > > /* Memory parameters. */ > hvm_info->low_mem_pgend = lowmem_end >> PAGE_SHIFT; > > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel >_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
George Dunlap
2011-Apr-07 10:37 UTC
Re: [Xen-devel] [PATCH]: libxc: set all VCPU''s online by default in HVM info table
This patch seems to have been acked, but never actually applied. It''s probably still worth applying at least to -unstable. I''d consider backporting it to 4.1 as well... -George On Wed, Feb 16, 2011 at 1:24 PM, Stefano Stabellini <stefano.stabellini@eu.citrix.com> wrote:> On Fri, 11 Feb 2011, Gianni Tedesco wrote: >> This sets a saner default for the cpu-online-map by setting all bits to >> 1. The default assumption ought to be that nr-vcpus =>> nr-vcpus-at-start. If that is not true, then the toolstack must modify >> the bitmap, but if it is true, the toolstack oughtn''t need to do >> anything further. >> >> Signed-off-by: Gianni Tedesco <gianni.tedesco@citrix.com> >> > > > Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com> > > >> diff -r a0662e3bedea tools/libxc/xc_hvm_build.c >> --- a/tools/libxc/xc_hvm_build.c Fri Feb 11 14:28:14 2011 +0000 >> +++ b/tools/libxc/xc_hvm_build.c Fri Feb 11 14:39:47 2011 +0000 >> @@ -70,6 +70,7 @@ static void build_hvm_info(void *hvm_inf >> hvm_info->acpi_enabled = 1; >> hvm_info->apic_mode = 1; >> hvm_info->nr_vcpus = 1; >> + memset(hvm_info->vcpu_online, 0xff, sizeof(hvm_info->vcpu_online)); >> >> /* Memory parameters. */ >> hvm_info->low_mem_pgend = lowmem_end >> PAGE_SHIFT; >> >> >> >> _______________________________________________ >> Xen-devel mailing list >> Xen-devel@lists.xensource.com >> http://lists.xensource.com/xen-devel >> > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel >_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel