Kamala Narasimhan
2011-Feb-07 21:19 UTC
[xen-devel][PATCH 1/5] Xl Disk Configuration Option Documentation
Attached is a documentation of Xl disk configuration option that has already been reviewed. Signed-off-by: Kamala Narasimhan <kamala.narasimhan@citrix.com> Kamala _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Ian Jackson
2011-Feb-08 15:31 UTC
Re: [xen-devel][PATCH 1/5] Xl Disk Configuration Option Documentation
Kamala Narasimhan writes ("[xen-devel][PATCH 1/5] Xl Disk Configuration Option Documentation"):> Attached is a documentation of Xl disk configuration option that has already been reviewed.Thanks, this looks good. AIUI it describes the situation after the rest of your series has been applied so it should be committed after all the rest, or at least with the rest ? There are a couple of tiny formatting issues which I can fix up when I commit it:> +Description: Qualifies virtual device type.^^ and the trailing whitespace. And:> + specifications). [ @TODO: Refer to IanJ''s virtual > + disk specification here.]I think this TODO is fine to commit as-is, but you''ll see that I''ve just reposted my vbd specification doc. Depending on the order of the commits I will fix this up. Ian. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Kamala Narasimhan
2011-Feb-08 18:51 UTC
Re: [xen-devel][PATCH 1/5] Xl Disk Configuration Option Documentation
Ian Jackson wrote:> Kamala Narasimhan writes ("[xen-devel][PATCH 1/5] Xl Disk Configuration Option Documentation"): >> Attached is a documentation of Xl disk configuration option that has already been reviewed. > > Thanks, this looks good. AIUI it describes the situation after the > rest of your series has been applied so it should be committed after > all the rest, or at least with the rest ? >Good point. I think it can go first as most part of it describes the current state. But there are a couple of changes that switches some attributes to optional that would be better handled once the rest of the patches are applied. But the core details hasn''t changed as much. So could be applied first IMO.> There are a couple of tiny formatting issues which I can fix up when I > commit it: > >> +Description: Qualifies virtual device type. > ^^ > and the trailing whitespace. > > And: > >> + specifications). [ @TODO: Refer to IanJ''s virtual >> + disk specification here.] > > I think this TODO is fine to commit as-is, but you''ll see that I''ve > just reposted my vbd specification doc. Depending on the order of the > commits I will fix this up. >Thanks for fixing up those. Kamala _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel