Folks, I''ve just tagged 4.1.0-rc2 in http://xenbits.xen.org/staging/xen-unstable.hg Please test this new release candidate! -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
I get the following failure building xen-4.1.0/stubdom/mini-os-x86_64-ioemu/lib/sys.o cc1: warnings being treated as errors lib/sys.c: In function ''open_savefile'': lib/sys.c:186:5: error: passing argument 1 of ''snprintf'' from incompatible pointer type /home/michael/rpmbuild/BUILD/xen-4.1.0/stubdom/cross-root-x86_64/x86_64-xen-elf/include/stdio.h:264:5: note: expected ''char *'' but argument is of type ''char **'' lib/sys.c:188:5: error: passing argument 1 of ''init_consfront'' from incompatible pointer type /home/michael/rpmbuild/BUILD/xen-4.1.0/stubdom/../extras/mini-os/include/mini-os/console.h:82:23: note: expected ''char *'' but argument is of type ''char **'' lib/sys.c: In function ''open'': lib/sys.c:213:9: error: passing argument 1 of ''open_savefile'' discards qualifiers from pointer target type lib/sys.c:181:5: note: expected ''char *'' but argument is of type ''const char *'' lib/sys.c: In function ''write'': lib/sys.c:289:25: error: pointer of type ''void *'' used in arithmetic make[2]: *** [/home/michael/rpmbuild/BUILD/xen-4.1.0/stubdom/mini-os-x86_64-ioemu/lib/sys.o] Error 1 make[2]: Leaving directory `/home/michael/rpmbuild/BUILD/xen-4.1.0/extras/mini-os'' make[1]: *** [ioemu-stubdom] Error 2 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
M A Young writes ("[Xen-devel] Re: Xen 4.1.0 RC2
released"):> I get the following failure building
> xen-4.1.0/stubdom/mini-os-x86_64-ioemu/lib/sys.o
>
> cc1: warnings being treated as errors
> lib/sys.c: In function ''open_savefile'':
These do seem to be genuine bugs. I don''t know why our compiler
doesn''t warn or fail on this. Can you try this patch ?
stubdom, minios: correct mistakes in types causing compilation failures
open_savefile ignores its path argument so it can be const char *.
The buffer is nodename is a buffer of characters.
Arithmetic on void*''s is not permitted.
Reported-by: M A Young <m.a.young@durham.ac.uk>
Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
diff -r 67d5b8004947 extras/mini-os/lib/sys.c
--- a/extras/mini-os/lib/sys.c Wed Jan 26 11:58:45 2011 +0000
+++ b/extras/mini-os/lib/sys.c Wed Jan 26 14:58:53 2011 +0000
@@ -178,10 +178,10 @@ int posix_openpt(int flags)
return(dev->fd);
}
-int open_savefile(char *path, int save)
+int open_savefile(const char *path, int save)
{
struct consfront_dev *dev;
- char *nodename[64];
+ char nodename[64];
snprintf(nodename, sizeof(nodename), "device/console/%d", save ?
SAVE_CONSOLE : RESTORE_CONSOLE);
@@ -286,7 +286,7 @@ int write(int fd, const void *buf, size_
while (nbytes > 0) {
ret = xencons_ring_send(files[fd].cons.dev, (char *)buf,
nbytes);
nbytes -= ret;
- buf += ret;
+ buf = (char*)buf + ret;
}
return tot - nbytes;
}
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
On Wed, 26 Jan 2011, Ian Jackson wrote:> M A Young writes ("[Xen-devel] Re: Xen 4.1.0 RC2 released"): >> I get the following failure building >> xen-4.1.0/stubdom/mini-os-x86_64-ioemu/lib/sys.o >> >> cc1: warnings being treated as errors >> lib/sys.c: In function ''open_savefile'': > > These do seem to be genuine bugs. I don''t know why our compiler > doesn''t warn or fail on this. Can you try this patch ?Yes it works. Michael Young _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
I have just tagged 4.1.0-rc3 in http://xenbits.xen.org/staging/xen-unstable.hg Please carry on testing, with this new release candidate. Given the number of outstanding bugs, and the queue of outstanding patches, and the Chinese New Year (which has a holiday which coincides with our original final week or two of freeze), we''re going to slip the freeze schedule by a week right now and consider the question again next Monday. So our schedule now looks like this. We are here: | Feature code freeze | | Bugfixes are allowed provided they are not high-risk. | | No new features will be committed. This is coming up soon: | Slushy code freeze | after 7 Feb | | Bugfixes are allowed but only if they either: | - fix an important bug; or | - are very trivial and low-risk. | | All changes to receive a formal ack from a maintainer other than | the committer. | | Hard code freeze | after 14 Feb | | No further patches other than for release-critical bugs. | | All changes to receive a formal ack from a maintainer other than | the committer. | | Release. | planned for 21 Feb | | In all cases, the plan is subject to modification, and to the making | of freeze exceptions by the maintainers following consultation. Ian. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel