Recentlly, when trying to get to the bottom of some strange booting problem, I discovered that pyrgub --isconfig <image file> usefully reports the kernel, initrd (ramdisk) and arguments that would be used to boot a kernel. Well, actually, what it reported was an error. This patch makes it work (and jolly useful it is too). The patch also removes a spurious "print >>sys.stderr" that seems to have been left in from some previous debugging. jch _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
John Haxby writes ("[Xen-devel] [PATCH] Fix pygrub --isconfig"):> Recentlly, when trying to get to the bottom of some strange booting > problem, I discovered that > > pyrgub --isconfig <image file> > > usefully reports the kernel, initrd (ramdisk) and arguments that would > be used to boot a kernel. Well, actually, what it reported was an > error. This patch makes it work (and jolly useful it is too). The > patch also removes a spurious "print >>sys.stderr" that seems to have > been left in from some previous debugging.Thanks, but this patch doesn''t apply to xen-unstable.hg. xen-unstable has a loop "for offset in part_offs" surrounding the code you seem to be trying to patch. Is it important to check for "isconfig" before running sniff_solaris and sniff_netware ? Ian. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On 20/01/11 16:40, Ian Jackson wrote:> John Haxby writes ("[Xen-devel] [PATCH] Fix pygrub --isconfig"): >> Recentlly, when trying to get to the bottom of some strange booting >> problem, I discovered that >> >> pyrgub --isconfig <image file> >> >> usefully reports the kernel, initrd (ramdisk) and arguments that would >> be used to boot a kernel. Well, actually, what it reported was an >> error. This patch makes it work (and jolly useful it is too). The >> patch also removes a spurious "print >>sys.stderr" that seems to have >> been left in from some previous debugging. > Thanks, but this patch doesn''t apply to xen-unstable.hg. xen-unstable > has a loop "for offset in part_offs" surrounding the code you seem to > be trying to patch.Sorry. This patch was originally from something rather older which I then applied to xen-4.0-testing by mistake. I have attached an updated patch against xen-unstable.hg.> Is it important to check for "isconfig" before running sniff_solaris > and sniff_netware ?No, it should really be checked after as (presumably) the intention is to report what would actually be chosen. Although I have attached the patch to move the isconfig stuff to the point where the chosenconfig is finally known "pygrub --isconfig" is functionally equivalent to "pygrub --not-really --output-format simple --output -" so it might be better just to remove the isconfig code altogether. You could make it a synonym for the longer command, but as isconfig has been unloved for quite a while it probably isn''t worth it. jch _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
John Haxby writes ("Re: [Xen-devel] [PATCH] Fix pygrub --isconfig"):> Although I have attached the patch to move the isconfig stuff to the > point where the chosenconfig is finally known "pygrub --isconfig" is > functionally equivalent to "pygrub --not-really --output-format simple > --output -" so it might be better just to remove the isconfig code > altogether. You could make it a synonym for the longer command, but as > isconfig has been unloved for quite a while it probably isn''t worth it.Thanks for investigating. Under the circumstances I think we probably should just leave things as they are for 4.1 and probably make isconfig an alias for this in 4.2. Ian. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel