Stefano Stabellini
2011-Jan-19 13:53 UTC
[Xen-devel] [PATCH 2/5] qemu and qemu-xen: fix segfault on con_disconnect
The test on xendev->gnttabdev in con_disconnect is wrong: what differentiates the consoles is the dev number. Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com> diff --git a/hw/xen_console.c b/hw/xen_console.c index d7099c4..0a2374c 100644 --- a/hw/xen_console.c +++ b/hw/xen_console.c @@ -258,7 +258,7 @@ static void con_disconnect(struct XenDevice *xendev) xen_be_unbind_evtchn(&con->xendev); if (con->sring) { - if (!xendev->gnttabdev) + if (!xendev->dev) munmap(con->sring, XC_PAGE_SIZE); else xc_gnttab_munmap(xendev->gnttabdev, con->sring, 1); _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Ian Jackson
2011-Jan-20 16:35 UTC
Re: [Xen-devel] [PATCH 2/5] qemu and qemu-xen: fix segfault on con_disconnect
Stefano Stabellini writes ("[Xen-devel] [PATCH 2/5] qemu and qemu-xen: fix segfault on con_disconnect"):> The test on xendev->gnttabdev in con_disconnect is wrong: what > differentiates the consoles is the dev number.Thanks, I have applied this patch to qemu-xen-unstable.git. Ian. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel