Broken page handler for pod cache When mce triggerred by a broken page, it will handle the broken page. The broken page maybe populated, or, maybe at pod cache. This patch is to handle the broken page at pod cache. Signed-off-by: Liu, Jinsong <jinsong.liu@intel.com> _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2011-Jan-14 09:26 UTC
[Xen-devel] Re: [PATCH] Broken page handler for pod cache
On 14/01/2011 09:13, "Liu, Jinsong" <jinsong.liu@intel.com> wrote:> Broken page handler for pod cache > > When mce triggerred by a broken page, it will handle the broken page. > The broken page maybe populated, or, maybe at pod cache. > This patch is to handle the broken page at pod cache. > > Signed-off-by: Liu, Jinsong <jinsong.liu@intel.com>These pod/p2m patches are Tim''s area (I''ve cc''ed him). This particular patch looks a bit pointless on its own as nothing calls the function that it defines. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Jan Beulich
2011-Jan-14 09:30 UTC
Re: [Xen-devel] [PATCH] Broken page handler for pod cache
>>> On 14.01.11 at 10:13, "Liu, Jinsong" <jinsong.liu@intel.com> wrote: > Broken page handler for pod cache > > When mce triggerred by a broken page, it will handle the broken page. > The broken page maybe populated, or, maybe at pod cache. > This patch is to handle the broken page at pod cache. > > Signed-off-by: Liu, Jinsong <jinsong.liu@intel.com>Is the patch perhaps incomplete? It adds a new function but no caller of it. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Tim Deegan
2011-Jan-14 10:27 UTC
[Xen-devel] Re: [PATCH] Broken page handler for pod cache
At 09:26 +0000 on 14 Jan (1294997184), Keir Fraser wrote:> On 14/01/2011 09:13, "Liu, Jinsong" <jinsong.liu@intel.com> wrote: > > > Broken page handler for pod cache > > > > When mce triggerred by a broken page, it will handle the broken page. > > The broken page maybe populated, or, maybe at pod cache. > > This patch is to handle the broken page at pod cache. > > > > Signed-off-by: Liu, Jinsong <jinsong.liu@intel.com> > > These pod/p2m patches are Tim''s area (I''ve cc''ed him).Looks basically OK to me except, as Keir and Jan mentioned, it needs to be called from somewhere. :) Cheers, Tim. -- Tim Deegan <Tim.Deegan@citrix.com> Principal Software Engineer, Xen Platform Team Citrix Systems UK Ltd. (Company #02937203, SL9 0BG) _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Liu, Jinsong
2011-Jan-14 13:26 UTC
[Xen-devel] RE: [PATCH] Broken page handler for pod cache
Tim, Jan, and Keir, Yes, it would be call somewhere at Xen mce logic which would be added later :) (I just wondering which point of Xen moce logic is good place to hook, will send another patch later) Thanks, Jinsong Tim Deegan wrote:> At 09:26 +0000 on 14 Jan (1294997184), Keir Fraser wrote: >> On 14/01/2011 09:13, "Liu, Jinsong" <jinsong.liu@intel.com> wrote: >> >>> Broken page handler for pod cache >>> >>> When mce triggerred by a broken page, it will handle the broken >>> page. The broken page maybe populated, or, maybe at pod cache. >>> This patch is to handle the broken page at pod cache. >>> >>> Signed-off-by: Liu, Jinsong <jinsong.liu@intel.com> >> >> These pod/p2m patches are Tim''s area (I''ve cc''ed him). > > Looks basically OK to me except, as Keir and Jan mentioned, it needs > to be called from somewhere. :) > > Cheers, > > Tim._______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel