Hi! As previously reported when I start guests with xl then the guest network does not work because the qemu-ifup script no longer runs. NetBSD doesn''t have something like udev. Changing xm/xend, libxl and xenbackendd to make everything behave the same way is a lot more intrusive than enabling it for NetBSD again. Signed-off-by: Christoph Egger <Christoph.Egger@amd.com> -- ---to satisfy European Law for business letters: Advanced Micro Devices GmbH Einsteinring 24, 85609 Dornach b. Muenchen Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Christoph Egger writes ("[Xen-devel] [PATCH] libxl: fix guest
networking"):> As previously reported when I start guests with xl then the
> guest network does not work because the qemu-ifup script
> no longer runs.
Thanks, I have applied this patch. However, two comments:
Firstly, like many of your patches, I had to change the Subject of the
commit message to something more informative. "fix guest networking"
is rather vague. You''d make our lives just infinitesimally easier if
you wrote a better subject line yourself :-).
Secondly,
+static const char *libxl_tapif_script(libxl__gc *gc)
+{
+#ifdef __linux__
+ return libxl__strdup(gc, "no");
+#else
+ return libxl__sprintf(gc, "%s/qemu-ifup",
libxl_xen_script_dir_path());
+#endif
+}
I''m really not a fan of #ifdefs in the main parts of the code.
Perhaps we can (in 4.2) create a file where we can dump these kind of
things.
Thanks,
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
On Mon, 2011-01-17 at 17:21 +0000, Ian Jackson wrote:> +static const char *libxl_tapif_script(libxl__gc *gc) > +{ > +#ifdef __linux__ > + return libxl__strdup(gc, "no"); > +#else > + return libxl__sprintf(gc, "%s/qemu-ifup", libxl_xen_script_dir_path()); > +#endif > +} > > I''m really not a fan of #ifdefs in the main parts of the code. > Perhaps we can (in 4.2) create a file where we can dump these kind of > things.IMHO it would be better to switch netbsd to the new model for 4.2. Ian. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel