Stefano Stabellini
2011-Jan-10 11:02 UTC
[Xen-devel] [PATCH] libxl: implement trigger s3resume
Implement trigger s3resume This is the equivalent of xm trigger s3resume and it is implemented the same way: using an ACPI state change. Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com> diff -r 1ae74f060a39 tools/libxl/libxl.c --- a/tools/libxl/libxl.c Mon Jan 10 10:37:53 2011 +0000 +++ b/tools/libxl/libxl.c Mon Jan 10 10:58:50 2011 +0000 @@ -2668,8 +2668,14 @@ static int trigger_type_from_string(char int libxl_send_trigger(libxl_ctx *ctx, uint32_t domid, char *trigger_name, uint32_t vcpuid) { int rc = -1; - int trigger_type = trigger_type_from_string(trigger_name); - + int trigger_type = -1; + + if (!strcmp(trigger_name, "s3resume")) { + xc_set_hvm_param(ctx->xch, domid, HVM_PARAM_ACPI_S_STATE, 0); + return 0; + } + + trigger_type = trigger_type_from_string(trigger_name); if (trigger_type == -1) { LIBXL__LOG_ERRNOVAL(ctx, LIBXL__LOG_ERROR, -1, "Invalid trigger, valid triggers are <nmi|reset|init|power|sleep>"); _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Ian Jackson
2011-Jan-11 16:59 UTC
Re: [Xen-devel] [PATCH] libxl: implement trigger s3resume
Stefano Stabellini writes ("[Xen-devel] [PATCH] libxl: implement trigger s3resume"):> Implement trigger s3resume > > This is the equivalent of xm trigger s3resume and it is implemented the > same way: using an ACPI state change.The code here is a bit odd - callers are apparently expected to pass strings rather than enums through into the libxl API. I think trigger_type_from_string ought to be libxlu_... But given the current code and the state of freeze we shouldn''t do that now. This is clearly a low-impact new feature and I''m inclined to make exception to the freeze for it. Have you tested the patch ? Anyone object ? Thanks, Ian. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Stefano Stabellini
2011-Feb-14 15:29 UTC
Re: [Xen-devel] [PATCH] libxl: implement trigger s3resume
On Tue, 11 Jan 2011, Ian Jackson wrote:> Stefano Stabellini writes ("[Xen-devel] [PATCH] libxl: implement trigger s3resume"): > > Implement trigger s3resume > > > > This is the equivalent of xm trigger s3resume and it is implemented the > > same way: using an ACPI state change. > > The code here is a bit odd - callers are apparently expected to pass > strings rather than enums through into the libxl API. I think > trigger_type_from_string ought to be libxlu_... > > But given the current code and the state of freeze we shouldn''t do > that now. > > This is clearly a low-impact new feature and I''m inclined to make > exception to the freeze for it. Have you tested the patch ? Anyone > object ?I forgot to reply to this, but yes I tested it. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Ian Jackson
2011-Feb-14 16:49 UTC
Re: [Xen-devel] [PATCH] libxl: implement trigger s3resume
Stefano Stabellini writes ("Re: [Xen-devel] [PATCH] libxl: implement trigger s3resume"):> I forgot to reply to this, but yes I tested it.I''ve applied the patch, thanks. Ian. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel