Keir, shouldn''t it only be the CPU_DEAD case where BUG() is called upon migrate_timers_from_cpu() returning non-zero? That is, shouldn''t CPU_UP_CANCELED go together with CPU_DYING? From what I can tell, that''s the reason for a crash Yinghai is seeing on a large system (there are other problems obviously, as CPU bringup shouldn''t fail in the first place - I hope we can hunt that down soon). Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On 07/01/2011 12:57, "Jan Beulich" <JBeulich@novell.com> wrote:> Keir, > > shouldn''t it only be the CPU_DEAD case where BUG() is called upon > migrate_timers_from_cpu() returning non-zero? That is, shouldn''t > CPU_UP_CANCELED go together with CPU_DYING? From what I > can tell, that''s the reason for a crash Yinghai is seeing on a large > system (there are other problems obviously, as CPU bringup > shouldn''t fail in the first place - I hope we can hunt that down > soon).Good point. I''ll fix it. -- Keir> Jan >_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On 07/01/2011 12:57, "Jan Beulich" <JBeulich@novell.com> wrote:> Keir, > > shouldn''t it only be the CPU_DEAD case where BUG() is called upon > migrate_timers_from_cpu() returning non-zero? That is, shouldn''t > CPU_UP_CANCELED go together with CPU_DYING? From what I > can tell, that''s the reason for a crash Yinghai is seeing on a large > system (there are other problems obviously, as CPU bringup > shouldn''t fail in the first place - I hope we can hunt that down > soon).It was more complicated to fix than I remembered, but it''s done now. -- Keir> Jan >_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel