Hi! Attached patch makes libxc build again on NetBSD after the recent rework. Signed-off-by: Christoph Egger <Christoph.Egger@amd.com> -- ---to satisfy European Law for business letters: Advanced Micro Devices GmbH Einsteinring 24, 85609 Dornach b. Muenchen Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Christoph Egger writes ("[Xen-devel] [PATCH] libxc: build fixes"):> Attached patch makes libxc build again on NetBSD after the recent rework.I have applied this. However: I changed the name of the new make variable from LIBDL to DLOPEN_LIBS. The latter conforms to the naming scheme for similar variables found in config/*.mk - PTHREAD_LIBS et al. Also I moved the setting of the variable to -dl from Linux to StdGNU (which makes it apply more widely) and also added it to SunOS.mk (based on pure guesswork). Ian. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On Thu, 2011-01-06 at 15:46 +0000, Christoph Egger wrote:> Hi! > > Attached patch makes libxc build again on NetBSD after the recent rework. > > Signed-off-by: Christoph Egger <Christoph.Egger@amd.com>Sorry for the breakage. IanJ has already applied this (or I''d have acked it) but it did remind me that I''ve been meaning to ask if you happen to have a reliable recipe for installing a NetBSD domU on a Linux dom0, so I can at least compile test this sort of thing. My attempts to do so in the past have not been terribly successful. I think because the HOWTOs I find via google tend to assume a NetBSD dom0 as well or be out of date. Maybe I should just try again, it has been a while... Ian. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On Thu, Jan 06, Ian Jackson wrote:> Christoph Egger writes ("[Xen-devel] [PATCH] libxc: build fixes"): > > Attached patch makes libxc build again on NetBSD after the recent rework. > > I have applied this. However: > > I changed the name of the new make variable from LIBDL to DLOPEN_LIBS. > The latter conforms to the naming scheme for similar variables found > in config/*.mk - PTHREAD_LIBS et al. > > Also I moved the setting of the variable to -dl from Linux to StdGNU > (which makes it apply more widely) and also added it to SunOS.mk > (based on pure guesswork).This is incomplete. flask does not build because linking fails with missing dlopen/dlsym etc. This change fixes it for me. Signed-off-by: Olaf Hering <olaf@aepfle.de> --- xen-unstable.hg-4.1.22697.orig/tools/Rules.mk +++ xen-unstable.hg-4.1.22697/tools/Rules.mk @@ -18,7 +18,7 @@ XEN_BLKTAP2 = $(XEN_ROOT)/tools/b CFLAGS_include = -I$(XEN_INCLUDE) CFLAGS_libxenctrl = -I$(XEN_LIBXC) $(CFLAGS_include) -LDLIBS_libxenctrl = -L$(XEN_LIBXC) -lxenctrl +LDLIBS_libxenctrl = -L$(XEN_LIBXC) -lxenctrl $(DLOPEN_LIBS) CFLAGS_libxenguest = -I$(XEN_LIBXC) $(CFLAGS_include) LDLIBS_libxenguest = -L$(XEN_LIBXC) -lxenguest _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On Tue, 2011-01-11 at 10:41 +0000, Olaf Hering wrote:> On Thu, Jan 06, Ian Jackson wrote: > > > Christoph Egger writes ("[Xen-devel] [PATCH] libxc: build fixes"): > > > Attached patch makes libxc build again on NetBSD after the recent rework. > > > > I have applied this. However: > > > > I changed the name of the new make variable from LIBDL to DLOPEN_LIBS. > > The latter conforms to the naming scheme for similar variables found > > in config/*.mk - PTHREAD_LIBS et al. > > > > Also I moved the setting of the variable to -dl from Linux to StdGNU > > (which makes it apply more widely) and also added it to SunOS.mk > > (based on pure guesswork). > > This is incomplete. flask does not build because linking fails with > missing dlopen/dlsym etc. This change fixes it for me.I thought there was a way to convince ld to do this sort of thing automatically without forcing higher layers to know all about the transitive dependencies. However we''ve got a bunch of this stuff already and I don''t think anyone really wants to go messing with the build system so close to the 4.1-rc0 anyway so:> Signed-off-by: Olaf Hering <olaf@aepfle.de>Acked-by: Ian Campbell <ian.campbell@citrix.com> Ian.> > --- xen-unstable.hg-4.1.22697.orig/tools/Rules.mk > +++ xen-unstable.hg-4.1.22697/tools/Rules.mk > @@ -18,7 +18,7 @@ XEN_BLKTAP2 = $(XEN_ROOT)/tools/b > CFLAGS_include = -I$(XEN_INCLUDE) > > CFLAGS_libxenctrl = -I$(XEN_LIBXC) $(CFLAGS_include) > -LDLIBS_libxenctrl = -L$(XEN_LIBXC) -lxenctrl > +LDLIBS_libxenctrl = -L$(XEN_LIBXC) -lxenctrl $(DLOPEN_LIBS) > > CFLAGS_libxenguest = -I$(XEN_LIBXC) $(CFLAGS_include) > LDLIBS_libxenguest = -L$(XEN_LIBXC) -lxenguest > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Ian Campbell writes ("Re: [Xen-devel] [PATCH] libxc: build fixes"):> On Tue, 2011-01-11 at 10:41 +0000, Olaf Hering wrote: > > This is incomplete. flask does not build because linking fails with > > missing dlopen/dlsym etc. This change fixes it for me.Thanks for the report. I see Keir has applied this patch.> I thought there was a way to convince ld to do this sort of thing > automatically without forcing higher layers to know all about the > transitive dependencies.Not really. The closest thing is pkg-config. libtool has something which tries to do this bug libtool is the work of the devil.> However we''ve got a bunch of this stuff already and I don''t think anyone > really wants to go messing with the build system so close to the 4.1-rc0 > anyway so:Certainly, that too :-). Ian. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel