Matthias Goergens
2010-Dec-17 16:52 UTC
[Xen-devel] [PATCH 0 of 2] xentop-manpage: note about --delay
Hi, I added a note to the xentop manpage, explaining that --delay only takes integers. I am using `hg email'' to prepare the email, and I''ve botched up the first commit, but I''ve already pushed that pre-maturely. So I am sending both as separate patches. The second patch rectifies two problems with the first patch (typo and wrong position in series file). I hope that''s not too confusing. Cheers, Matthias. series | 1 + xentop-manpage-delay | 19 +++++++++++++++++++ series | 3 ++- xentop-manpage-delay | 2 +- 4 files changed, 23 insertions(+), 2 deletions(-) _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Matthias Goergens
2010-Dec-17 16:52 UTC
[Xen-devel] [PATCH 1 of 2] xentop manpage: --delay
series | 1 + xentop-manpage-delay | 19 +++++++++++++++++++ 2 files changed, 20 insertions(+), 0 deletions(-) _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Matthias Goergens
2010-Dec-17 16:52 UTC
[Xen-devel] [PATCH 2 of 2] xentop-manpage: fix typo and move series entry to should-go-upstream section
series | 3 ++- xentop-manpage-delay | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
George Dunlap
2010-Dec-20 13:30 UTC
Re: [Xen-devel] [PATCH 1 of 2] xentop manpage: --delay
Matthias, This looks like a diff of a patchqueue repository, not the diff itself. What exactly is this meant to apply to? Patches sent to the list should be able to be applied directly to xen-unstable. The way I do this is as follows: * Start with a clean copy of xen-unstable.hg * Make a patch series as a mercurial patchqueue * Once development of the series is done, pop them all off the queue and edit the patches to include short description in the first line, longer description (if necessary) following, then the signed-off-by line * Push the queue back on * Now if you do "hg outgoing" (in xen-unstable.hg), you should see your patch series as individual commits * "hg email -o --plain" will mail the patch series correctly. Hope that helps. -George On Fri, Dec 17, 2010 at 4:52 PM, Matthias Goergens <matthias.goergens@citrix.com> wrote:> series | 1 + > xentop-manpage-delay | 19 +++++++++++++++++++ > 2 files changed, 20 insertions(+), 0 deletions(-) > > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel > >_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
George Dunlap writes ("Re: [Xen-devel] [PATCH 1 of 2] xentop manpage: --delay"):> This looks like a diff of a patchqueue repository, not the diff > itself. What exactly is this meant to apply to? > > Patches sent to the list should be able to be applied directly to > xen-unstable. The way I do this is as follows:Matthias seems to be using git. I use git myself sometimes to prepare patches for xen-unstable. The way to do this is: * Start with a clean git clone of a git conversion of xen-unstable.hg (which you can make with "hg-fast-export.sh" which is part of "fast-export") * Create a branch for your patch or series * Cherry pick or otherwise apply your changes to that branch * Use git-rebase -i etc. to get the commit messages into shape * Compile and test the resulting tree * Use git-format-patch * Use git-send-email --chain-reply-to --compose (If you haven''t used git-send-email before, get it to send the messages to yourself the first time round) But anyway, diffs of diffs aren''t the way to do it. Thanks, Ian. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel