Ian Jackson
2010-Dec-14 17:39 UTC
[Xen-devel] [PATCH] tools/hotplug: Do not mind if "ip link set" fails on vifs
# HG changeset patch
# User Ian Jackson <Ian.Jackson@eu.citrix.com>
# Date 1292348298 0
# Node ID 5e443a99b1ffee5112ad3d06d622c8b44d74fab1
# Parent 57907b28e51abc1cd62979a9915d560e427cbacf
tools/hotplug: Do not mind if "ip link set" fails on vif backends
Most versions of netback do not support setting the MAC address. This
means that c/s 937488219719 causes the hotplug script to break for
vifs, even as it fixes the bridge-wrong-MAC-address problem for tap
devices (used for emulated nics).
The mac-setting operation is not necessary for vifs since they are
hardcoded to fe:ff* anyway.
As a band-aid, add "|| true" to the call to ip link, so that this
error does not cause the hotplug operation to fail. There will still
be an error message printed until we can fix this better.
Suggested-by: Ian Campbell <Ian.Campbell@eu.citrix.com>
Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
diff -r 57907b28e51a -r 5e443a99b1ff tools/hotplug/Linux/xen-network-common.sh
--- a/tools/hotplug/Linux/xen-network-common.sh Tue Dec 14 17:15:48 2010 +0000
+++ b/tools/hotplug/Linux/xen-network-common.sh Tue Dec 14 17:38:18 2010 +0000
@@ -90,7 +90,7 @@ setup_bridge_port() {
# largest non-broadcast address to prevent the address getting
# stolen by an Ethernet bridge for STP purposes.
# (FE:FF:FF:FF:FF:FF)
- ip link set ${dev} address fe:ff:ff:ff:ff:ff
+ ip link set ${dev} address fe:ff:ff:ff:ff:ff || true
# ... and configure it
ip addr flush ${dev}
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel