Hi, I''ve ported the xfs code from grub to pygrub for our company internal use. If you find it useful fell free to merge with main code. Regards, Marco -- Marco Nenciarini - System manager @ Devise.IT marco.nenciarini@devise.it | http://www.devise.it _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On 08/12/2010 22:50, Wouter D''Haeseleer wrote:> Hi Marco, > > I''m struggling with the same issue as you had. > Did you by any change compiled it for debian amd64 ? > > I''m getting errors like: > fsys_xfs.c:409: error: extended registers have no high halves > > Any idea what I can do to solve it? >I developed it on a CentOS, because I need it on a XCP server, and there it works without problems. I''ve just tried on a Debian unstable x86_64 and the problem is always reproducible. Sincerely I have no idea on why it happens, but I''ve discovered that turning off the optimization (with -O0) it compiles without problems. Maybe some gcc guru can suggest a better solution. Regards, Marco -- Marco Nenciarini - System manager @ Devise.IT marco.nenciarini@devise.it | http://www.devise.it _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On Fri, 26 Nov 2010, Marco Nenciarini wrote:> > Hi, > I''ve ported the xfs code from grub to pygrub for our company internal use. > > If you find it useful fell free to merge with main code.Can anybody test this patch and confirm it works properly? _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On 13/12/2010 18:06, Stefano Stabellini wrote:> On Fri, 26 Nov 2010, Marco Nenciarini wrote: >> >> Hi, >> I''ve ported the xfs code from grub to pygrub for our company internal use. >> >> If you find it useful fell free to merge with main code. > > Can anybody test this patch and confirm it works properly?To help you testing the patch and auditing the code, I''ve attached to this message the diff against xfs code in grub-0.97. As stated before, the resulting fsimage.so works perfectly for me when installed in XCP-0.5 as /usr/lib/fs/xfs/fsimage.so Actually I''ve 3 Debian Squeeze machines and one Ubuntu 10.10 machine in our testing environment booting from xfs with pygrub. The only problem I''ve found is that the module doesn''t compile on Debian based system due to some bug in gcc code optimizer. On such a systems the compiler returns the following error: gcc -DPIC -O2 -fomit-frame-pointer -m64 -fno-strict-aliasing -std=gnu99 -Wall -Wstrict-prototypes -Wno-unused-value -Wdeclaration-after-statement -D__XEN_TOOLS__ -MMD -MF .fsys_xfs.opic.d -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -I../../../tools/libfsimage/common/ -Werror -fPIC -c -o fsys_xfs.opic fsys_xfs.c fsys_xfs.c: In function ‘next_dentry’: fsys_xfs.c:409: error: extended registers have no high halves fsys_xfs.c:409: error: extended registers have no high halves The problem disappear if you turn off optimization with -O0 Regards, Marco -- Marco Nenciarini - System manager @ Devise.IT marco.nenciarini@devise.it | http://www.devise.it _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On 14/12/2010 23:23, Marco Nenciarini wrote:> On 13/12/2010 18:06, Stefano Stabellini wrote: >> On Fri, 26 Nov 2010, Marco Nenciarini wrote: >>> >>> Hi, >>> I''ve ported the xfs code from grub to pygrub for our company internal use. >>> >>> If you find it useful fell free to merge with main code. >> >> Can anybody test this patch and confirm it works properly? > > To help you testing the patch and auditing the code, I''ve attached to > this message the diff against xfs code in grub-0.97. > > As stated before, the resulting fsimage.so works perfectly for me when > installed in XCP-0.5 as /usr/lib/fs/xfs/fsimage.so > > Actually I''ve 3 Debian Squeeze machines and one Ubuntu 10.10 machine in > our testing environment booting from xfs with pygrub. > > The only problem I''ve found is that the module doesn''t compile on Debian > based system due to some bug in gcc code optimizer. On such a systems > the compiler returns the following error: > > gcc -DPIC -O2 -fomit-frame-pointer -m64 -fno-strict-aliasing -std=gnu99 > -Wall -Wstrict-prototypes -Wno-unused-value > -Wdeclaration-after-statement -D__XEN_TOOLS__ -MMD -MF .fsys_xfs.opic.d > -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE > -I../../../tools/libfsimage/common/ -Werror -fPIC -c -o fsys_xfs.opic > fsys_xfs.c > fsys_xfs.c: In function ‘next_dentry’: > fsys_xfs.c:409: error: extended registers have no high halves > fsys_xfs.c:409: error: extended registers have no high halves > > The problem disappear if you turn off optimization with -O0 >I''ve solved the compilation error on Ubuntu/Debian x86_64 (sed s/"=q"/"=Q"/), but the resulting libary doesn''t works (it doesn''t even recognize the XFS partition). I''ll debug it during the next week. Regards, Marco -- Marco Nenciarini - System manager @ Devise.IT marco.nenciarini@devise.it | http://www.devise.it _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Attached there is the version of pygrub xfs support patch. I''ve tested it against XCP, CentOS and latest Debian Unstable i386/amd64. There is also my git patch queue against original grub code to show what I''ve done. Regards, Marco -- Marco Nenciarini - System manager @ Devise.IT marco.nenciarini@devise.it | http://www.devise.it _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Marco Nenciarini writes ("Re: [Xen-devel] XFS support for pygrub
patch"):> Attached there is the version of pygrub xfs support patch.
> I''ve tested it against XCP, CentOS and latest Debian Unstable
i386/amd64.
>
> There is also my git patch queue against original grub code to show what
> I''ve done.
Thanks for your contribution.
I''m afraid that the 4.1 tree is currently in feature code freeze so
normally we wouldn''t accept it.
However, having said that, it does look very self-contained and it
might be appropriate to grant a freeze exception in this case.
Stefano, what do you think ?
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
On Thu, 20 Jan 2011, Ian Jackson wrote:> Marco Nenciarini writes ("Re: [Xen-devel] XFS support for pygrub patch"): > > Attached there is the version of pygrub xfs support patch. > > I''ve tested it against XCP, CentOS and latest Debian Unstable i386/amd64. > > > > There is also my git patch queue against original grub code to show what > > I''ve done. > > Thanks for your contribution. > > I''m afraid that the 4.1 tree is currently in feature code freeze so > normally we wouldn''t accept it. > > However, having said that, it does look very self-contained and it > might be appropriate to grant a freeze exception in this case. > > Stefano, what do you think ?It would be nice if somebody could confirm that it works properly. If you get a couple of people confirming that it works I would consider applying it. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
tested on a Debian Squeeze amd64 dom0 with the xen packages as shipped by Squeeze (Xen 4.0.1) I just added the patch to the debian sources of Xen and rebuild a deb packages using the debian framework. I can now boot PVMs using pygrub even on machines with xfs boot/rootfs. -- View this message in context: http://xen.1045712.n5.nabble.com/XFS-support-for-pygrub-patch-tp3281142p4387931.html Sent from the Xen - Dev mailing list archive at Nabble.com. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel