George/All, This is an updated patch to add an ARINC653 scheduler to Xen. It uses the new sysctl interface to the adjust_global scheduler hook. I believe you helped Kathy and Anthony out earlier, George, and I was hoping you would still be able to support merging in this functionality. We have a mercurial repository now where we are storing these changes and the patch applies cleanly to the latest changeset (c0c1f5f0745e) in xen-unstable.hg as of now. Please let me know if you have any questions or require any modifications in order to integrate this functionality. Josh Holtrop DornerWorks, Ltd. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Thanks for submitting this, Josh. Just one question: Is there a reason you created a new sysctl .h file, instead of just putting the structure in the existing sysctl.h? Other than that, the changes to existing code look fine. (Haven''t done any review on the scheduler itself.) -George On Tue, Nov 23, 2010 at 10:07 PM, Josh Holtrop <Josh.Holtrop@dornerworks.com> wrote:> George/All, > > > > This is an updated patch to add an ARINC653 scheduler to Xen. It uses the > new sysctl interface to the adjust_global scheduler hook. I believe you > helped Kathy and Anthony out earlier, George, and I was hoping you would > still be able to support merging in this functionality. We have a mercurial > repository now where we are storing these changes and the patch applies > cleanly to the latest changeset (c0c1f5f0745e) in xen-unstable.hg as of now. > > > > Please let me know if you have any questions or require any modifications in > order to integrate this functionality. > > > > Josh Holtrop > > DornerWorks, Ltd. > > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel > >_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
I guess I was just trying to keep some of the added functionality segregated. There is no reason why the contents of sysctl_arinc653.h could not be included inside sysctl.h. -Josh -----Original Message----- From: dunlapg@gmail.com [mailto:dunlapg@gmail.com] On Behalf Of George Dunlap Sent: Wednesday, November 24, 2010 5:10 AM To: Josh Holtrop Cc: xen-devel@lists.xensource.com Subject: Re: [Xen-devel] [PATCH] updated ARINC 653 scheduler Thanks for submitting this, Josh. Just one question: Is there a reason you created a new sysctl .h file, instead of just putting the structure in the existing sysctl.h? Other than that, the changes to existing code look fine. (Haven''t done any review on the scheduler itself.) -George On Tue, Nov 23, 2010 at 10:07 PM, Josh Holtrop <Josh.Holtrop@dornerworks.com> wrote:> George/All, > > > > This is an updated patch to add an ARINC653 scheduler to Xen. It uses the > new sysctl interface to the adjust_global scheduler hook. I believe you > helped Kathy and Anthony out earlier, George, and I was hoping you would > still be able to support merging in this functionality. We have a mercurial > repository now where we are storing these changes and the patch applies > cleanly to the latest changeset (c0c1f5f0745e) in xen-unstable.hg as of now. > > > > Please let me know if you have any questions or require any modifications in > order to integrate this functionality. > > > > Josh Holtrop > > DornerWorks, Ltd. > > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel > >_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Not that big a deal either way; I think it should go in sysctl.h, but Keir has the final say on that. So (once the syctl.h issue is sorted), Acked-by: George Dunlap <george.dunlap@eu.citrix.com> -George On Wed, Nov 24, 2010 at 3:09 PM, Josh Holtrop <Josh.Holtrop@dornerworks.com> wrote:> I guess I was just trying to keep some of the added functionality segregated. There is no reason why the contents of sysctl_arinc653.h could not be included inside sysctl.h. > > -Josh > > -----Original Message----- > From: dunlapg@gmail.com [mailto:dunlapg@gmail.com] On Behalf Of George Dunlap > Sent: Wednesday, November 24, 2010 5:10 AM > To: Josh Holtrop > Cc: xen-devel@lists.xensource.com > Subject: Re: [Xen-devel] [PATCH] updated ARINC 653 scheduler > > Thanks for submitting this, Josh. Just one question: Is there a > reason you created a new sysctl .h file, instead of just putting the > structure in the existing sysctl.h? > > Other than that, the changes to existing code look fine. (Haven''t > done any review on the scheduler itself.) > > -George > > On Tue, Nov 23, 2010 at 10:07 PM, Josh Holtrop > <Josh.Holtrop@dornerworks.com> wrote: >> George/All, >> >> >> >> This is an updated patch to add an ARINC653 scheduler to Xen. It uses the >> new sysctl interface to the adjust_global scheduler hook. I believe you >> helped Kathy and Anthony out earlier, George, and I was hoping you would >> still be able to support merging in this functionality. We have a mercurial >> repository now where we are storing these changes and the patch applies >> cleanly to the latest changeset (c0c1f5f0745e) in xen-unstable.hg as of now. >> >> >> >> Please let me know if you have any questions or require any modifications in >> order to integrate this functionality. >> >> >> >> Josh Holtrop >> >> DornerWorks, Ltd. >> >> >> >> _______________________________________________ >> Xen-devel mailing list >> Xen-devel@lists.xensource.com >> http://lists.xensource.com/xen-devel >> >> > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel >_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir, What do you think? Should the contents of sysctl_arinc653.h be integrated into sysctl.h instead of being in a separate file? -Josh -----Original Message----- From: dunlapg@gmail.com [mailto:dunlapg@gmail.com] On Behalf Of George Dunlap Sent: Wednesday, November 24, 2010 11:27 AM To: Josh Holtrop; Keir Fraser Cc: xen-devel@lists.xensource.com Subject: Re: [Xen-devel] [PATCH] updated ARINC 653 scheduler Not that big a deal either way; I think it should go in sysctl.h, but Keir has the final say on that. So (once the syctl.h issue is sorted), Acked-by: George Dunlap <george.dunlap@eu.citrix.com> -George On Wed, Nov 24, 2010 at 3:09 PM, Josh Holtrop <Josh.Holtrop@dornerworks.com> wrote:> I guess I was just trying to keep some of the added functionality segregated. There is no reason why the contents of sysctl_arinc653.h could not be included inside sysctl.h. > > -Josh > > -----Original Message----- > From: dunlapg@gmail.com [mailto:dunlapg@gmail.com] On Behalf Of George Dunlap > Sent: Wednesday, November 24, 2010 5:10 AM > To: Josh Holtrop > Cc: xen-devel@lists.xensource.com > Subject: Re: [Xen-devel] [PATCH] updated ARINC 653 scheduler > > Thanks for submitting this, Josh. Just one question: Is there a > reason you created a new sysctl .h file, instead of just putting the > structure in the existing sysctl.h? > > Other than that, the changes to existing code look fine. (Haven''t > done any review on the scheduler itself.) > > -George > > On Tue, Nov 23, 2010 at 10:07 PM, Josh Holtrop > <Josh.Holtrop@dornerworks.com> wrote: >> George/All, >> >> >> >> This is an updated patch to add an ARINC653 scheduler to Xen. It uses the >> new sysctl interface to the adjust_global scheduler hook. I believe you >> helped Kathy and Anthony out earlier, George, and I was hoping you would >> still be able to support merging in this functionality. We have a mercurial >> repository now where we are storing these changes and the patch applies >> cleanly to the latest changeset (c0c1f5f0745e) in xen-unstable.hg as of now. >> >> >> >> Please let me know if you have any questions or require any modifications in >> order to integrate this functionality. >> >> >> >> Josh Holtrop >> >> DornerWorks, Ltd. >> >> >> >> _______________________________________________ >> Xen-devel mailing list >> Xen-devel@lists.xensource.com >> http://lists.xensource.com/xen-devel >> >> > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel >_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel