Tim Deegan
2010-Nov-22 10:17 UTC
[Xen-devel] [PATCH] tools/xl: only use the special "--incoming" name on actual migration
# HG changeset patch
# User Tim Deegan <Tim.Deegan@citrix.com>
# Date 1290188922 0
# Node ID 17d93860b47414fc7fbe9eb0df57baa8240019b5
# Parent d27297705f907ef709200d788747ba88e45139f3
tools/xl: only use the special "--incoming" name on actual migration
and not on every susequent reboot.
Signed-off-by: Tim Deegan <Tim.Deegan@citrix.com>
diff -r d27297705f90 -r 17d93860b474 tools/libxl/xl_cmdimpl.c
--- a/tools/libxl/xl_cmdimpl.c Fri Nov 19 17:48:42 2010 +0000
+++ b/tools/libxl/xl_cmdimpl.c Fri Nov 19 17:48:42 2010 +0000
@@ -1824,6 +1824,10 @@ start:
/* Some settings only make sense on first boot. */
paused = 0;
+ if (common_domname
+ && strcmp(d_config.c_info.name,
common_domname)) {
+ d_config.c_info.name = strdup(common_domname);
+ }
/*
* XXX FIXME: If this sleep is not there then domain
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
Ian Jackson
2010-Nov-23 19:33 UTC
Re: [Xen-devel] [PATCH] tools/xl: only use the special "--incoming" name on actual migration
Tim Deegan writes ("[Xen-devel] [PATCH] tools/xl: only use the special
"--incoming" name on actual migration"):> tools/xl: only use the special "--incoming" name on actual
migration
> and not on every susequent reboot.
Well spotted. However, doesn''t this:
> + d_config.c_info.name = strdup(common_domname);
leak the old value of c_info.name ? I don''t think we necessarily care
very much so I have applied th patch anyway.
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
Tim Deegan
2010-Nov-24 09:52 UTC
Re: [Xen-devel] [PATCH] tools/xl: only use the special "--incoming" name on actual migration
At 19:33 +0000 on 23 Nov (1290540816), Ian Jackson wrote:> Tim Deegan writes ("[Xen-devel] [PATCH] tools/xl: only use the special "--incoming" name on actual migration"): > > tools/xl: only use the special "--incoming" name on actual migration > > and not on every susequent reboot. > > Well spotted. However, doesn''t this: > > > + d_config.c_info.name = strdup(common_domname); > > leak the old value of c_info.name ?In the case where this happens, the old name has been passed by reference up the stack to the calling function, but in this path (the child of a fork) we never return to the caller. So, er, maybe? Tim. -- Tim Deegan <Tim.Deegan@citrix.com> Principal Software Engineer, Xen Platform Team Citrix Systems UK Ltd. (Company #02937203, SL9 0BG) _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel