Wei Wang2
2010-Nov-15 10:18 UTC
[Xen-devel] [PATCH] amd iommu: Fix HV crach with 32bit pv_ops kernel
Hi Keir, Attached patch should have fixed this issue: http://lists.xensource.com/archives/html/xen-devel/2010-11/msg00374.html Thanks, Wei Signed-off-by: Wei Wang <wei.wang2@amd.com> Tested-by: Conny Seidel <conny.seidel@amd.com> Legal Information: Advanced Micro Devices GmbH Sitz: Dornach, Gemeinde Aschheim, Landkreis München Registergericht München, HRB Nr. 43632 Geschäftsführer: Alberto Bozzo, Andrew Bowd _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Jan Beulich
2010-Nov-15 12:37 UTC
Re: [Xen-devel] [PATCH] amd iommu: Fix HV crach with 32bit pv_ops kernel
>>> On 15.11.10 at 11:18, Wei Wang2 <wei.wang2@amd.com> wrote: >--- a/xen/include/asm-x86/hvm/svm/amd-iommu-proto.h Wed Nov 10 14:56:06 2010 +0000 >+++ b/xen/include/asm-x86/hvm/svm/amd-iommu-proto.h Fri Nov 12 17:10:31 2010 +0100 >@@ -31,8 +31,8 @@ > > #define DMA_32BIT_MASK 0x00000000ffffffffULL > >-extern int amd_iommu_debug; >-extern int amd_iommu_perdev_intremap; >+extern bool_t amd_iommu_debug; >+extern bool_t amd_iommu_perdev_intremap; > > #define AMD_IOMMU_DEBUG(fmt, args...) \ > do \This surely can''t be complete: If you had a type mismatch between declaration and definition, the defining code is clearly missing an #include of the #define-ing header. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Wei Wang2
2010-Nov-15 13:58 UTC
[Xen-devel] [PATCH] amd iommu: Fix HV crash with 32bit pv_ops kernel (V2)
Hi Jan Could this new version be a little more clear? Thanks, Wei Signed-off-by: Wei Wang <wei.wang2@amd.com> On Monday 15 November 2010 13:37:27 Jan Beulich wrote:> >>> On 15.11.10 at 11:18, Wei Wang2 <wei.wang2@amd.com> wrote: > > > >--- a/xen/include/asm-x86/hvm/svm/amd-iommu-proto.h Wed Nov 10 14:56:06 > > 2010 +0000 +++ b/xen/include/asm-x86/hvm/svm/amd-iommu-proto.h Fri Nov 12 > > 17:10:31 2010 +0100 @@ -31,8 +31,8 @@ > > > > #define DMA_32BIT_MASK 0x00000000ffffffffULL > > > >-extern int amd_iommu_debug; > >-extern int amd_iommu_perdev_intremap; > >+extern bool_t amd_iommu_debug; > >+extern bool_t amd_iommu_perdev_intremap; > > > > #define AMD_IOMMU_DEBUG(fmt, args...) \ > > do \ > > This surely can''t be complete: If you had a type mismatch between > declaration and definition, the defining code is clearly missing an > #include of the #define-ing header. > > Jan_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Jan Beulich
2010-Nov-15 15:36 UTC
[Xen-devel] Re: [PATCH] amd iommu: Fix HV crash with 32bit pv_ops kernel(V2)
>>> On 15.11.10 at 14:58, Wei Wang2 <wei.wang2@amd.com> wrote: > Hi Jan > Could this new version be a little more clear? > Thanks, > WeiYes (assuming the header you moved the decl-s to is included by the producer). Jan> On Monday 15 November 2010 13:37:27 Jan Beulich wrote: >> >>> On 15.11.10 at 11:18, Wei Wang2 <wei.wang2@amd.com> wrote: >> > >> >--- a/xen/include/asm-x86/hvm/svm/amd-iommu-proto.h Wed Nov 10 14:56:06 >> > 2010 +0000 +++ b/xen/include/asm-x86/hvm/svm/amd-iommu-proto.h Fri Nov 12 >> > 17:10:31 2010 +0100 @@ -31,8 +31,8 @@ >> > >> > #define DMA_32BIT_MASK 0x00000000ffffffffULL >> > >> >-extern int amd_iommu_debug; >> >-extern int amd_iommu_perdev_intremap; >> >+extern bool_t amd_iommu_debug; >> >+extern bool_t amd_iommu_perdev_intremap; >> > >> > #define AMD_IOMMU_DEBUG(fmt, args...) \ >> > do \ >> >> This surely can''t be complete: If you had a type mismatch between >> declaration and definition, the defining code is clearly missing an >> #include of the #define-ing header. >> >> Jan_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel