Jan Beulich
2010-Nov-10 09:50 UTC
[Xen-devel] [PATCH] stubdom: allow building with read-only sources
Signed-off-by: Jan Beulich <jbeulich@novell.com> --- a/stubdom/Makefile +++ b/stubdom/Makefile @@ -155,8 +175,9 @@ cross-libpci: $(LIBPCI_STAMPFILE) $(LIBPCI_STAMPFILE): pciutils-$(XEN_TARGET_ARCH) $(NEWLIB_STAMPFILE) $(ZLIB_STAMPFILE) ( cd $< && \ cp ../libpci.config.h lib/config.h && \ + chmod u+w lib/config.h && \ echo ''#define PCILIB_VERSION "$(LIBPCI_VERSION)"'' >> lib/config.h && \ - cp ../libpci.config.mak lib/config.mk && \ + ln -sf ../../libpci.config.mak lib/config.mk && \ $(CROSS_MAKE) CC="$(CC) $(TARGET_CPPFLAGS) $(TARGET_CFLAGS) -I$(realpath $(MINI_OS)/include)" lib/libpci.a && \ $(INSTALL_DATA) lib/libpci.a $(CROSS_PREFIX)/$(GNU_TARGET_ARCH)-xen-elf/lib/ && \ $(INSTALL_DIR) $(CROSS_PREFIX)/$(GNU_TARGET_ARCH)-xen-elf/include/pci && \ _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Patrick Colp
2010-Nov-10 19:09 UTC
Re: [Xen-devel] [PATCH] stubdom: allow building with read-only sources
> --- a/stubdom/Makefile > +++ b/stubdom/Makefile > @@ -155,8 +175,9 @@ cross-libpci: $(LIBPCI_STAMPFILE) > $(LIBPCI_STAMPFILE): pciutils-$(XEN_TARGET_ARCH) $(NEWLIB_STAMPFILE) $(ZLIB_STAMPFILE) > ( cd $< && \ > cp ../libpci.config.h lib/config.h && \ > + chmod u+w lib/config.h && \ > echo ''#define PCILIB_VERSION "$(LIBPCI_VERSION)"'' >> lib/config.h && \ > - cp ../libpci.config.mak lib/config.mk && \ > + ln -sf ../../libpci.config.mak lib/config.mk && \Should the above line be + ln -sf ../libpci.config.mak lib/config.mk && \ instead? It seems an extra ../ was added and based just on the patch I can''t tell why. Patrick _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Jan Beulich
2010-Nov-11 08:45 UTC
Re: [Xen-devel] [PATCH] stubdom: allow building with read-only sources
>>> On 10.11.10 at 20:09, Patrick Colp <pjcolp@cs.ubc.ca> wrote: >> --- a/stubdom/Makefile >> +++ b/stubdom/Makefile >> @@ -155,8 +175,9 @@ cross-libpci: $(LIBPCI_STAMPFILE) >> $(LIBPCI_STAMPFILE): pciutils-$(XEN_TARGET_ARCH) $(NEWLIB_STAMPFILE) > $(ZLIB_STAMPFILE) >> ( cd $< && \ >> cp ../libpci.config.h lib/config.h && \ >> + chmod u+w lib/config.h && \ >> echo ''#define PCILIB_VERSION "$(LIBPCI_VERSION)"'' >> lib/config.h && \ >> - cp ../libpci.config.mak lib/config.mk && \ >> + ln -sf ../../libpci.config.mak lib/config.mk && \ > > Should the above line be > > + ln -sf ../libpci.config.mak lib/config.mk && \ > > instead? It seems an extra ../ was added and based just on the patch I > can''t tell why.No - the difference is between referencing the real file (cp) and creating a relative (to the target''s location) symlink. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Patrick Colp
2010-Nov-11 09:19 UTC
Re: [Xen-devel] [PATCH] stubdom: allow building with read-only sources
On 11 November 2010 00:45, Jan Beulich <JBeulich@novell.com> wrote:>>>> On 10.11.10 at 20:09, Patrick Colp <pjcolp@cs.ubc.ca> wrote: >>> --- a/stubdom/Makefile >>> +++ b/stubdom/Makefile >>> @@ -155,8 +175,9 @@ cross-libpci: $(LIBPCI_STAMPFILE) >>> $(LIBPCI_STAMPFILE): pciutils-$(XEN_TARGET_ARCH) $(NEWLIB_STAMPFILE) >> $(ZLIB_STAMPFILE) >>> ( cd $< && \ >>> cp ../libpci.config.h lib/config.h && \ >>> + chmod u+w lib/config.h && \ >>> echo ''#define PCILIB_VERSION "$(LIBPCI_VERSION)"'' >> lib/config.h && \ >>> - cp ../libpci.config.mak lib/config.mk && \ >>> + ln -sf ../../libpci.config.mak lib/config.mk && \ >> >> Should the above line be >> >> + ln -sf ../libpci.config.mak lib/config.mk && \ >> >> instead? It seems an extra ../ was added and based just on the patch I >> can''t tell why. > > No - the difference is between referencing the real file (cp) and > creating a relative (to the target''s location) symlink.Ah right, of course :) Patrick _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Ian Jackson
2010-Nov-19 18:39 UTC
Re: [Xen-devel] [PATCH] stubdom: allow building with read-only sources
Jan Beulich writes ("[Xen-devel] [PATCH] stubdom: allow building with
read-only sources"):> Signed-off-by: Jan Beulich <jbeulich@novell.com>
Applied, thanks.
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel