Haitao Shan
2010-Nov-08 13:21 UTC
[Xen-devel] [Patch] Fixing Xsave Guest Save/Restore on non-xsave platform
Hi, Keir, Sorry for the xsave-introduced regression bug. I have fixed and attached the patch with this email. xsave-migration.patch contains all the changes you have reverted plus the fix I made. xsave-migration-fix.patch only contains the fix I made based on original xsave patch series. I have tested the patch in the following senarios: 1> Non-xsave platform 2> Xsave-capable platform, guest does not support xsave, xen support xsave 3> Xsave-capable platform, guest does support xsave, xen supports xsave 4> Guest (non-xsave) saved on platform without xsave, restored on a Xsave-capable system. All passed. Could please have review? Thanks! Again, sorry for the regression caused. Signed-off-by: Shan Haitao <haitao.shan@intel.com> Signed-off-by: Han Weidong <weidong.han@intel.com> Shan Haitao _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2010-Nov-08 15:46 UTC
Re: [Xen-devel] [Patch] Fixing Xsave Guest Save/Restore on non-xsave platform
Okay, I have committed your fixed patch to xen-unstable. Note that you have not added back all my reversions: I also reverted the changes you made to expose XSAVE/AVX via cpuid. The reason was that you were passign through the host CPU''s CPUID feature flags, but not taking into account whether XSVAE was disabled in the hypervisor by use_xsave=0 (the default!). -- Keir On 08/11/2010 13:21, "Haitao Shan" <maillists.shan@gmail.com> wrote:> Hi, Keir, > > Sorry for the xsave-introduced regression bug. I have fixed and > attached the patch with this email. > xsave-migration.patch contains all the changes you have reverted plus > the fix I made. > xsave-migration-fix.patch only contains the fix I made based on > original xsave patch series. > > I have tested the patch in the following senarios: > 1> Non-xsave platform > 2> Xsave-capable platform, guest does not support xsave, xen support xsave > 3> Xsave-capable platform, guest does support xsave, xen supports xsave > 4> Guest (non-xsave) saved on platform without xsave, restored on a > Xsave-capable system. > All passed. > > Could please have review? Thanks! > > Again, sorry for the regression caused. > > Signed-off-by: Shan Haitao <haitao.shan@intel.com> > Signed-off-by: Han Weidong <weidong.han@intel.com> > > Shan Haitao > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel