Xen devel - Nov 2010 - RE: [PATCH] pygrub: support grub2 "(hdX, msdosY)" partition syntax

> On Thu, 28 Oct 2010 00:06:09 +0200:
>
> On Wednesday 13 October 2010 12:45:35 Stefano Stabellini wrote:
>> On Tue, 12 Oct 2010, Ian Campbell wrote:
>>> # HG changeset patch
>>> # User Ian Campbell
>>> # Date 1286899422 -3600
>>> # Node ID 372959917c012db7d90aad0626a4af6b8f9b186f
>>> # Parent 2b9d32cb419d65622d213f501926c024dcfc306d
>>> pygrub: support grub2 "(hdX,msdosY)" partition syntax
>>>
>>> This appeared in Debian Squeeze at some point.
>>>
>>> Signed-off-by: Ian Campbell
>>
>> applied, thanks
>
> Could you apply it also to xen-4.0? This bug hit me today.
>
Another patch that was reported by a Debian user taken from the bug report at:
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=599243


A simple way to fix this, at least for msdos partitions, is:
--- GrubConf.py.orig    2010-08-29 11:13:20.000000000 -0400
+++ GrubConf.py 2010-10-05 23:27:57.000000000 -0400
@@ -76,7 +76,7 @@
         if val is None:
             self._part = val
             return
-        val = val.replace("(", "").replace(")",
"")
+        val = val.replace("(", "").replace(")",
"").replace("msdos", "")
         self._part = int(val)
     part = property(get_part, set_part)


Not sure what the pros and cons would be between the two patches, but I thought
I should just share the alternatives :)


-M
 		 	   		  
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Mike Viau writes ("RE: [Xen-devel] [PATCH] pygrub: support grub2
"(hdX, msdosY)" partition syntax"):
> Another patch that was reported by a Debian user taken from the bug
> report at: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=599243
...
> +        val = val.replace("(",
"").replace(")", "").replace("msdos",
"")
...
> Not sure what the pros and cons would be between the two patches,
> but I thought I should just share the alternatives :)
Thanks.  I think the patch we have is at least as good.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel